Date:   Tue, 24 Jan 2023 13:15:34 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubecek <mkubecek@suse.cz>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v4 net-next 04/12] net: ethtool: netlink: retrieve stats
 from multiple sources (eMAC, pMAC)
Message-ID: <20230124111534.6eah24trofndera6@skbuf>
References: <20230119122705.73054-1-vladimir.oltean@nxp.com>
 <20230119122705.73054-5-vladimir.oltean@nxp.com>
 <CANn89i+-Vp3Za=T8kgU6o_RuQHoT7sC=-i_EZCHcsUoJKqeG9g@mail.gmail.com>
 <20230123223033.3ad37ccc@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230123223033.3ad37ccc@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X+Rh8b1tqWwtkiHb2douE4gyCX95VNZJXSu8Q8/+zBLF/A4b/etHRGPLQlqI?=
 =?us-ascii?Q?u1DlLnAOIIxdhMIPn0pMaSHhOr1JVdbxaiGZmYzxXQ4eAlfSDPBrWBiwfd5S?=
 =?us-ascii?Q?IByH+zx93wgpvOyCHp3FPUfaBft6M90mtjsjTjQhUMQyMAyNO19rN6hTBcmc?=
 =?us-ascii?Q?o5qECs1n23miLNLTOQW/FD+CGGfrKcsXjIq2F52YxRBiKYCAhz7nw3qsmNby?=
 =?us-ascii?Q?rUWCiN7xWWQKrmDXQuRx3iSzJ09jGRD0feOb+nYGH8AvTohpw2g0fZjDFxgZ?=
 =?us-ascii?Q?xY62pFV3xxp+KVC5l0G0R7/MwQOmJjSBebxhy/ZFxxzvrthh6eM6CzcCWwwy?=
 =?us-ascii?Q?QI57OnitqiTb7nVZXEVRuinHN5fodXcw0TrK/T8YpZALHGvupmoWpgAk4PMM?=
 =?us-ascii?Q?GOj68IxzVekp4IMYvuREdo997st0ztqidVxMtDGWYD3MZAq1B49+/LrLh0qB?=
 =?us-ascii?Q?SFF1vgqtMdImoccA5jLQnmMRR/IvqucX99GbOiwJgeHKIqGfVLAD8+ZtnvkE?=
 =?us-ascii?Q?tDI+Ux46EHTPT/LDtRiK9bBIgTcXJGcsl4f417DRtCYxe6tf48QqadTkROeh?=
 =?us-ascii?Q?bVxnuP0xDUzSngOF54AtvIRuJ9Tgv7KwLiKm3PuhGEJLsfozEnQ8Rm0jiOiP?=
 =?us-ascii?Q?ynXmBVNtHKiEP4qvmyNObbHDbdZ289YvNZsGxk6obVlOmq1iUt/66+ycu7aB?=
 =?us-ascii?Q?A78ah8Eo/XCDitM6htql2pz30KEsYkGMSJhSuPxVzjA0kETXr74Ru/unMdGZ?=
 =?us-ascii?Q?AAvPXCV4GtWdHXnySK1NXjY5NF4ceKKalGv95p0fS7eUfN+lHG0Xg9WkmIv4?=
 =?us-ascii?Q?yuqGfVEKx+FVOeI4+wp4hzFy2pHwR95HLN9Ta4xmauy8W9pUyTet5hTfIHWo?=
 =?us-ascii?Q?U8xrtZ0LVp0FNHWICiheii8AzQ93fQ4GI6WNgWKE4097MfKZPXplixSeOcEP?=
 =?us-ascii?Q?4v38hWwX1r5GpdtiIvQCu2HhgVKy2kKanDx/wL7wJqNtClMM+wO/gL48/SGO?=
 =?us-ascii?Q?PsQn9CjqneQn2edLxa6BjoxoUSthUhwnhqnvnwhp4klMuHDdud0eFaYHOb2n?=
 =?us-ascii?Q?/jJua1EA15LvFOVTvrVzQ6/WnP/TzVOIREMq5CLtsgQCAoeIRXzg+7V9XYad?=
 =?us-ascii?Q?9CHXMQiKKH8NOaibBFCuAk7pZzplheGQ+iXo61isctCkeJHJ5/DyxO4IxORM?=
 =?us-ascii?Q?QAoz3OLSi6uMcIrQs4J5CbBSRiWuerhE72xwO68tUBNyVFKVx0djJmOy8Zoe?=
 =?us-ascii?Q?kTPZx2SQ0A3NItCav2+IhZIdEiAF3RqUWh4DNaZ3q4CHfFj8MQWhlvyolqd7?=
 =?us-ascii?Q?uWwcfYDT0nqVKv5hRztSFsfLSHM2c1qcjzhSorpj4pSsX+ux0XFC9WGH54Kj?=
 =?us-ascii?Q?YfvNk1hIEQCVSMs2J5WQSI10s2v+3sR/JxU0nNLbqKlZMIGUevFpwyh4ti08?=
 =?us-ascii?Q?AMNVLBOZ+LY/toGjqsfoD6uufGeb4gUHq9McS5HH6urVaVfxOh780tz/YzUl?=
 =?us-ascii?Q?Y1yIJYEVlSKEpZdMp40JKnIg6IF1kyFxU7WoATQ3o3+ihc44W5VySUGrO/tm?=
 =?us-ascii?Q?o0MIn4ILQxzPdyE6Eipyij/Z1aYlIjz4q1YSBefB73Bza/IFmRAjsJnpEC79?=
 =?us-ascii?Q?8Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d39ed8fc-b86b-46fe-acf2-08dafdfc525d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 11:15:38.4146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gKHivyObMVYk+nIXWGBJzGSwRpIQZZxkxr5djLdCfiYRrvOutTvV3wW0pgqQ/y+YOt2jb8MImcZ2s8s+RyWI/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8118
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 23, 2023 at 10:30:33PM -0800, Jakub Kicinski wrote:
> On Tue, 24 Jan 2023 07:20:20 +0100 Eric Dumazet wrote:
> > >  static int pause_prepare_data(const struct ethnl_req_info *req_base,
> > >                               struct ethnl_reply_data *reply_base,
> > >                               struct genl_info *info)
> > >  {
> > > +       const struct pause_req_info *req_info = PAUSE_REQINFO(req_base);
> > >         struct pause_reply_data *data = PAUSE_REPDATA(reply_base);
> > > +       enum ethtool_mac_stats_src src = req_info->src;
> > > +       struct netlink_ext_ack *extack = info->extack;  
> > 
> > info can be NULL when called from ethnl_default_dump_one()
> 
> Second time in a month, I think..
> 
> Should we make a fake info to pass here? (until someone finds the time 
> to combine the do/dump infos more thoroughly, at least)

Thanks for letting me know. I've sent 2 patches that fix this for
ETHTOOL_MSG_PAUSE_GET and for ETHTOOL_MSG_STATS_GET:
https://patchwork.kernel.org/project/netdevbpf/patch/20230124110801.3628545-1-vladimir.oltean@nxp.com/
https://patchwork.kernel.org/project/netdevbpf/patch/20230124111328.3630437-1-vladimir.oltean@nxp.com/