Message-ID: <e5bffb1d-f9d6-0799-bb7b-03dc8dfa0355@linaro.org>
Date:   Tue, 24 Jan 2023 12:02:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFT PATCH v3 4/6] arm64: dts: qcom: sdm845: move codec to
 separate file
Content-Language: en-GB, en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230123084300.22353-1-krzysztof.kozlowski@linaro.org>
 <20230123084300.22353-4-krzysztof.kozlowski@linaro.org>
From:   Caleb Connolly <caleb.connolly@linaro.org>
Organization: Linaro
In-Reply-To: <20230123084300.22353-4-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/23/23 08:42, Krzysztof Kozlowski wrote:
> Re-organize SDM845 audio codec into separate, audio DTSI which
> should be included and customized by the SDM845 boards wanting audio.
> The codec node is anyway not a property of the SoC, but the boards.
> 
> On all others boards not using audio, keep the Slimbus node disabled as
> it is empty.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>

I'll give this a spin later and resend OnePlus 6 support.

> 
> ---
> 
> Changes since v2:
> 1. Drop sound node in DTSI - affects devices.
> 2. Drop "audio" from DTSI file name.
> 
> Changes since v1:
> 1. Move also sound node.
> 2. Rewrite commit msg.
> 
> RFC - please kindly test the boards.

--
Kind Regards,
Caleb (they/them)