MIME-Version: 1.0
References: <20230109094247.1464856-1-imagedong@tencent.com>
 <504cc35a-74a8-751a-5899-186d7a0aff87@meta.com> <CADxym3bRciuyM1nYCrbaAwSMRJQvgV=hJFSLeiu9jysejPaTQQ@mail.gmail.com>
 <6c14e7ad-3b6d-4f88-64b8-8e3968d2b2e6@meta.com> <6455133c-87a2-1a0f-7da4-f8b99f02fc95@oracle.com>
 <CAADnVQJRntdqa4uCHtTrQNAsgGS13DtNV-ue2wTdHQxiuLo_Yg@mail.gmail.com>
 <03e16727-7a0a-0e1e-e9b9-c947a64becb9@meta.com> <eaf64a4b-85ab-bb5a-5c33-d7cd80b034e7@meta.com>
 <7bfb49fb-99c1-163a-fb86-3e72369adbf6@oracle.com> <ac273c04-3066-dd63-934c-f62650c41f8f@meta.com>
 <22f18176-8771-41a6-4677-7cc805a07350@oracle.com> <50c0ac5d-1507-5b9e-6670-8ec654c40559@meta.com>
In-Reply-To: <50c0ac5d-1507-5b9e-6670-8ec654c40559@meta.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Tue, 24 Jan 2023 04:25:46 -0800
Message-ID: <CAADnVQKZ8ipS97bw3wDegnw_rpNRG55vEnsGjW+tkCyQ-MYjcg@mail.gmail.com>
Subject: Re: BTF, pahole and static functions (was Re: [PATCH] libbpf: resolve
 kernel function name optimization for kprobe)
To:     Yonghong Song <yhs@meta.com>
Cc:     Alan Maguire <alan.maguire@oracle.com>,
        Menglong Dong <menglong8.dong@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Menglong Dong <imagedong@tencent.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 23, 2023 at 11:18 PM Yonghong Song <yhs@meta.com> wrote:
site.
> >>> So perhaps the best approach is to eliminate such inconsistent static
> >>> function descriptions? The actual amount is small, ~100 functions.
> >>
> >> Removing these inconsistent static functions could be a simpler
> >> approach.
> >
> > I took that approach with
> >
> > https://github.com/acmel/dwarves/commit/80eaecdb00b3d79becc2133b854593277093b115
> >
> > Static functions with inconsistent prototypes are left out of
> > BTF encoding. Given that the numbers here are pretty low (around
> > 100 or so, not including .isra functions which have inconsistent
> > prototypes due to optimizations), that seems to be the simplest
> > solution for now.
>
> Yes, I am okay with this approach. This will prevent user mistaking
> kprobe a wrong function and this is what we want for now.

Let's proceed with the fix first and then discuss improvements on top.