Message-ID: <ebfcef92-d892-1d7e-004a-1899da968d16@amd.com>
Date:   Tue, 24 Jan 2023 23:37:46 +1100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH kernel v3 3/3] x86/sev: Do not handle #VC for DR7
 read/write
Content-Language: en-US
To:     "Nikunj A. Dadhania" <nikunj@amd.com>
Cc:     kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        Yury Norov <yury.norov@gmail.com>,
        Venu Busireddy <venu.busireddy@oracle.com>,
        Tony Luck <tony.luck@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sean Christopherson <seanjc@google.com>,
        Sandipan Das <sandipan.das@amd.com>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Michael Roth <michael.roth@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Kees Cook <keescook@chromium.org>,
        Juergen Gross <jgross@suse.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Borislav Petkov <bp@alien8.de>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20230120031047.628097-1-aik@amd.com>
 <20230120031047.628097-4-aik@amd.com>
 <adc11ed3-de89-a389-e629-3c951257469c@amd.com>
 <533c5c83-b68b-eff0-d36d-9963194ab844@amd.com>
 <b30d6f61-2dc9-4c4f-dbdb-a48c186745d3@amd.com>
From:   Alexey Kardashevskiy <aik@amd.com>
In-Reply-To: <b30d6f61-2dc9-4c4f-dbdb-a48c186745d3@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGdxaDg1Y21ycm9aM00xT3JsWExRQm15R0g5OWRkMjBaWUpkejNuMnNXbnF3?=
 =?utf-8?B?NlhSeThTd243Qk5zNTl2YnQwM2hyY1pTRTk2dHhkWFVpWWFYMmZnekZHemFM?=
 =?utf-8?B?aWo4MFhZUXp4aThibVBjNmxOb0xVVWh0OXZYWFhLYU5OMThOSlhOamFhdzk0?=
 =?utf-8?B?TnpXR2pzOXlaT0V1elJvN2pJb05qUjdpK3NVdS94VzdRSVJ6TGtHeXo3V2gx?=
 =?utf-8?B?ck5NejNPVlRPUis2bTdlbzh0MmpOUWV5My8wOUkvbUNuV2xuV0prUkdQSEYx?=
 =?utf-8?B?MCtlN2ZIR3RDYWYzZURQM2hSQzRUS09EaGxRTUxLa09CVzBCeFBwbnZFbEQ5?=
 =?utf-8?B?RGxrUDAvQndzTXU2R0Q2OVNhSmpNSGcxdUFmcnB3TDJYUVEvbHlxYWdLbFl1?=
 =?utf-8?B?UFlhaExEc05XYVhCdEN0R1NIV3hnbElqb2VmVG52eEFIbkZndWRZVThFVUVJ?=
 =?utf-8?B?T1dYOWxXQUF1RUhLU2FnUFRiQWNJUmVvQkZEVGRsOHljeDhsSTlJNThMRWI3?=
 =?utf-8?B?cndieExPZUVsL0FQMGZZVnZaZ0JuRjNRUkx6b3RqRUNmdkNneWZhdW9ieW95?=
 =?utf-8?B?TjFTSTNkTXVndzJWenBLWDRNZEplOUVRQ2xjWFprWC8waDNhck9Hc28yek05?=
 =?utf-8?B?bitCcklUZXlqMkVTUFZMMmZOaWQzcWo2Wmg5bDNENG55RjRZQnpwbWtYaksy?=
 =?utf-8?B?K2FnK2ZxK05lanBJMStvV0lnL0ltZFpsZTJZSWpBK1FBTjdGYUVkY0N2RXFR?=
 =?utf-8?B?YW1aZ0RlQ3JkYnAyNENmVkNsL2V4c3h6cHUxRmFQYXNZWmxtRW9tVUQwNlhn?=
 =?utf-8?B?bFNQVi9ObDdDMGE2c2t2UWh0Y09pWlJ0djdkQTMwMDA5Y0JVM2pWQVcwbHZh?=
 =?utf-8?B?VXF0TVB4TnlTNWJZNHV3M1l4UVZKSyswVHZiK2w0YThOVGthd3lPUUVmY2pI?=
 =?utf-8?B?clJ0OWVidDErTUo2THowVHJ1OGFBS0I0WEFHNStMSFQxMFZaOWo3ZE5tb0R3?=
 =?utf-8?B?YWNHeWFNYWVudklEb2c3RkFHRGhDUnk2UmtFMHE3dDZyRi9SNGpuVW1ad01B?=
 =?utf-8?B?TUNadnhPeG5aSThONFdUbytXOXhJTnpDU3VRVU50aXNjZVkrZDJYNEN0b0t5?=
 =?utf-8?B?cHg5UXhrZzl5eEI2dmZpWVNnVkJiNVVscDlIQVpzVmIzUlkzSGRJOWMxcGdJ?=
 =?utf-8?B?S29WSUIxQm5FYmljdkMxd1RBTGtBRFVQWDVHVWw2Z3NneTlhelBIRTdDallv?=
 =?utf-8?B?d2treWYvOE9tV25mSWRFRXY0OU83bE5DS3JEZjBuTURpaGEyT1Jja0toQlU1?=
 =?utf-8?B?ckd2N3VhdCtUbVl1L1A1Vkl5dnRVT1NnRllVTTBhdG1aWnFUN3lHcTFxMkdJ?=
 =?utf-8?B?dEFGcEZIM1lCQ2tCZ2U2K1k1OEQvQWhVSDcyL0JZdCtFYkFLUGZ6bDFWS2Mw?=
 =?utf-8?B?OXdENHdVVS9wb0kzcm10ZDBaRGcrVUZySGRjOFU2RHR1ck10VXM2RnQ5c0RP?=
 =?utf-8?B?U3dtWFRJaXpudWRxVFNoUEw4eGVoTHpyTU5jcEw2U0QwYURUR0xKNG1zMGpP?=
 =?utf-8?B?SncwN3FGQWJQdUl4dWlpNElyRGlmeW1NWllUSHorblg5U1F1STRYYU50VU13?=
 =?utf-8?B?OC9QN2lhZ1NMMFNkS2taMVc4MU9iZ2M2MnBQeGpQc3JuczRlQjlOdjVUQi9t?=
 =?utf-8?B?aXdmL2t2OC9xNXU0WG5saFFFcDJWSnhyNFlxNDdGalNKVTFEd0FuUGF2M29z?=
 =?utf-8?B?dWpmNnlqdWJSMUs4RThtVHU5U2JpWUZhM1VjQmVZNkYwYnhMZHo1Y1Y5Wm9N?=
 =?utf-8?B?dGJJSis4aC8zUzlKeC9PckJ1clRsUkxXWmNwL0ZuR0lGazkzTHJCUFkva3NI?=
 =?utf-8?B?eVlRMGtwaHdhdHpSU3Juc3BvQkFpWCtXck9ocFRqTkttWkdyYWl2eTNaeHFu?=
 =?utf-8?B?blBPVVNUNmdRZW82ZzZHdmx2Y2J2MXF2OHk4dVRSdWdjbmdpY2NFeGFqdzZX?=
 =?utf-8?B?QVNYZU5mQUJmWlE3YjNqQ3FqT2hQYktaYTBkUjA1dVMwQWpXVzdNaTB2VmNY?=
 =?utf-8?B?OHE4d0RZYzBSWFhpbUk0NDJ0dllRM2kxeEE3bmdGOHl3Tkl5eUtjV3ZCU3Ix?=
 =?utf-8?Q?VUfXnOFCX/Q9WmsEvn+88C+WC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc6d7d0b-3c57-4f44-ac90-08dafe07d566
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2843.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 12:38:02.8754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9dzbxJQKY8I672qmDQCFIvFl0hcnNKcKLprubApA3Q231JtP4QaYNNDghk52FEW4mtVti8DrU0gMHp2m6NrRgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6979
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 24/1/23 21:37, Nikunj A. Dadhania wrote:>> It is 
MSR_AMD64_SEV_DEBUG_SWAP (SEV, not SNP), it is an SEV-ES thing.> Yes, 
noticed that, earlier analysis was that Debug Swap shouldn't need any 
guest side changes, but it does need it.>>> Why is that feature 
negotiation SNP-only and not SEV?> > As per the spec, GHCB termination 
request: reason code: 0x2 is SNP features specific.
Does the guest really need to terminate in such case? A VM could just 
not do the GHCB thing if it does not want to.


-- 
Alexey