Date:   Tue, 24 Jan 2023 09:13:30 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     David Howells <dhowells@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        linux-mm@kvack.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Message-ID: <Y8/ZekMEAfi8VeFl@nvidia.com>
References: <20230123173007.325544-1-dhowells@redhat.com>
 <20230123173007.325544-11-dhowells@redhat.com>
 <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com>
 <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RaCSqPvhO8Cb1+dzHBtJHQa5CJLTlQm3XhG8BGgEqxwq0uD6qQjeM6MC/tGK?=
 =?us-ascii?Q?VxChK21aqTBN6keoAm4kGwqfE4e0doZjsHKytx3zfvSbFeyPM+zas6D9/KLV?=
 =?us-ascii?Q?/H8KK6DERwEcWLcYWPYJCukNYoH+TwsbOp04bCu5G2dXoAf2Qggp6QUJbGW4?=
 =?us-ascii?Q?5FJ+FXx8Y+JUhtbAf2ueXGn6H5ANNHLuq/TRn/4qUvW3HW6G+nzF/WvU+M5H?=
 =?us-ascii?Q?4dqEEwA/Sg1Lclh6gc+4ozRT5o8jQs7bvjkl/zDuckmDtfAJI/FWPr0kjER/?=
 =?us-ascii?Q?xBWa3C9SYiNI3NQ+wA8wVBgyUFe+4hAxO9FXBVianGplwaHKc1sn5eO+78Zt?=
 =?us-ascii?Q?ANMaYOJajTK6dYnomb3QWiBWq1xEQYlmC5S28I0nzOz8LNPkz5kUl1mL9/uJ?=
 =?us-ascii?Q?OYMuN1eb1Urk2nBLk5e1k5UV/w+2LajfC1gzZyDYKBHsHVPfcT2w2seeVk1l?=
 =?us-ascii?Q?XHH0wZZHZYeq0WhnW+BlpraDSTLgquUXeb/ukvjLJEkyL5Oa95zm9JSqISBZ?=
 =?us-ascii?Q?DEBFxPz6jY/lVWDBnd/CR9sP+wNSUk9eKl0oVPzoKfxY9V58ZC+Vn480iD9J?=
 =?us-ascii?Q?LdgGXRiBrowu5oZsl6wWyUu3/oOkoH3m8cWHXp9rXsYoIQiAqMF129xlvXdv?=
 =?us-ascii?Q?S0IjH1gsVKG8xMnQUScNzXtBzVCEQxUWV1T6GElhomCGwMp1Ihq5saCLh9Yp?=
 =?us-ascii?Q?96KXHkL9Vj0cDpBFdmR2ewhWymDoV2lnsVLAJ0I8nojBac8krM1uqSBZAZij?=
 =?us-ascii?Q?rf3EVlc3y53AtSV4uzmRafNMptQAxmN9itK5oxuGNGNs6QaVnZqYvYBCJsCt?=
 =?us-ascii?Q?Dkg0EON7wU1YTyP1wOea0NPBSIvSx9HwkagY/yQ99VSFuSWvNla0KzzD389a?=
 =?us-ascii?Q?xShYZQxE23pnG/SRYUoZu/0/mmA4uBU6BXnITty+hZlwdUhbxbVBl6zCg6pu?=
 =?us-ascii?Q?cjfXhTsFLRVzyCkyAh6CqH0NBNy12gmderVqEE9+rC6Mejdj64LrkaNnuVk6?=
 =?us-ascii?Q?RhceHbyO4G8F9oeT33LXmha6plt8f6p9J4cBcCUdLf6vg2u/HqfYNPQz86pq?=
 =?us-ascii?Q?/ZIe83/plNByJEoMV2P7lMALg+GWub5WW/k0jKrrM7OO6qER3gfYfR7Avl7g?=
 =?us-ascii?Q?ZOReKMSmGf0X83zsi+fLlFBy4uvBAW7z/f2UYTr7+soCnJUhB4FHKuB067yZ?=
 =?us-ascii?Q?ybHO10JrWCJ1iN54EUpuj4+yxhB4FjYYMD/eWoamvk/CwAEDJ0aCNCQHCr77?=
 =?us-ascii?Q?wrJzgGwSaeYl3NFEM/Rz63Lv8UWTydwh8t5B6lOVOgTitWzm+lvkCAQ3sjX+?=
 =?us-ascii?Q?+J93vKgQ3qukl3TZ7gbwshsL054wcMqU+GG4N3NljVaiMj4jVMYmRl2XNZf5?=
 =?us-ascii?Q?TbxsXOKkRJldjUOn3FHnfvVfYt/HpNx93Gl17ipG9yqR6CisKPydLHGk8+hV?=
 =?us-ascii?Q?i26nY45NcdpYsiqz+TO0UO2uouer9eCJXWC7Dy1c7DHEM0j6geujad8LJUG0?=
 =?us-ascii?Q?8utKe/5x8MRID4LnP5jGoQMsz9uhBjUi6JKGFzha3NnQG0DxoURaUAqxSvET?=
 =?us-ascii?Q?WnLe8lKTClL8txH8RYBEe6kxEQGAwYa99jT4046w?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f769b227-2f89-494c-cdd5-08dafe0cca69
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 13:13:31.6591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bXoMfrXIXUWgNJmlnNiPGkMIK1rPgChf5Ghcs23vfeYRMm78tisiSsFSztHDet8p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8422
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 23, 2023 at 07:11:42PM -0800, John Hubbard wrote:
> On 1/23/23 19:08, John Hubbard wrote:
> > On 1/23/23 09:30, David Howells wrote:
> > > Renumber FOLL_PIN and FOLL_GET down to bit 0 and 1 respectively so that
> > > they are coincidentally the same as BIO_PAGE_PINNED and BIO_PAGE_REFFED and
> > > also so that they can be stored in the bottom two bits of a page pointer
> > > (something I'm looking at for zerocopy socket fragments).
> > > 
> > > (Note that BIO_PAGE_REFFED should probably be got rid of at some point,
> > > hence why FOLL_PIN is at 0.)
> > > 
> > > Also renumber down the other FOLL_* flags to close the gaps.
> > 
> > Should we also get these sorted into internal-to-mm and public sets?
> > Because Jason (+Cc) again was about to split them apart into
> > mm/internal.h [1] and that might make that a little cleaner.
> 
> I see that I omitted both Jason's Cc and the reference, so I'll resend.
> Sorry for the extra noise.
> 
> [1] https://lore.kernel.org/all/fcdb3294-3740-a0e0-b115-12842eb0696d@nvidia.com/

Yeah, I already wrote a similar patch, using the 1<< notation, 
splitting the internal/external, and rebasing on the move to
mm_types.. I can certainly drop that patch if we'd rather do this.

Though, I'm not so keen on using FOLL_ internal flags inside the block
layer.. Can you stick with the BIO versions of these?

Jason