Date:   Tue, 24 Jan 2023 13:31:06 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Pierre Gondois <pierre.gondois@arm.com>
CC:     <linux-kernel@vger.kernel.org>, Dan Carpenter <error27@gmail.com>,
        kernel test robot <lkp@intel.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Gavin Shan <gshan@redhat.com>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] cacheinfo: Correctly handle new
 acpi_get_cache_info() prototype
Message-ID: <Y8/dmlR7p5rIbRLF@wendy>
References: <20230124123450.321852-1-pierre.gondois@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nk57ke8/f2usmaAy"
Content-Disposition: inline
In-Reply-To: <20230124123450.321852-1-pierre.gondois@arm.com>
Precedence: bulk

--nk57ke8/f2usmaAy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey!

On Tue, Jan 24, 2023 at 01:34:46PM +0100, Pierre Gondois wrote:
> commit bd500361a937 ("ACPI: PPTT: Update acpi_find_last_cache_level()
> to acpi_get_cache_info()")
> updates the function acpi_get_cache_info().
>=20
> If CONFIG_ACPI_PPTT is not defined, acpi_get_cache_info() doesn't
> update its *levels and *split_levels parameters and returns 0.
> This can lead to a faulty behaviour.
>=20
> Make acpi_get_cache_info() return an error code if CONFIG_ACPI_PPTT
> is not defined. Initialize levels and split_levels before passing
> their address to acpi_get_cache_info().
>=20
> Also, in init_cache_level():

Hmm...

> - commit e75d18cecbb3 ("arm64: cacheinfo: Fix incorrect
>   assignment of signed error value to unsigned fw_level")
>   checks the fw_level value in init_cache_level() in case
>   the value is negative. Remove this check as the error code
>   is not returned through fw_level anymore.
> - if no PPTT is present or CONFIG_ACPI_PPTT is not defined,
>   it is still possible to use the cache information from clidr_el1.
>   Instead of aborting if acpi_get_cache_info() returns an error
>   code, just continue.

To be honest, these feel like entirely separate things that should be
in different patches. You've got:
- Dan's smatch fixes
- a redundant check being removed
- a behaviour change for if acpi_get_cache_info() returns an error

> Reported-by: Dan Carpenter <error27@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>

How about Link: to the LKP/Dan's report?
Link: https://lore.kernel.org/all/Y86iruJPuwNN7rZw@kili/

I did a quick check but didn't don't see the LKP report...

Also a Fixes: tag too, no?

Thanks,
Conor.

--nk57ke8/f2usmaAy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY8/djQAKCRB4tDGHoIJi
0ullAQCykmFyIh/vjpHYTKvq97fTTrk+p6uQxzD/5NrxVPUh6gEAvlyvCAfISQHE
QRsAEdOLOyv31XHz9mXhbr+UM7vmcgo=
=fhiN
-----END PGP SIGNATURE-----

--nk57ke8/f2usmaAy--