Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57815C54EED for ; Tue, 24 Jan 2023 13:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234006AbjAXNll (ORCPT ); Tue, 24 Jan 2023 08:41:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233895AbjAXNlj (ORCPT ); Tue, 24 Jan 2023 08:41:39 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F751BE5 for ; Tue, 24 Jan 2023 05:41:38 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id A515567373; Tue, 24 Jan 2023 14:41:34 +0100 (CET) Date: Tue, 24 Jan 2023 14:41:34 +0100 From: Christoph Hellwig To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Keith Busch , Chaitanya Kulkarni , Gerd Bayer , Sagi Grimberg , Jens Axboe Subject: Re: [PATCH] nvme-pci: Switch back to sync probe to fix rootfs mount regression Message-ID: <20230124134134.GC25796@lst.de> References: <20230124004542.29659-1-ville.syrjala@linux.intel.com> <20230124062140.GA29175@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 10:47:59AM +0200, Ville Syrj?l? wrote: > On Tue, Jan 24, 2023 at 07:21:40AM +0100, Christoph Hellwig wrote: > > Err, no. We're not going to randomly revert things. If you want > > to be productive check the one liner Keith reported in reply to the > > last report. > > No idea what that previous report is. Care to share a link? https://lore.kernel.org/linux-nvme/849c43bc-7488-72a6-f6fc-8700639b0c79@leemhuis.info/T/#m759092f541ea29fcb41911890307e70868636a45 Patch to test: https://lore.kernel.org/linux-nvme/849c43bc-7488-72a6-f6fc-8700639b0c79@leemhuis.info/T/#md13c22b29cd81bd0ce9167c271c582005ba30550