Date:   Tue, 24 Jan 2023 09:47:50 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Howells <dhowells@redhat.com>
Cc:     John Hubbard <jhubbard@nvidia.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        linux-mm@kvack.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Message-ID: <Y8/hhvfDtVcsgQd6@nvidia.com>
References: <Y8/ZekMEAfi8VeFl@nvidia.com>
 <20230123173007.325544-1-dhowells@redhat.com>
 <20230123173007.325544-11-dhowells@redhat.com>
 <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com>
 <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com>
 <852117.1674567983@warthog.procyon.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <852117.1674567983@warthog.procyon.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y93cqHX068NjmZ+6vFQXvc8wszoXOJ7RDqTIx9lqEuj6jRtxPzUsQG7bir4u?=
 =?us-ascii?Q?2BP4XzxR4TQo3iPHDRUg+qYomzBxyGTJcitro9mW4q5t+Py0cPKcXIOgyqA7?=
 =?us-ascii?Q?LTyspWDZY6LIo9mTh03u9KL8Yd7cX8WwSOPeOgRMgyLaxEZ2TfH13sR5q7P1?=
 =?us-ascii?Q?IzGrVBnU642XfxSg93EDsoatsIyqdUr6XBZBGQtjhHnVv3uSVV3YMz5azGCs?=
 =?us-ascii?Q?JBZX3bKOF0leuHqsUmwKWyJYJ50FAkZvSSPRiO8X9boQkRn19mD0b7OdnOJi?=
 =?us-ascii?Q?ywMAENEgng2pf+xKoQnJv7nSbo6Upht3noPIufOkWMXwGpGHg6Po5/PNgAQ9?=
 =?us-ascii?Q?2ebBalBRCPlFgDiM8AvEM0FcLkJylfp8UeWNU563kmDevCMJcodGu0rg789a?=
 =?us-ascii?Q?vbgzGExxufxW34s0a6CyEw8tR7o/B9Lc1QxsjtE5XjlUPD+XSWML2v8oOOQg?=
 =?us-ascii?Q?iSPweL4GuXBOnv5gmhin2y551k24iSlhhH/JGP+XbQaXIQuS2VWeAHpyoqeb?=
 =?us-ascii?Q?geZa4EkGrGdL2c/zTH11zshTsOEUkd4thaktp14SvYOSWHwc9bVdQ/7o2uT9?=
 =?us-ascii?Q?Zjb/N+mmB0xFxC453AsUk3sNDlaOOyzp1h1VvsZSHu6T2vecSyPrX45NOoCp?=
 =?us-ascii?Q?yNj5+lHkasMNqdR9JwnvWp+2mIsrfaUurFWUSwJh8gs2u9i+72b8wqLLsYyS?=
 =?us-ascii?Q?PcBI3YMDk9+rH9p68/69lmAcYZnPuldHTmO/pnz9QcS/pR8U66IcRG2z39YK?=
 =?us-ascii?Q?T/r1huWhoVxvGopxQkle8VpseCH+RVf7jbEVwrzCuS9LrTBwq02d9LhXSDsa?=
 =?us-ascii?Q?0NZxsOVxiaSZgMr9VE9qf7sdZGjcoWvKLgi8ezAuTRngeBccRf5FPhGOtfnl?=
 =?us-ascii?Q?qwM/0a4SST9d3ucBvqHRu5/Vg998W4iHQZbcu7V3tKpqgMyXyGFAEM/B4DfI?=
 =?us-ascii?Q?DD+YLQiv4QedWh7qlmG6qeVTTaFCtlS1fNMaFg0g/ASlPalMLN257EuTU0QX?=
 =?us-ascii?Q?6IyLx8UlG7uhwLDIG3KbSEHt0iuA0Sje1hosgSFjuN2jU1k8PcKa2UT5k4fk?=
 =?us-ascii?Q?qjbIzmqxw2RoIFGci74n2Ajlsivap7WwfVzdJjJz1Y8TMivebW8FlL56eJ+/?=
 =?us-ascii?Q?+O8R60RV3OnkWiDBnt+OCcVO8WNKvMljKD25n+i+g+8mxaDEE5LthvH3WKn3?=
 =?us-ascii?Q?PapydQLLb7rL0ZziRlDO0xT1THdgo6RzVhfwVbvkKQy6hCOyvMBXfpL9VLKS?=
 =?us-ascii?Q?Kov2n3XWxlaalqMm8nlGOjag6/mTsIeEnOnYOqyZz8FiVsN+JyIVH5R5dEhF?=
 =?us-ascii?Q?wWvOTbZcjB+E8tBRWsBc3ZRk/Yj7ZNSedmgZYrd59VSqDV3zYMXjbVH7RL+g?=
 =?us-ascii?Q?4IqIqmIUKLRly53/D26Py5C1zD+cK7ZXYNXvLj5fi/G96MJbNIk2woplhk/e?=
 =?us-ascii?Q?A/bL0247HLPS+DuU4/jlXyCwTsgzdcXl9aUJyoQs2m8cSvdnrGWQqh4KfWsl?=
 =?us-ascii?Q?NZn4edx5rzBWBBZpouGlyngLrZoS6OOvAd5nJOMfRNT0+HCa6SxrWJH3ZkvC?=
 =?us-ascii?Q?d6W+RiBSl4E+zKQ5ReGjnxPFiE3cw7A/cO3Zpj5O?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31f821d3-c2ee-4ba4-8d1d-08dafe1195dc
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 13:47:51.0067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wcu892uNs6+MHOlwbvsQBRod+EvJMXtP34vhC5xdBqB0Qs46pvNS4bcT1VEYs7jD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6043
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 24, 2023 at 01:46:23PM +0000, David Howells wrote:
> Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > Yeah, I already wrote a similar patch, using the 1<< notation, 
> > splitting the internal/external, and rebasing on the move to
> > mm_types.. I can certainly drop that patch if we'd rather do this.
> 
> Note that I've already given Andrew a patch to move FOLL_* to mm_types.h.
> 
> I'm happy to go with your patch on top of that if you can just renumber
> FOLL_PIN to 0 and FOLL_GET to 1.

I moved FOLL_PIN to internal.h because it is not supposed to be used
outside mm/*

I would prefer to keep it that way.

Jason