Date:   Tue, 24 Jan 2023 10:00:28 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Howells <dhowells@redhat.com>
Cc:     John Hubbard <jhubbard@nvidia.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        linux-mm@kvack.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Message-ID: <Y8/kfPEp1GkZKklc@nvidia.com>
References: <Y8/hhvfDtVcsgQd6@nvidia.com>
 <Y8/ZekMEAfi8VeFl@nvidia.com>
 <20230123173007.325544-1-dhowells@redhat.com>
 <20230123173007.325544-11-dhowells@redhat.com>
 <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com>
 <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com>
 <852117.1674567983@warthog.procyon.org.uk>
 <852914.1674568628@warthog.procyon.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <852914.1674568628@warthog.procyon.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BUwkBA1cvgvd1xYRK16nOIPWDPIptUs/e6lOwnnvnl8N1e3kuDtF72fN2mfy?=
 =?us-ascii?Q?PBVP0J7/eM+/eAC71LAJSRB9U6VRL/g/dR5nwUNOCBgQ0fS8AiQidjrIww6+?=
 =?us-ascii?Q?KOzJ/DnlsIeRy5ORiyGiFGmX1SrR1URym5CRSzhYnUWTYBRA/Ew3fx8qzpx7?=
 =?us-ascii?Q?IBgkeQVJUqwO7CqDnZfbmXxb7OT8TNUmEkJLseizrlGymfLD9MRoDlgo07+e?=
 =?us-ascii?Q?z+Z/8jkrJmGFVjVclAt6/KaY+G10oY1S3p+x5OZo2xSKk0Tm7fUZQom4+MEb?=
 =?us-ascii?Q?mzZa6Hl6GQ1jkWb0P3U2Xd0X47VpRZQV7iRGBBZG4AoE6HdjPmgwkaIIopr7?=
 =?us-ascii?Q?5Jz2FTlhTmnb0l0/VafyYiTVKBeFnHKniMYgnpwn0vBKnFf9tdbN0sRx/43S?=
 =?us-ascii?Q?UzBV04/LIPDd9iHve+HRSeHCDLsaRLMFQ1r3tD8B3MVE38SwGp+H40Uvt9lX?=
 =?us-ascii?Q?pL1vz+EjIu0g783ypxllAj7FO2ctp45UzhtXQboBpD3LoRyVSK+J44JGAs/s?=
 =?us-ascii?Q?mTE6BbeIWpT8ITtqhow+DYOnGtgVAkso1n+WIk1FAiV2a9jyAn8hdcqnFLC+?=
 =?us-ascii?Q?SkAgxxjhlBjxq06gDt+sheNnlwgQI2CAl/tpvATwe8ePk4KqBoBxb5KUgvhd?=
 =?us-ascii?Q?oNexJbp3CKpuKwQ5eLNUV59ObeGd+71KhM4PPZDMq/S+3liOMPKDSQqrW0WG?=
 =?us-ascii?Q?nosNZnSzrzN+1V8WI3QdGJ7muSU95CD/qbo1pIJ02POfnN+jeKSajDd9WnV7?=
 =?us-ascii?Q?rSz5U148hGrXXJOwOs0hpX33RLdLIyO1E77iCT/qfP9LImtBjpN6BCLfvYRq?=
 =?us-ascii?Q?X29Exjbg51WdIOohC3+Y4tFWMQ2ngW01w8fqEZpl+cmcSg1REGA+TIxKF9zr?=
 =?us-ascii?Q?g5UIWlzlF4LPKGLJ0WnHNkLJ82r98pQhw97IntPB5DKOpIpoJSNsDjcWdisw?=
 =?us-ascii?Q?96IGDuKh7h6wLFycdderhpg7dPNHAODGkiwDYiHjrB3oHvL3EbSbY4iE9RLr?=
 =?us-ascii?Q?o3Vo6qzVEHAYUFi+XpcyPy9BUJ8XXZbVCm84MpfYT9T8LirU7rYpk/+IzR/n?=
 =?us-ascii?Q?4f30yo78azo6avdH6QaxD4oCbO3NvqPNqt2zER1/oxoYrafWkrkO9sgUfhXg?=
 =?us-ascii?Q?v8V/gWC2eWTNPoTIIJxIBb8qNpLU04WjcQn9iY99QmRKibQ+Hs0aTynYmykQ?=
 =?us-ascii?Q?F/uPN14OjrqFGgECFDzs6u4ooK9dlCnQ2jrBVr+qiKXZCa7Fah9DpiMd9qqV?=
 =?us-ascii?Q?SNWC3FrXCAW6y6DBmvsF7SQcyjvGtPZAPQAgHXVQ1r7ki6WZ0S5rn4+EULrL?=
 =?us-ascii?Q?eo5P4G102hKPz34JFsufHIHbV9iEWlps2O1OXam7p4rwlNbBaI946S1Cuq6O?=
 =?us-ascii?Q?YO428OyWu7wUJXYhv6xDC1y6sVUMZEOnHJHslyY1dbp23/wsGqnxKOZ/lBuj?=
 =?us-ascii?Q?NwUaOOuYvVfV3Rknlxei8ZJDpB5HUL4D28ZkkA8+3np/EBjlU6lDfTzkxFj7?=
 =?us-ascii?Q?qukDxZX9dNXJqBvzS5Dt1rWWD4cXry1d2abPyV0S+5H6leIc9LDyZxaZw+iZ?=
 =?us-ascii?Q?sbASgZ6Pey3xc7ZilAJaudzJz38896QK3tspq0ei?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 392979d9-8e53-4964-ca6f-08dafe135a59
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 14:00:30.1399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u2CkGc8pHRhc2kMBi5Mv5FXoYzHDlBgmRZlSyglIAmikjvG2G7CyJYNRcfDcmnAG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5923
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 24, 2023 at 01:57:08PM +0000, David Howells wrote:
> Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > I moved FOLL_PIN to internal.h because it is not supposed to be used
> > outside mm/*
> > 
> > I would prefer to keep it that way.
> 
> I'll need to do something else, then, such as creating a new pair of 'cleanup'
> flags:
> 
> 	[include/linux/mm_types.h]
> 	#define PAGE_CLEANUP_UNPIN	(1U << 0)
> 	#define PAGE_CLEANUP_PUT	(1U << 0)
> 
> 	[mm/gup.h]
> 	void folio_put_unpin(struct folio *folio, unsigned int cleanup_flags)
> 	{
> 		unsigned int gup_flags = 0;
> 
> 		cleanup_flags &= PAGE_CLEANUP_UNPIN | PAGE_CLEANUP_PUT;
> 		if (!cleanup_flags)
> 			return;
> 		gup_flags |= cleanup_flags & PAGE_CLEANUP_UNPIN ? FOLL_PIN : 0;
> 		gup_flags |= cleanup_flags & PAGE_CLEANUP_PUT ? FOLL_GET : 0;
> 		gup_put_folio(folio, 1, flags);
> 	}
> 	EXPORT_SYMBOL_GPL(folio_put_unpin);


I suggest:

if (cleanup_flags & PAGE_CLEANUP_UNPIN)
   gup_put_folio(folio, 1, true);
else if (cleanup_flags & PAGE_CLEANUP_PUT)
   gup_put_folio(folio, 1, false);

or if you are really counting cycles

if (cleanup_flags & PAGE_CLEANUP_NEEDED)
   gup_put_folio(folio, 1, cleanup_flags & PAGE_CLEANUP_UNPIN)

Jason