Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95880C54E94 for ; Tue, 24 Jan 2023 14:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234086AbjAXOFR (ORCPT ); Tue, 24 Jan 2023 09:05:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234653AbjAXOFM (ORCPT ); Tue, 24 Jan 2023 09:05:12 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CB3844742D; Tue, 24 Jan 2023 06:04:44 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B86024B3; Tue, 24 Jan 2023 06:05:06 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3F2E3F71E; Tue, 24 Jan 2023 06:04:22 -0800 (PST) Date: Tue, 24 Jan 2023 14:04:20 +0000 From: Sudeep Holla To: Geert Uytterhoeven Cc: Pierre Gondois , linux-kernel@vger.kernel.org, Palmer Dabbelt , Sudeep Holla , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Conor Dooley , Gavin Shan , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v4 6/6] arch_topology: Build cacheinfo from primary CPU Message-ID: <20230124140420.4srnufcvamvff77v@bogus> References: <20230104183033.755668-1-pierre.gondois@arm.com> <20230104183033.755668-7-pierre.gondois@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 02:50:16PM +0100, Geert Uytterhoeven wrote: > Hi Pierre, > [...] > > @@ -840,6 +840,14 @@ void __init init_cpu_topology(void) > > reset_cpu_topology(); > > return; > > } > > + > > + for_each_possible_cpu(cpu) { > > + ret = fetch_cache_info(cpu); > > + if (ret) { > > + pr_err("Early cacheinfo failed, ret = %d\n", ret); > > This triggers on all my RV64 platforms (K210, Icicle, Starlight, > RZ/Five). > > This seems to be a respin of > https://lore.kernel.org/all/CAMuHMdUBZ791fxCPkKQ6HCwLE4GJB2S35QC=SQ+X8w5Q4C_70g@mail.gmail.com > which had the same issue. > I need to recollect my memories reading all the thread, but even after the fixes there were few platforms that failed with so early allocation but were fine with initcalls. Are these such platforms or am I mixing up things here ? Do you still see all the cacheinfo in the sysfs with initcalls that happen later in the boot ? Conor might help me remember the details. -- Regards, Sudeep