Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB0DC38142 for ; Tue, 24 Jan 2023 14:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234664AbjAXONb (ORCPT ); Tue, 24 Jan 2023 09:13:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234650AbjAXONa (ORCPT ); Tue, 24 Jan 2023 09:13:30 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701B7A1 for ; Tue, 24 Jan 2023 06:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674569563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tEbGJD01xquKSOhV4sZeZBlmHdvqW5cMf/3Qh6FPOaw=; b=UH0PdqtkKle91BY5x1NAGXYJ4X86NmfPb9zsR2TmPx7qZ0Edl7WwM/KBbXsN4yUUyUjtHR QtD0/1pjpCLRMC1LdiHeL46U0KIVvP60o2hkFjRCAibRqYAVJTruWqLmtjXMTkIfib7ece RSP8NRMs9odYRpZSNIQQB9NdyqjvYbQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-416-oE0psj74MqOnmDjf1BJwdw-1; Tue, 24 Jan 2023 09:12:28 -0500 X-MC-Unique: oE0psj74MqOnmDjf1BJwdw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C2B4A3C0D862; Tue, 24 Jan 2023 14:12:27 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F30D2166B26; Tue, 24 Jan 2023 14:12:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> <852117.1674567983@warthog.procyon.org.uk> <852914.1674568628@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Jason Gunthorpe , John Hubbard , Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <859185.1674569545.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 14:12:25 +0000 Message-ID: <859186.1674569545@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > On Tue, Jan 24, 2023 at 01:57:08PM +0000, David Howells wrote: > > [include/linux/mm_types.h] > > #define PAGE_CLEANUP_UNPIN (1U << 0) > > #define PAGE_CLEANUP_PUT (1U << 0) > > With the latest series we don't need PAGE_CLEANUP_PUT at all. We will when it comes to skbuffs. David