Date:   Tue, 24 Jan 2023 10:14:44 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Howells <dhowells@redhat.com>
Cc:     John Hubbard <jhubbard@nvidia.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        linux-mm@kvack.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Message-ID: <Y8/n1AdBwbYqp8lX@nvidia.com>
References: <Y8/kfPEp1GkZKklc@nvidia.com>
 <Y8/hhvfDtVcsgQd6@nvidia.com>
 <Y8/ZekMEAfi8VeFl@nvidia.com>
 <20230123173007.325544-1-dhowells@redhat.com>
 <20230123173007.325544-11-dhowells@redhat.com>
 <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com>
 <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com>
 <852117.1674567983@warthog.procyon.org.uk>
 <852914.1674568628@warthog.procyon.org.uk>
 <859142.1674569510@warthog.procyon.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <859142.1674569510@warthog.procyon.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o0Ahp4q6eOWS7tyT2vfOMsPE8mQfFWBSvnwew24eglQcKe+5zXJ6jMKWStAT?=
 =?us-ascii?Q?XBYNhkmYmHffwP4EZgYYF9a14G2Jlby8/DahOFKgSezy9IiO2x9dY2VAiwVq?=
 =?us-ascii?Q?9JxSdju/AleZHch5XkkYx7uglmXSuAUATXH5NECs/SrH5Y0kVYXULG6HrcMy?=
 =?us-ascii?Q?/xZn/BlKa4PxLU3TujwUgsvIUozSlitFRVjAu8VOe0IJ1yOd5WGQc375pMww?=
 =?us-ascii?Q?YG8YSZRuL8dgnULyp9+nLejN1TtbSqql16FayTh3dE/+kGaSki086/7q56Jr?=
 =?us-ascii?Q?FjW1GPcS8WBfyGJdEmAVC1M2XViywyh2m3GYLhC/Fak5nrjeN9MSq9AR2hde?=
 =?us-ascii?Q?2OWzaEEs0MMiGAjGxO2Kb89w6m72QJtBPS91SEx5aMueSa79GYzucZ5Q1srM?=
 =?us-ascii?Q?EgGK+C/gFaDbQ0JcwE5UNexI4XprIbJsovRZtgM7ns6m9tGsnzpxlaCr5cF9?=
 =?us-ascii?Q?3a5eFMUv21O7OXbXG2RkvrSwH2ws3ilACNLwik23lIpf2XKSYbZ8p71a0jAk?=
 =?us-ascii?Q?faSdgrdvJnKuCIgAF0nesi5+VX+Q8T4SfnaVaAupn2kkrsuCYaen862xTRfb?=
 =?us-ascii?Q?56gfHSqoakEX8g0rkdJABC1y9sYSBQJOLlAquyIMTHNP9lr/Y+EcR8gcfrUF?=
 =?us-ascii?Q?Vz+Q27uTA6+9D0I/OFpZfas22fWLATfvMGoHTe2XyM2QC2VTn3ekHorzRkQS?=
 =?us-ascii?Q?cRRtqrze8OpdiRu3eOA2ojrkvN2RXAx8N62JiHQto3d3UuqLEExKW1F92lgY?=
 =?us-ascii?Q?mAQ453LWerEviCtBAWEj/WC1v4hc7388uB02K4M6IQT5OFDs9MCLkIfuGpkA?=
 =?us-ascii?Q?FJDUTm8/sw3lQBHS1ERjbI/yJzD6jm3vHBrkY0XPLqpSQqQKE4yxxWiSxsfq?=
 =?us-ascii?Q?nSPvAm9CFv66tW87JkMRqamwjnTnrg6dMK8tznYOQqiN0JYGWCF1kl6p2B5x?=
 =?us-ascii?Q?wo8Fc6YB9wTRGAWOPLyUNNmqZ6J2wEkpqGAvxdGr1vIBJvB+qMIfOO3EVSRv?=
 =?us-ascii?Q?nX4FbBCdYdQ18Nh0OI6+3Nn0bqMtoAmzsyswmUGOJvpwG0soElMdQg/Hwi/y?=
 =?us-ascii?Q?EliGJPXxCLrH6/rahBW8k68qBueQNNeiJUjLJqUSGrogJjSJHzYyyyrBydZs?=
 =?us-ascii?Q?O7+oAfNJjpl7/n29oLXYDA8g4LkCAJs4tzAomwu3s+oAB5b2qkl62fEJqsJ5?=
 =?us-ascii?Q?GkleHZfyJ9qd2OqoHzYndgwXWJzvcbzJwLjNUn/4h9dPR0YrAnPaLQ8pTg4B?=
 =?us-ascii?Q?DiF0IMn5U7wM8SFswncCmZ2POafbZYfd5TREyoIbyUX0dD0dTXhQx3RLjE3E?=
 =?us-ascii?Q?+W98wrOklLBBLxT9jiE4npHq32UNKj6T2254m10aL82If6yzLYPdghv1E9Np?=
 =?us-ascii?Q?4vJml8Ce0vFtJwTdWl/QV8DYDgSCZqYIkLDJ9gumrbTJlWqxqbNLrnfPBInL?=
 =?us-ascii?Q?yZovgnZNLBWDhsPnJ1HHKJmaI1GN7q49XJJJE8WkXVGi85TmRn92hVE2RxJf?=
 =?us-ascii?Q?Xf7/RePhVlD7kWT/xNEWyf8tOiryWEEai3Y8fHdutx+UnKsX87LtVADQLbTm?=
 =?us-ascii?Q?/+hZxxnqSGUihKBWVEDEmNPEGXPalyUmCNmY/MgC?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a91cc852-0d76-45da-e572-08dafe155823
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 14:14:45.3955
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ULytzAauRcnYl1Z0ARN44pAjTTiXMceFCYX0rOJVmDXFb8BNvva/ABmdprI/SVEx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8328
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 24, 2023 at 02:11:50PM +0000, David Howells wrote:
> Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > if (cleanup_flags & PAGE_CLEANUP_UNPIN)
> >    gup_put_folio(folio, 1, true);
> > else if (cleanup_flags & PAGE_CLEANUP_PUT)
> >    gup_put_folio(folio, 1, false);
> 
> gup_put_folio() doesn't take a bool - it takes FOLL_PIN and FOLL_GET:

My point was to change that to take a 'bool unpin' because FOLL_PIN is
not to be used outside gup.c

Jason