Date:   Tue, 24 Jan 2023 22:24:49 +0800
Message-ID: <87pmb4qaby.wl-me@linux.beauty>
From:   Li Chen <me@linux.beauty>
To:     <Conor.Dooley@microchip.com>
Cc:     <lchen@ambarella.com>, <arnd@arndb.de>, <heiko@sntech.de>,
        <lkundrak@v3.sk>, <robert.jarzmik@free.fr>, <sven@svenpeter.dev>,
        <zhuyinbo@loongson.cn>, <briannorris@chromium.org>,
        <hasegawa-hitomi@fujitsu.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 06/15] soc: add Ambarella driver
In-Reply-To: <578e034a-d75f-3b50-76dd-8eb90a127258@microchip.com>
References: <20230123073305.149940-1-lchen@ambarella.com>
        <20230123073305.149940-7-lchen@ambarella.com>
        <bc50c6c2-bdfb-0b6c-0f89-dc8cfe845202@microchip.com>
        <87zga8gww0.wl-me@linux.beauty>
        <578e034a-d75f-3b50-76dd-8eb90a127258@microchip.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


Hi Conor.Dooley,

On Tue, 24 Jan 2023 16:46:41 +0800,
<Conor.Dooley@microchip.com> wrote:
> 
> Hey,
> 
> >>> +++ b/drivers/soc/ambarella/Makefile
> >>> @@ -0,0 +1,3 @@
> >>> +# SPDX-License-Identifier: GPL-2.0-only
> >>> +
> >>> +obj-$(CONFIG_ARCH_AMBARELLA) += soc.o
> >>
> >> The subdirectory is already gated by this symbol, so is there much point
> >> gating it on the same one again?
> > 
> > Yeah, it lookgs kind of redundant now, but I will upstream other drivers after
> > this series get merged, which are not gated by this symbol.
> 
> You could make the directory by obj-y, and therefore always included,
> and have various drivers controlled by their own Kconfig symbols.
> 
> Or else, you could leave the directory controlled by ARCH_AMBARELLA
> and make the above `obj-y += soc.o` instead, since it's always
> going to be built if the directory is included.

Gotcha, I will fix it in v2. Thanks for your kindness!

Regards,
Li