Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9601BC25B4E for ; Tue, 24 Jan 2023 15:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234445AbjAXPFm (ORCPT ); Tue, 24 Jan 2023 10:05:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231827AbjAXPFj (ORCPT ); Tue, 24 Jan 2023 10:05:39 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBAC96591 for ; Tue, 24 Jan 2023 07:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674572695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=We0ztlK7xsSDEvj4rISvvwvtVDDgrOaYH+Q+mtN9UQo=; b=gQYUZ/T4cgJp2tlGwJy1HeDeG00KaqrL3k5l1urJlgEZwEBWeFNEqUFm2GS/kfLohD+Lql S/7UqO+C/WH83z7F6KXFhbRk7SYa6SgEBJ6RdI+ChAwve3gwEHJuESUBmZFaPYcOs1G9V1 yEBfr2buWe4DF9vj06XDNaVm/nC/QKw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-468-lMZftAtvNu2RT9J0ESa0JQ-1; Tue, 24 Jan 2023 10:04:52 -0500 X-MC-Unique: lMZftAtvNu2RT9J0ESa0JQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 29FD53C0F66B; Tue, 24 Jan 2023 15:04:41 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 975C72166B26; Tue, 24 Jan 2023 15:04:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-4-dhowells@redhat.com> <874546.1674571293@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, David Hildenbrand , Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 03/10] mm: Provide a helper to drop a pin/ref on a page MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <875481.1674572679.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 15:04:39 +0000 Message-ID: <875482.1674572679@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > The only place where we have both is in the block layer. It never gets > set by bio_set_cleanup_mode. It gets set directly by patch 6. David