Date:   Tue, 24 Jan 2023 11:06:49 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Howells <dhowells@redhat.com>
Cc:     John Hubbard <jhubbard@nvidia.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        linux-mm@kvack.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Message-ID: <Y8/0CaBzL0VPyE2D@nvidia.com>
References: <Y8/ZekMEAfi8VeFl@nvidia.com>
 <20230123173007.325544-1-dhowells@redhat.com>
 <20230123173007.325544-11-dhowells@redhat.com>
 <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com>
 <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com>
 <852117.1674567983@warthog.procyon.org.uk>
 <852914.1674568628@warthog.procyon.org.uk>
 <859142.1674569510@warthog.procyon.org.uk>
 <864109.1674570473@warthog.procyon.org.uk>
 <875206.1674572365@warthog.procyon.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <875206.1674572365@warthog.procyon.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VC9ImlOQ4yEUZ7/ps7cAbMw6yJzp1lxKeM88Rw8LYYpGE5WXYukIsDEc5aCT?=
 =?us-ascii?Q?iPJsrE3yy2a/r3L88cqyS0VfCNSQJ0M9jbsioUSPfY8717z7AO0xJ4BtawqB?=
 =?us-ascii?Q?Dx/m7ckd+9L9DIjGDMfWOWII9/OYuYdF0qRv9jFrdAE2vR8w0IRVzB1Mvhyy?=
 =?us-ascii?Q?iL36CodOJJn3VeprwxN+t3rrfLS1FZ+MblFNFVJxcx+A++mLXWgNYD4bw+M9?=
 =?us-ascii?Q?1DUn6uZrbLn3e3SG2BZVMIAp1W1Nf4EYwFCs3zNs3gAprFGsBRLFhcZSh/0Q?=
 =?us-ascii?Q?QxudCjVUlcwZv5TOoA5RsFfAnrJ+WZ1pIiaRkBGd5mqqhCJUVk8zwW+BrGLX?=
 =?us-ascii?Q?iPZ0XQYL4FCc7EJX8UMsEeSKHrpeg2RzdwumX028DJ1GhIb1zqIOuXaUGwSx?=
 =?us-ascii?Q?i7Uak7tiEaXdSCAfyZZRl1BanMEa+ljRHlswZkf4Mrr2gMvVjtUKicjNzx5F?=
 =?us-ascii?Q?2TFiVM87rmV3kuIhZEkumn05/oo1WAc+MoXXyUikCXKkP4lDd/Z9bTZs5bfu?=
 =?us-ascii?Q?ThYJOfc9As6nNZ21ujm14m6s60SAox3FOTvx+rAZu60v7ZqPb0FqnH+0ouJi?=
 =?us-ascii?Q?W55THvzajxNgAvA7qf80hRRgEuOlL1I4YN/KGkd2r+6A7IosB2fBowrAYeqj?=
 =?us-ascii?Q?sSDlh77bJgGBtktb/dwqBtJXY8bRQ2hOU9ZAJxl89G/11A0Hus0k2aZzqjDx?=
 =?us-ascii?Q?KGn6Ohs8GkxnbJieyhvmQoXGnu3ri+zYrRrW0Vqd7HVGpfsnPHk2YjqUAdwB?=
 =?us-ascii?Q?q21O7zLCu3EGtIPR3DkUqNgIoEmuMRrRd2d1rcLgo/3bEnE8MeSK9nAEwarx?=
 =?us-ascii?Q?pnHPyW3ogkXZouwzqrOZFPk6mydA4tWXtrN6DHGuA/8RXS+reOcCAgySMlgo?=
 =?us-ascii?Q?YXMWYioZHcPpYsSNNieDijqmvwjPCePRHpkB9eVK+ehO45gSPx9kLI3CBkrD?=
 =?us-ascii?Q?cyCUxGVjhMlgxPbSHxAO5dJBRcZkMAdY9fuoH6giMd7OAbKS4XrgJM/fFJ5F?=
 =?us-ascii?Q?oj+dWkX0uHE5zXT3+5QtnGLDzyJZOtFFEocUSP9DjXLCj1UVU24RqcyUnLVu?=
 =?us-ascii?Q?Bau9f8filcuNtpIfvufc1LKKGsIAHhAhDOdGRULd/UY4ltg0DAbFDaDWJhCv?=
 =?us-ascii?Q?ITzyJfS2bxPsjmVcQSEi97c9NMz3q6+MaYbqUcTqQliGmz2RgKiDxlWw2Uxo?=
 =?us-ascii?Q?WMS3oYLiMvfTbhsAkrTtS4zM7VvHhFujNHX6nKSW+CvSvWWGo8082Heph0tS?=
 =?us-ascii?Q?XBMzJHP858TDqA5I3FApT5e2jBzPK85+MegjgygOXgRICpANBz/XWcH1yXV+?=
 =?us-ascii?Q?7HqJGa9LZ9eqpIu+FzvMTEqYSo19poLu4P9wqwFUddr2iye4jN9gvltLGd36?=
 =?us-ascii?Q?G59CaUusWJdZU9hn8wVOPHTi+4njbYimMk3YznwH3it0rmGKj6/cap1oHIpW?=
 =?us-ascii?Q?qmZSFeGHXBJjKdOQl7xYxX/+TKtT0YXZQ2dwTfZ9bPuSabClEbU2qyTL8jXu?=
 =?us-ascii?Q?S6pKXS1BumwTKJbUJp1PRUCN+CKjyHYIYdKtSpDT6f3krl1cD3TkJH5vim6l?=
 =?us-ascii?Q?/MWpfdcoF8PhtpOM5TWdw0+hffWV6cxJSUB1g5Y2?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb7f38c8-a126-4089-5e58-08dafe1c9ea2
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 15:06:50.2073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A+q/TnHc21MgIu0dQopiLDOYDlYMT9RENpCGqsCO8PK5M1dEZREpTLeiAk6jtJdi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5768
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 24, 2023 at 02:59:25PM +0000, David Howells wrote:
> Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > What is the 3rd state?
> 
> Consider a network filesystem message generated for a direct I/O that the
> network filesystem does zerocopy on.  You may have an sk_buff that has
> fragments from one or more of three different sources:
> 
>  (1) Fragments consisting of specifically allocated pages, such as the
>      IP/UDP/TCP headers that have refs taken on them.
> 
>  (2) Fragments consisting of zerocopy kernel buffers that has neither refs nor
>      pins belonging to the sk_buff.
> 
>      iov_iter_extract_pages() will not take pins when extracting from, say, an
>      XARRAY-type or KVEC-type iterator.  iov_iter_extract_mode() will return
>      0.
> 
>  (3) Fragments consisting of zerocopy user buffers that have pins taken on
>      them belonging to the sk_buff.
> 
>      iov_iter_extract_pages() will take pins when extracting from, say, a
>      UBUF-type or IOVEC-type iterator.  iov_iter_extract_mode() will return
>      FOLL_PIN (at the moment).
> 
> So you have three states: Ref'd, pinned and no-retention.

Isn't that this:

if (cleanup_flags & PAGE_CLEANUP_NEEDED)
   gup_put_folio(folio, 1, cleanup_flags & PAGE_CLEANUP_UNPIN)


?

Three states - decr get, decr pinned, do nothing?

Jason