Date:   Tue, 24 Jan 2023 16:23:46 +0100
From:   Gerald Schaefer <gerald.schaefer@linux.ibm.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        mike.kravetz@oracle.com, willy@infradead.org, jhubbard@nvidia.com,
        linux-s390@vger.kernel.org
Subject: Re: [PATCH 8/9] mm/hugetlb: convert hugetlb_wp() to take in a folio
Message-ID: <20230124162346.404985e8@thinkpad>
In-Reply-To: <20230119211446.54165-9-sidhartha.kumar@oracle.com>
References: <20230119211446.54165-1-sidhartha.kumar@oracle.com>
        <20230119211446.54165-9-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 19 Jan 2023 13:14:45 -0800
Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:

[...]
>  	page =3D pte_page(entry);
> -	if (page !=3D pagecache_page)
> +	if (page_folio(page) !=3D pagecache_folio)
>  		if (!trylock_page(page)) {
>  			need_wait_lock =3D 1;
>  			goto out_ptl;
>  		}
> =20
> -	get_page(page);
> +	folio_get(pagecache_folio);
> =20

We get a kernel crash on s390 in mprotect testcase from libhugetlbfs
testsuite, starting with next-20230120, bisected to this commit.

We get here with pagecache_folio =3D=3D NULL, and crash in folio_get().
It doesn=C2=B4t seem right to replace the get_page() with folio_get()
here, the matching put_page() at out_put_page: also wasn't changed
correspondingly. Also, pagecache_folio =3D=3D NULL seems to be a valid
case here, on all architectures.

Reverting this folio_get() to get_page() fixes the crash. Not sure
though if I missed something. I think you only want to replace
pagecache_page with pagecache_folio, like in the rest of the commit,
and not page -> pagecache_folio for this get_page().