Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C7AAC25B4E for ; Tue, 24 Jan 2023 15:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbjAXPlP (ORCPT ); Tue, 24 Jan 2023 10:41:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235285AbjAXPlK (ORCPT ); Tue, 24 Jan 2023 10:41:10 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79FF74B88C for ; Tue, 24 Jan 2023 07:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wQj7qrmg8E8ggKL5hoaCBFJQA0qF06XIOhJLfPvujKg=; b=Dd21g0fy1sfNqWvlQlDclyouJP jviTRj8ksYlJj3CFfWGweGiXiyEGAGIF32xspUgHnznn5JcjappD+xLpscm/A+o2kvOX83q4JeGuf lI4lhcTpBTp99NzkGtXZhktI+2q/e3LE8NyVUvo4fwhFjImq70TEjiJvLTCadJ8ArUTu6XBqldq9n nPyVZBJ3hbOXaZDqpBUcpYwLnqQVo9z5V3PiYly57BzN+m80vezqKXONOyosqUWX7E59KSPPGwtcB W4Fkbp4yiegu93o5XQxzAcuyv+2/gT2ljawg0Q6j95LBduSFYNhaGdKAdvxbupUuJndpuDebWxPd7 IUoF8AcA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKLPs-005A1B-Q2; Tue, 24 Jan 2023 15:40:57 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6DA06300657; Tue, 24 Jan 2023 16:40:56 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 20957299F2F7E; Tue, 24 Jan 2023 16:40:56 +0100 (CET) Date: Tue, 24 Jan 2023 16:40:56 +0100 From: Peter Zijlstra To: Jens Axboe Cc: Thomas Gleixner , the arch/x86 maintainers , LKML Subject: Re: [PATCH] x86/fpu: don't set TIF_NEED_FPU_LOAD for PF_IO_WORKER threads Message-ID: References: <560c844c-f128-555b-40c6-31baff27537f@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560c844c-f128-555b-40c6-31baff27537f@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 08:23:20AM -0700, Jens Axboe wrote: > We don't set it on PF_KTHREAD threads as they never return to userspace, > and PF_IO_WORKER threads are identical in that regard. As they keep > running in the kernel until they die, skip setting the FPU flag on them. No objection to the actual patch; but this changelog fails to tell us why this is important. What made you get up and write this patch :-) Presumably this is a performance issue? If so, can you quantify how much?