Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46A1C54E94 for ; Tue, 24 Jan 2023 15:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235116AbjAXPvN (ORCPT ); Tue, 24 Jan 2023 10:51:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234359AbjAXPvL (ORCPT ); Tue, 24 Jan 2023 10:51:11 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 146E322789; Tue, 24 Jan 2023 07:51:10 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BC54B1FEB8; Tue, 24 Jan 2023 15:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674575468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GaudxGhfRvuAuD1dm3IS6CoJ4eArs7knjMHOpN03ack=; b=Pifqu3lAE0s2pMkLpizgAqCGTPRS9DA3X/CNqDF+xC12XRGHOE2ajexXllzccw9adGWFOx fI+q0m2p19kvHrRBiqovmvAZYeu9lxEl3wmirAGZ4Ra2iUfCD6OPHjerywLfqcRqgDN9S9 Xw8PRdAsz6KSvuA3po2HBKBocN13Rzg= Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 9C96D2C141; Tue, 24 Jan 2023 15:51:08 +0000 (UTC) Date: Tue, 24 Jan 2023 16:51:08 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Marcos Paulo de Souza , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, jpoimboe@redhat.com, joe.lawrence@redhat.com Subject: Re: [PATCH v2 0/4] livepatch: Add garbage collection for shadow variables Message-ID: References: <20221026194122.11761-1-mpdesouza@suse.com> <20230123173331.2rvelrrbkaitw56r@daedalus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123173331.2rvelrrbkaitw56r@daedalus> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2023-01-23 14:33:31, Marcos Paulo de Souza wrote: > On Tue, Nov 01, 2022 at 11:43:50AM +0100, Petr Mladek wrote: > > On Wed 2022-10-26 16:41:18, Marcos Paulo de Souza wrote: > > > Hello, > > > > > > This is the v2 of the livepatch shadow GC patches. The changes are minor since > > > nobody asked for for big code changes. > > > > > > Changes from v1: > > > * Reworked commit messages (Petr) > > > * Added my SoB which was missing in some patches, or the ordering was wrong. (Josh) > > > * Change __klp_shadow_get_or_use to __klp_shadow_get_or_add_locked and add a comment (Petr) > > > * Add lockdep_assert_held on __klp_shadow_get_or_add_locked (Petr) > > > about it's meaning (Petr) > > > * CCing LKML (Josh) > > > > > > Some observations: > > > * Petr has reviewed some of the patches that we created. I kept the Reviewed-by > > > tags since he wrote the patches some time ago and now he reviewed them again > > > on the ML. > > > * There were questions about possible problems about using klp_shadow_types > > > instead of using ids, but Petr already explained that internally it still uses > > > the id to find the correct livepatch. > > > * Regarding the possibility of multiple patches use the same ID, the problem > > > already existed before. Petr suggested using a "stringified" version using > > > name and id, but nobody has commented yet. I can implement such feature in a > > > v3 if necessary. > > > > > > Marcos Paulo de Souza (2): > > > livepatch/shadow: Introduce klp_shadow_type structure > > > livepatch/shadow: Add garbage collection of shadow variables > > > > > > Petr Mladek (2): > > > livepatch/shadow: Separate code to get or use pre-allocated shadow > > > variable > > > livepatch/shadow: Separate code removing all shadow variables for a > > > given id > > > > From my POV, the patchset is ready for pushing upstream. > > Petr, what do you think about merging the first two patches, since they just > cleanups and simplifications? Sounds reasonable to me. I am going to push them by the end of the week if nobody complained in the meantime. Best Regards, Petr