Date:   Tue, 24 Jan 2023 08:56:30 -0700
From:   Keith Busch <kbusch@kernel.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Ville =?iso-8859-1?Q?Syrj=E4l=E4?= 
        <ville.syrjala@linux.intel.com>, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Gerd Bayer <gbayer@linux.ibm.com>,
        Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] nvme-pci: Switch back to sync probe to fix rootfs mount
 regression
Message-ID: <Y8//roUT5byp59UP@kbusch-mbp.dhcp.thefacebook.com>
References: <20230124004542.29659-1-ville.syrjala@linux.intel.com>
 <20230124062140.GA29175@lst.de>
 <Y8+bP2Oqy3B2XyuJ@intel.com>
 <20230124134134.GC25796@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230124134134.GC25796@lst.de>
Precedence: bulk

On Tue, Jan 24, 2023 at 02:41:34PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 24, 2023 at 10:47:59AM +0200, Ville Syrj?l? wrote:
> > On Tue, Jan 24, 2023 at 07:21:40AM +0100, Christoph Hellwig wrote:
> > > Err, no.  We're not going to randomly revert things.  If you want
> > > to be productive check the one liner Keith reported in reply to the
> > > last report.
> > 
> > No idea what that previous report is. Care to share a link?
> 
> https://lore.kernel.org/linux-nvme/849c43bc-7488-72a6-f6fc-8700639b0c79@leemhuis.info/T/#m759092f541ea29fcb41911890307e70868636a45
> 
> Patch to test:
> 
> https://lore.kernel.org/linux-nvme/849c43bc-7488-72a6-f6fc-8700639b0c79@leemhuis.info/T/#md13c22b29cd81bd0ce9167c271c582005ba30550

I'll post the official patch if someone can let me know if it's
successful. Or I can potentially setup a VM to verify myself, but I
probably won't be able to get to that till next week.