Message-ID: <4ac38b77-77aa-f2c0-36e4-5e482013091d@amd.com>
Date:   Tue, 24 Jan 2023 10:06:00 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event
 Configuration feature flag
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     "Luck, Tony" <tony.luck@intel.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Bae, Chang Seok" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "Eranian, Stephane" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <20230109164405.569714-5-babu.moger@amd.com>
 <Y7xjxUj+KnOEJssZ@zn.tnic> <5afd0a7c-3fbe-dfea-f1b4-2fc35fbb4f13@amd.com>
 <Y7yCCNANVBnOOmxM@zn.tnic>
 <SJ1PR11MB608321F26D729A082BFC6FAEFCFE9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <ecf0abf0-59fe-3898-762c-d9d883925550@amd.com> <Y7yMbQ8hI9MGl1w3@zn.tnic>
 <MW3PR12MB455384130AF0BDE3AF88BCF095FE9@MW3PR12MB4553.namprd12.prod.outlook.com>
 <Y8/CSrU8Bo298VzO@zn.tnic> <72cdefc5-1601-5c43-9ea4-4b637f5fafa5@amd.com>
 <Y8/07cV+t0PrqWX9@zn.tnic>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <Y8/07cV+t0PrqWX9@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUJLbkZtNkVuZHVLY3BJbWtsbXRhaEVYbUhSWmk5MXBBUDNvWFJnaXgxMlRE?=
 =?utf-8?B?TGdaYWlGQ1lydmdjQ0dHTFhTOUFlK3BkWXNURnBDL2V6M3p4OVVlNGF5SDg0?=
 =?utf-8?B?cDhuY3NTNE8wdm5Nd2VPbTFZcTJ2R2I5ajMxcURJbnRvNkQxeDAyTmhmVXM2?=
 =?utf-8?B?UnNmUVFHbWd1Z1U0UGRjVklTVmNrQy9MbVlmODFLZ2V5NU90RldIb1dMT1Y5?=
 =?utf-8?B?TFhuOURyOGNzUDQzeXlhL3ZRQXlOc3RkSWNQczU4Ykw0bW9yUlpHUkl2OXZD?=
 =?utf-8?B?RlhOeENhWkhNeWxzWVhiZERRQjdlRVVwWHFMS1FCTHowcVA4dU05Sm9RdlZR?=
 =?utf-8?B?WG1lelp6OUJsbVQ3ZzdKWjRJMFF6b2F2VmttMXpaQVBGdkVCYkt4d28vVjM5?=
 =?utf-8?B?SlA5UEdEVXJoWVo3MDI5NFU2dXZvNkc3NUdLUHduQWFXeFhyLzJrTHdRdndz?=
 =?utf-8?B?NHZKTENmK2M3VEdiVkJsT1ZmdlIydU1EZ2tHUUwzMlpXKzg2QWZxd2R3VkI4?=
 =?utf-8?B?dUQ1a1I0eFR4a2NwNTFRWVF1dHRMejA1Ui82L3BLcnRBcVdWYWM2Y3FGbm81?=
 =?utf-8?B?TS9hN2wya2lCVkZ2SDBmNzdXZHhEcGRpcElXamxpNWFKZDFKcTBhUGg4cFpZ?=
 =?utf-8?B?aXdNem5pbDVHa2JOV3g2K05LKzB5dUZ5SlRWc0c5cG1EZ25KcWloaHRUM3No?=
 =?utf-8?B?b2FBNkVuTTFaWEJaQTVYR3JuQVpFVDA2UFdyZTBFRXhBZVdLNEZNbUxHT0da?=
 =?utf-8?B?ZXR3eGpobWExZGFTVEhXYTZBbWhNc3lUcTAxanFQVStmMGhrNWQwUjdXWXUv?=
 =?utf-8?B?Tnp4dDFtajBkSlBLeFhURWxTUzRIV3crSUt2RzVqTS94eE1Od3QrUGZqMjU0?=
 =?utf-8?B?K1RFY1pCMU1NYkVHcGliYVNMVFhlckgyRFVGQ2ZibWFUTmErZmxSM1dNR2gy?=
 =?utf-8?B?MnJoNy9ZNDdOd3FqdlNIaGphM09vY1NsZyt1V3ljTFAwVkdZOHJvbFFlR3Rn?=
 =?utf-8?B?bDM2UVh5WWkyRkZ1ZWR4S1UxNmpqcjhmTFpDc2E2YjFWbDlxb3NvK0tUbkVT?=
 =?utf-8?B?Y01HdkpmR0p0QXc3UWRucUovY2RId1V4dlBpNzdOQW8zQ3dKMlI5cEgvZkY0?=
 =?utf-8?B?Z0s1REJweUpFeC84WXlxWTJsaDlNWkVmWEd4RWI0TXpPYXdWVVRzRUpwRkJU?=
 =?utf-8?B?eDFPMHI0am9YbHpXSEUvY3FZS0EraW9UV1Rsc1RwSjRiSGwvNU9zOG9DSEYr?=
 =?utf-8?B?U3A1ZHJDL243amJrbTVKRk00RFFmWmo2UDNHTm1UNWxGMEVjZ2pZVDBpb2Vz?=
 =?utf-8?B?TzBIU2xLR1IveXhEOWEzVDlnV2p1QVlZZnZidEFSakdwOE9hUVk0Z0ZQam5q?=
 =?utf-8?B?clM2dE00ekhGRnFXb1VNOGJxdVh4ZmpxOTZwK05aYU96eElQeExTRHlGTkJj?=
 =?utf-8?B?S3BMRGswN2JXZnJ6aEZTNUtqK2toV0JFa0gwOXQzcTFCdjhmdEVzMGRlTkN0?=
 =?utf-8?B?dGM2OUVlRERxNzRBMW5iR2RZSVJNUlVrTDF4VS9pa3ZpNUdieG5POEtKK0pQ?=
 =?utf-8?B?dGtIcmptV0dYRTYvMUNueVU1d0twTVVLUGN6N0MvR3k0Q3g2ejJpaGZWQS9k?=
 =?utf-8?B?ZlFFcHVxYTRjdlNjWmx2cU9oSVhrdis4eDJYdG10NHJIcWVGUEViYTFIckZY?=
 =?utf-8?B?NUhXZGFKbC9IOUE1RFRBVEk3cmFycVhvUVJtUEhVQUxxb2V0cGpuRytkR1Ey?=
 =?utf-8?B?cXFHUDlEMG5GU1NrT1Q1eHJYekYvN2oxaWxTeHlGTUNBMm03cW84TnloZE9V?=
 =?utf-8?B?WFhXNmU3bTFkOTRKU1VHQVUvdVlINjBnRy9QakhTdjE4RVhGcWtQY3MwNmwv?=
 =?utf-8?B?RzRibGRwd1BQekRrQVpYd2M5MHIrcjYyYVNtRXg2NGdycFRQc1pNTXhaUEYz?=
 =?utf-8?B?MVNqbGRrN1JNdVBIenRqbW1EdmJ3QllvWWZpdjQyYWZ0VSs2c0kvQ1lxblcv?=
 =?utf-8?B?RmYzb05HWXFybFRlOTBRWXJ2VVRjSWVWMTdOU3psQlAxb2gzbUZNdHhVb0hs?=
 =?utf-8?B?U0lSWXROckJlMXI5elAxYUhXakxSVEs3MmpYSUdoUnlsWlM3TVZxbmwzSTA3?=
 =?utf-8?Q?WENjBxFXEnFRJJOLthCPuMGzy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 128a1e2f-db40-4474-88a5-08dafe24e5d6
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 16:06:05.7478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sWTer2SA/tXm/FYZDJ4KItNFfBHPeTKl8qFdZpRPsxvLYR7l7dOqY4KBQrRyjB0q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7462
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/24/23 09:10, Borislav Petkov wrote:
> On Tue, Jan 24, 2023 at 08:11:21AM -0600, Moger, Babu wrote:
>> Understood. I am planning to add resctrl feature list inside
>> /sys/fs/resctrl/info/ in my next series.
> Maybe I wasn't as clear as I hoped for:
>
> so you have a couple of flags in /proc/cpuinfo which are actively being used by
> tools.
Those flags will be there. Not planning to remove them.
>
> Why would you want to move the flags somewhere else and do the extra work for no
> apparent reason?

With this series(v12) we have added two new cpuid features(SMBA and BMEC).

But these features are not visible in /proc/cpuinfo. Planning to add them
in /sys/fs/resctrl/info.

So, users can see them here. 

>
>> We need to add all the resctrl feature bits in info directory.
> What for?

Same reason as above.

Thanks

Babu