Message-ID: <8c84eaef-175b-f8ac-d126-e1a80c1ed240@oracle.com>
Date:   Tue, 24 Jan 2023 16:20:16 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v3 04/11] perf pmu-events: Add separate metric from
 pmu_event
To:     Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Florian Fischer <florian.fischer@muhq.space>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Rob Herring <robh@kernel.org>,
        Kang Minchul <tegongkang@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sandipan Das <sandipan.das@amd.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        linuxppc-dev@lists.ozlabs.org, Kajol Jain <kjain@linux.ibm.com>
Cc:     Stephane Eranian <eranian@google.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>
References: <20230124063320.668917-1-irogers@google.com>
 <20230124063320.668917-5-irogers@google.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230124063320.668917-5-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFhoQ2hRaFBqMWxKWmZmWHVybkJmN1BzQVEzMTBoT1ZjOUZRVVdJK2gwNkFR?=
 =?utf-8?B?TWhocVRzR2lKNExrZS9sdjlXUjVXa2FCUXhXU2dhazlrQ3dCeGtjM0ZqbnpY?=
 =?utf-8?B?RlFjT3BRTDZLc0lZa0g5S0NKSENjck4vZ25XcUowdll4VnlSQ2FUQ0tNR2Qr?=
 =?utf-8?B?bDFvbWdCNGFVdFJyQjhhREg1cGU3dTVEL01iV3EyTUl4RjhnbmYwTklzckY4?=
 =?utf-8?B?dU41ZWJ4anQ0MWpIM2pBYlNVMFN2bm5KbW5zbVBWcWlPUStzNUdOWlNNZEFE?=
 =?utf-8?B?YnE0eHF2bHl6dmsvanZ1bjVDQjB5citnSHRnMVZYdEJiUEdFMnhZMVE2bVJ5?=
 =?utf-8?B?NkhNbkRzNGwvUXZYY0phVklvNnN3NFVVMHJlRW1Vbkg0TVFUVllrWmJHTVNh?=
 =?utf-8?B?cVpGNXNMMjRyMjlkbzVPeVh3UktVQjBEZ2tnZHlYQWxtUTM1SmNQZ2dVMzVp?=
 =?utf-8?B?NjJRSHdFeW5Gbk5ndDN3ZzNqczFmZEl0bnVVRDF1Uy9vR1djN084MnBHRGFx?=
 =?utf-8?B?algvRkpFb3hZQThqTzFTMXFkcXBFL3NmUWdTQWNJeER0OElncHFUTHlLVFZM?=
 =?utf-8?B?aEN0NGp3cHV3bmI5ZzhZVXVpSXc5VFB0am9XNTJFOC96QlM1em1pOEtlekpT?=
 =?utf-8?B?UDBWMVJ3cnFBaXBIS05Gais2U2JtellQRlArTUE3SjFrRllCV1VwVEdqbGx1?=
 =?utf-8?B?eTcyYi9kNjlHOXB2aVVoOWdpR3NERU1yMks4VERJbXI5cytPeVJOL0JCeVd4?=
 =?utf-8?B?K3h0Z0ZRU3YvT2QxRUFyQ2ZZSUFranRITFpVWm90RkhncFBBTHVVcThrUzZN?=
 =?utf-8?B?ZEt6YnRod29Cam5LQnQxM01ibzhOc1V5U1A4dUhyczQyMXF1YmVGSW90NkxJ?=
 =?utf-8?B?U09TVVpBYVVKb0c2YXVZT1ZKKzV0UGhGRFRJMnI5SkhMdFAvYUN3SHpnU1BK?=
 =?utf-8?B?S2FxMkdZL1BGZVBrTGtMU2tSQStaNEVKZDAxbnVtT3JWVXdLYVIyeWpQWUxD?=
 =?utf-8?B?OXJJbG9GR0xrRzh6NElpYmd0bmlSc1d5aU83SDFTeDdadmFTWG5kNDB6Slcr?=
 =?utf-8?B?NFJmVEVXc0E5UTdWczNCeXZWZUltWFpNUEhHcnhNSmdZeXpSQ1p0UkFZRjRY?=
 =?utf-8?B?YlZCL0ZTcDRmZ1dReE93eENrU29qell5K2poYXZNUUVvaWxGdVVrSm42UEpM?=
 =?utf-8?B?dVk2YjZESGJHRkd3WWV5YUh4UHRrR1FWZGhuNHJkeDJGS2VMZ05LWTZmeGdJ?=
 =?utf-8?B?TkFRa3F1U01aanJVa0VzT0MwZkVJcW9ZSGJ5Nk16Z0ZzczVlaTMwV24ydncv?=
 =?utf-8?B?NTR2ZHB0cmcxalNKOEh1bnJFNmNlc1ArV3JnYmtDN0ZrVThrK3RWTk1DMHdB?=
 =?utf-8?B?R0NvVVpKQ0xXeENmUk1naHR4MG11cTlONFk2Qm5sWkpkK2pFQzBaZG5EaXBT?=
 =?utf-8?B?L3UyK0duQjVhcmQ5V2RyZzVrR2FaTDZaRVFjNk1EQlpES0Q2dzEzOHdzZXJB?=
 =?utf-8?B?VHdtQU5GRVp1cmpTQ0MzcER6U3BqakhIcjZDaytkajNVTldPdU9PK3A3R0hR?=
 =?utf-8?B?SHF5SUhJRGVLSHQwemFXV2lXUno5eWxZSzI5bk94OHo1UEVqOHZub21oMlRi?=
 =?utf-8?B?cmxtblRpVlF6UFlKaW1YWjF6bFArWEFvZER2R1YzclBuZnkzbXhSd1VsRCty?=
 =?utf-8?B?YmxVc1d4cjFXakExOWFqZ2tqd1Q0cnRZaUdGQTZXTUQ3aGNuSzdhZXlWNXpV?=
 =?utf-8?B?WHFuZFRHY2VmTWtIbmRPNjlqdUNlRW5DeXlzSXdTNWNaWmRwTHZxQ1NLMlUy?=
 =?utf-8?B?b2tjQUh6WTRvdzNPWDE2czBHTUpaWFMxNjZ4Yy9aamdaVzI5OUtHQU5wN0FS?=
 =?utf-8?B?OHFRazVEZkc4QW01SGxZM2VrVnI4M0UxS0lPbGorZGRuNjJxQXI4VEdlQkdu?=
 =?utf-8?B?VHBQVzVaRGk1NGF3UXE3ZmFOMWMvenVrN1dnYkR6MVVXQ1pUVmpMNUY2Unhh?=
 =?utf-8?B?TmhOSnZvVEUrMnhVYXVnbVBOdlFWRjVjTzdiQjl2YTRpVWZPZTNId1YwakhL?=
 =?utf-8?B?RHhONjZyWXhqM252aFlkMGllSU9lNjhmajd4dlZlZzQ5U2g2NzlZU1hkcWlB?=
 =?utf-8?B?bEdhNXBSV2JIQ0FHbDhoa2ZJaGcwMzlxWGd5MW1ydUVDSE9DZ21vMjJZdHpm?=
 =?utf-8?B?QkE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?eFNNbFQ5Z0FqcnA3QXpyb0R4QzFWelJXdUFFazFEcFlwQkd6OWk5bnhEQTYy?=
 =?utf-8?B?RC9BUldGRkpmeFlNY1JVUFVIcVFWdi9meDYzVmtqejR2d2ZlcWdlMFBDWVc4?=
 =?utf-8?B?NkxsVjVWeXhINXRCSXpEQzBncXgvemFNMzBDb2svODdOSEZmTE1HV3Z0dVVG?=
 =?utf-8?B?OFp2Tk4zWDRidTF5YTFTaXptUFE3eG9CY0dTbXVBTVpwRHJKOUF4T05mMjZ6?=
 =?utf-8?B?N2NWV1dtUmZXSG1qWmplUFkvTUpSdnNZQ2dWai9rV29QbE81TFZ6Y21WUVRI?=
 =?utf-8?B?bnJ0NjQrOXdhVlNlRFVEV1h1c1FWUFlQeUdsUnZvbU1YaWdqRDMyTUpEV3hF?=
 =?utf-8?B?SmUrQ0RIRmw0aFZjY0ZjMWswRkZZZmlZbWJISkZSZ2hjNHV5eDZZUk11TmJV?=
 =?utf-8?B?b3RYVXhiZ1lyY2xJOGVhYnhqcDFhK3FJa3JPQkFQenc1aU1xQTNleDV5anY2?=
 =?utf-8?B?TDhLZXEybHl0ZlVZQWM5UmZOaTRDU2ZZY0dGbU1DelAxZGJTK2lPS1RRVG1t?=
 =?utf-8?B?MTl5UHRCUkZZMVVxYTVKR0V2YlBNb2hSQ25JWUNYa0dJVVJqK1hjUFg2UmVJ?=
 =?utf-8?B?V2lzVXFpKzIrb3VUK1F3ZVBiakFZMHU5eWNpdC82bDEvMTZJcUNrd3JnbHZB?=
 =?utf-8?B?QXM0N3ZBV1crVzFQbER5RDBJOHRoaG90bWwvRndlQUNpNmhDUTVKOWJIVFJO?=
 =?utf-8?B?UUM4OXorZ0VoYlAyRWhBUkV6em1LNTZPdWFhZ0hhVnR0cSs2OS9CdW5WNCs0?=
 =?utf-8?B?WThMbEowTW50U1JqTkZYelZOanNUbWUwOE1RSHVhamlmeDRMWThvUFd6L0dx?=
 =?utf-8?B?ZFowN2p6aWNBZHJRSi9NZkNpSDRFdFBjZ1FtaWlRdDNobzlscHIxekp4a0J3?=
 =?utf-8?B?N045MGxMUUZKWGZaZW90NjZzRGJEMjdlTmEyRVJKVjRDYkhQNFpBcEM5dTUz?=
 =?utf-8?B?ckVybTBZeVFhbW9KNk5TYmpTd2diUjJtaTRGVGc2c0x1UU94RzdvRlZ6bG5m?=
 =?utf-8?B?Zmx5Nyt2cTIweis2RmQwZGdQMnMyUHBOcmRjZ0FxbzFoclRJbDhMYTRGWHph?=
 =?utf-8?B?dlBGdWd5SmdrMG9kb3hqdnFibms0RStWTGh1ZVlTQW9SZlRFNjJSb25RMFNO?=
 =?utf-8?B?cVFGVjZKV3JqcVUwcUw2cG5UYytNQ0U2S1JjSDRGSTk3aEl0MVJ5SEFNZWVH?=
 =?utf-8?B?VDRsbmpnbDVXT2I3TmFFRTVodlJWS2lyQXBlRHY5aGgwU0QyaSt2REQ1cWlz?=
 =?utf-8?B?ME1IQUFhZ3BraUFYRmhSdHY2NVhQaDdseHo4S0RoQmpneDVIVEd6RnFwcXcw?=
 =?utf-8?B?THR5djB1MmY0d0JXOEp4UVV5bkJ6R2hSUWZURUVSNkJmUUVqOG8wSUE0VEFh?=
 =?utf-8?B?bVlQaVY1V3RXS09DalNRZXVWVDZTUU1mcmRvZUtDMFArQ1ZUQjFYSDJOU3lE?=
 =?utf-8?B?SStrRkdLKzdZV01QRTRwaFVtK2dkdWJLM1Fta000TjBtSDRHVFMzYmZTYzVp?=
 =?utf-8?B?T3hPR1V0N0dLcyswT1F6YTYwQjlVWVo1ZktIODVvbStQMGZCRFlBZGxUSzBQ?=
 =?utf-8?B?d2IxQ01uL1RDY2RRRXNNOG9lYThvWDFwb0hWT2pDRW93dUVUanNlRGUxSkdo?=
 =?utf-8?B?elJadnhDTUhvam5uZzZKYWZSZTd5c2FyMVNGK0c3V1ZMRDlaRWl3M1duczhU?=
 =?utf-8?Q?ERl0MAN62yzAEwY8lSNK?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2676828-aa7f-4f08-738b-08dafe26e5c4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 16:20:24.6227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CV5wMMLfHiL304ORr4s8wnfuaQ+yh5KumxyIGa04obj67SRHLvObq2MaqJiPESqL/Tfme9pizYWWbkiaKCDWUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7005
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-24_13,2023-01-24_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301240148
X-Proofpoint-GUID: 7L5R99y1sIRxMflQQ3rBWZG8k8ORbM1n
X-Proofpoint-ORIG-GUID: 7L5R99y1sIRxMflQQ3rBWZG8k8ORbM1n
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/01/2023 06:33, Ian Rogers wrote:
> Create a new pmu_metric for the metric related variables from
> pmu_event but that is initially just a clone of pmu_event. Add
> iterators for pmu_metric and use in places that metrics are desired
> rather than events. Make the event iterator skip metric only events,
> and the metric iterator skip event only events.
> 
> Signed-off-by: Ian Rogers<irogers@google.com>

Reviewed-by: John Garry <john.g.garry@oracle.com>