Message-ID: <700dbf3b-db4c-43bb-2c12-7531622a308e@kernel.dk>
Date:   Tue, 24 Jan 2023 09:42:27 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] x86/fpu: don't set TIF_NEED_FPU_LOAD for PF_IO_WORKER
 threads
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        the arch/x86 maintainers <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <560c844c-f128-555b-40c6-31baff27537f@kernel.dk>
 <Y8/8CFwtpmjzdK9c@hirez.programming.kicks-ass.net>
 <b03383e3-cb10-8b70-a042-dbc2170ee3ec@kernel.dk>
 <Y9AGBXf5mhZ5geGC@hirez.programming.kicks-ass.net>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <Y9AGBXf5mhZ5geGC@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/24/23 9:23 AM, Peter Zijlstra wrote:
> On Tue, Jan 24, 2023 at 09:06:08AM -0700, Jens Axboe wrote:
>> On 1/24/23 8:40 AM, Peter Zijlstra wrote:
>>> On Tue, Jan 24, 2023 at 08:23:20AM -0700, Jens Axboe wrote:
>>>> We don't set it on PF_KTHREAD threads as they never return to userspace,
>>>> and PF_IO_WORKER threads are identical in that regard. As they keep
>>>> running in the kernel until they die, skip setting the FPU flag on them.
>>>
>>> No objection to the actual patch; but this changelog fails to tell us
>>> why this is important.
>>>
>>> What made you get up and write this patch :-) Presumably this is a
>>> performance issue? If so, can you quantify how much?
>>
>> You snipped the part where that was explained, but arguably that should
>> probably go into the commit message itself:
>>
>> "Not urgent, more of a cosmetic thing that was found while debugging and
>> issue and pondering why the FPU flag is set on these threads."
> 
> Duh, I stopped reading at the --- just like a patch tool.. :/

Yeah... Half of that should've been in the commit message, my bad.

>> So it's not really a performance issue, it was just something odd that
>> got me scratching my head when debugging another issue and poking at
>> the flags.
>>
>> Want a resend of it, or will you just augment the commit message?
> 
> I think tglx typically takes fpu patches, but sure can do.

Thanks!

-- 
Jens Axboe