Date:   Tue, 24 Jan 2023 17:19:07 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Pierre Gondois <pierre.gondois@arm.com>
Cc:     linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Conor Dooley <conor.dooley@microchip.com>,
        Dan Carpenter <error27@gmail.com>,
        kernel test robot <lkp@intel.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Oliver Upton <oliver.upton@linux.dev>,
        Akihiko Odaki <akihiko.odaki@daynix.com>,
        Gavin Shan <gshan@redhat.com>,
        Jeremy Linton <jeremy.linton@arm.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next v2 1/3] cacheinfo: Initialize variables in
 fetch_cache_info()
Message-ID: <Y9ATCzWu/YjbZPVE@spud>
References: <20230124154053.355376-1-pierre.gondois@arm.com>
 <20230124154053.355376-2-pierre.gondois@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="kd7w2DvTOd3+8EZQ"
Content-Disposition: inline
In-Reply-To: <20230124154053.355376-2-pierre.gondois@arm.com>
Precedence: bulk


--kd7w2DvTOd3+8EZQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 24, 2023 at 04:40:46PM +0100, Pierre Gondois wrote:
> Set potentially uninitialized variables to 0. This is particularly
> relevant when CONFIG_ACPI_PPTT is not set.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202301052307.JYt1GWaJ-lkp@intel.com/
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/all/Y86iruJPuwNN7rZw@kili/
> Fixes: 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU")
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for the quick respin Pierre :)

> ---
>  drivers/base/cacheinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
> index 418a18acc8f9..f6573c335f4c 100644
> --- a/drivers/base/cacheinfo.c
> +++ b/drivers/base/cacheinfo.c
> @@ -424,7 +424,7 @@ int allocate_cache_info(int cpu)
>  int fetch_cache_info(unsigned int cpu)
>  {
>  	struct cpu_cacheinfo *this_cpu_ci;
> -	unsigned int levels, split_levels;
> +	unsigned int levels =3D 0, split_levels =3D 0;
>  	int ret;
> =20
>  	if (acpi_disabled) {
> --=20
> 2.25.1
>=20

--kd7w2DvTOd3+8EZQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY9ATCwAKCRB4tDGHoIJi
0vWLAQDb8fExDpV5Pof5v1hotbkUozRcMazBZEbDrpWMXOreWwEAvP0piCG5cSbq
hiv1bz87YuZPDSOtf1K9/+oY8R/h6wo=
=i0NU
-----END PGP SIGNATURE-----

--kd7w2DvTOd3+8EZQ--