Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041A1C25B4E for ; Tue, 24 Jan 2023 17:20:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234564AbjAXRUb (ORCPT ); Tue, 24 Jan 2023 12:20:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234771AbjAXRU0 (ORCPT ); Tue, 24 Jan 2023 12:20:26 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31AE14A20D; Tue, 24 Jan 2023 09:20:24 -0800 (PST) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id D2E1760011; Tue, 24 Jan 2023 17:20:21 +0000 (UTC) Message-ID: Subject: Re: [PATCH 2/3] HID: logitech-hidpp: Don't restart communication if not necessary From: Bastien Nocera To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , "Peter F . Patel-Schneider" , Filipe =?ISO-8859-1?Q?La=EDns?= , Nestor Lopez Casado Date: Tue, 24 Jan 2023 18:20:21 +0100 In-Reply-To: <20221220092207.428640-2-hadess@hadess.net> References: <20221220092207.428640-1-hadess@hadess.net> <20221220092207.428640-2-hadess@hadess.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIyLTEyLTIwIGF0IDEwOjIyICswMTAwLCBCYXN0aWVuIE5vY2VyYSB3cm90ZToK PiBEb24ndCBzdG9wIGFuZCByZXN0YXJ0IGNvbW11bmljYXRpb24gd2l0aCB0aGUgZGV2aWNlIHVu bGVzcyB3ZSBuZWVkCj4gdG8KPiBtb2RpZnkgdGhlIGNvbm5lY3QgZmxhZ3MgdXNlZCBiZWNhdXNl IG9mIGEgZGV2aWNlIHF1aXJrLgoKRklXVywgQW5kcmVhcyBCZXJnbWVpZXIgdG9sZCBtZSBvZmYt bGlzdCB0aGF0IHRoaXMgZml4ZWQgdGhlaXIgcHJvYmxlbQp3aXRoIHRoZSBMaXRyYSBHbG93IG5v dCBjb25uZWN0aW5nIHByb3Blcmx5LgoKV291bGQgYmUgZ3JlYXQgdG8gaGF2ZSByZXZpZXdzIG9u IHRoaXMgYW5kIG15IG90aGVyIEhJRCsrIHBhdGNoZXMuCgpDaGVlcnMKCj4gLS0tCj4gwqBkcml2 ZXJzL2hpZC9oaWQtbG9naXRlY2gtaGlkcHAuYyB8IDMxICsrKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLQo+IC0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9oaWQvaGlkLWxvZ2l0ZWNoLWhpZHBw LmMgYi9kcml2ZXJzL2hpZC9oaWQtCj4gbG9naXRlY2gtaGlkcHAuYwo+IGluZGV4IDdmOTE4NzIw MTkxMy4uYjRlNGE4Yzc5Yzc1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaGlkL2hpZC1sb2dpdGVj aC1oaWRwcC5jCj4gKysrIGIvZHJpdmVycy9oaWQvaGlkLWxvZ2l0ZWNoLWhpZHBwLmMKPiBAQCAt NDMxMCw2ICs0MzEwLDcgQEAgc3RhdGljIGludCBoaWRwcF9wcm9iZShzdHJ1Y3QgaGlkX2Rldmlj ZSAqaGRldiwKPiBjb25zdCBzdHJ1Y3QgaGlkX2RldmljZV9pZCAqaWQpCj4gwqDCoMKgwqDCoMKg wqDCoGJvb2wgY29ubmVjdGVkOwo+IMKgwqDCoMKgwqDCoMKgwqB1bnNpZ25lZCBpbnQgY29ubmVj dF9tYXNrID0gSElEX0NPTk5FQ1RfREVGQVVMVDsKPiDCoMKgwqDCoMKgwqDCoMKgc3RydWN0IGhp ZHBwX2ZmX3ByaXZhdGVfZGF0YSBkYXRhOwo+ICvCoMKgwqDCoMKgwqDCoGJvb2wgd2lsbF9yZXN0 YXJ0ID0gZmFsc2U7Cj4gwqAKPiDCoMKgwqDCoMKgwqDCoMKgLyogcmVwb3J0X2ZpeHVwIG5lZWRz IGRydmRhdGEgdG8gYmUgc2V0IGJlZm9yZSB3ZSBjYWxsCj4gaGlkX3BhcnNlICovCj4gwqDCoMKg wqDCoMKgwqDCoGhpZHBwID0gZGV2bV9remFsbG9jKCZoZGV2LT5kZXYsIHNpemVvZigqaGlkcHAp LCBHRlBfS0VSTkVMKTsKPiBAQCAtNDM2MCw2ICs0MzYxLDkgQEAgc3RhdGljIGludCBoaWRwcF9w cm9iZShzdHJ1Y3QgaGlkX2RldmljZSAqaGRldiwKPiBjb25zdCBzdHJ1Y3QgaGlkX2RldmljZV9p ZCAqaWQpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg cmV0dXJuIHJldDsKPiDCoMKgwqDCoMKgwqDCoMKgfQo+IMKgCj4gK8KgwqDCoMKgwqDCoMKgaWYg KGhpZHBwLT5xdWlya3MgJiBISURQUF9RVUlSS19ERUxBWUVEX0lOSVQpCj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHdpbGxfcmVzdGFydCA9IHRydWU7Cj4gKwo+IMKgwqDCoMKgwqDC oMKgwqBJTklUX1dPUksoJmhpZHBwLT53b3JrLCBkZWxheWVkX3dvcmtfY2IpOwo+IMKgwqDCoMKg wqDCoMKgwqBtdXRleF9pbml0KCZoaWRwcC0+c2VuZF9tdXRleCk7Cj4gwqDCoMKgwqDCoMKgwqDC oGluaXRfd2FpdHF1ZXVlX2hlYWQoJmhpZHBwLT53YWl0KTsKPiBAQCAtNDM3NCw3ICs0Mzc4LDcg QEAgc3RhdGljIGludCBoaWRwcF9wcm9iZShzdHJ1Y3QgaGlkX2RldmljZSAqaGRldiwKPiBjb25z dCBzdHJ1Y3QgaGlkX2RldmljZV9pZCAqaWQpCj4gwqDCoMKgwqDCoMKgwqDCoCAqIFBsYWluIFVT QiBjb25uZWN0aW9ucyBuZWVkIHRvIGFjdHVhbGx5IGNhbGwgc3RhcnQgYW5kIG9wZW4KPiDCoMKg wqDCoMKgwqDCoMKgICogb24gdGhlIHRyYW5zcG9ydCBkcml2ZXIgdG8gYWxsb3cgaW5jb21pbmcg ZGF0YS4KPiDCoMKgwqDCoMKgwqDCoMKgICovCj4gLcKgwqDCoMKgwqDCoMKgcmV0ID0gaGlkX2h3 X3N0YXJ0KGhkZXYsIDApOwo+ICvCoMKgwqDCoMKgwqDCoHJldCA9IGhpZF9od19zdGFydChoZGV2 LCB3aWxsX3Jlc3RhcnQgPyAwIDogY29ubmVjdF9tYXNrKTsKPiDCoMKgwqDCoMKgwqDCoMKgaWYg KHJldCkgewo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaGlkX2VycihoZGV2LCAi aHcgc3RhcnQgZmFpbGVkXG4iKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGdv dG8gaGlkX2h3X3N0YXJ0X2ZhaWw7Cj4gQEAgLTQ0MTEsNiArNDQxNSw3IEBAIHN0YXRpYyBpbnQg aGlkcHBfcHJvYmUoc3RydWN0IGhpZF9kZXZpY2UgKmhkZXYsCj4gY29uc3Qgc3RydWN0IGhpZF9k ZXZpY2VfaWQgKmlkKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoGhpZHBwLT53aXJlbGVzc19mZWF0dXJlX2luZGV4ID0gMDsKPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGVsc2UgaWYgKHJldCkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBnb3RvIGhpZF9od19pbml0X2ZhaWw7Cj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldCA9IDA7Cj4gwqDCoMKgwqDCoMKgwqDCoH0KPiDC oAo+IMKgwqDCoMKgwqDCoMKgwqBpZiAoY29ubmVjdGVkICYmIChoaWRwcC0+cXVpcmtzICYgSElE UFBfUVVJUktfQ0xBU1NfV1RQKSkgewo+IEBAIC00NDI1LDE5ICs0NDMwLDIxIEBAIHN0YXRpYyBp bnQgaGlkcHBfcHJvYmUoc3RydWN0IGhpZF9kZXZpY2UKPiAqaGRldiwgY29uc3Qgc3RydWN0IGhp ZF9kZXZpY2VfaWQgKmlkKQo+IMKgCj4gwqDCoMKgwqDCoMKgwqDCoGhpZHBwX2Nvbm5lY3RfZXZl bnQoaGlkcHApOwo+IMKgCj4gLcKgwqDCoMKgwqDCoMKgLyogUmVzZXQgdGhlIEhJRCBub2RlIHN0 YXRlICovCj4gLcKgwqDCoMKgwqDCoMKgaGlkX2RldmljZV9pb19zdG9wKGhkZXYpOwo+IC3CoMKg wqDCoMKgwqDCoGhpZF9od19jbG9zZShoZGV2KTsKPiAtwqDCoMKgwqDCoMKgwqBoaWRfaHdfc3Rv cChoZGV2KTsKPiArwqDCoMKgwqDCoMKgwqBpZiAod2lsbF9yZXN0YXJ0KSB7Cj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoC8qIFJlc2V0IHRoZSBISUQgbm9kZSBzdGF0ZSAqLwo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBoaWRfZGV2aWNlX2lvX3N0b3AoaGRldik7Cj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGhpZF9od19jbG9zZShoZGV2KTsKPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaGlkX2h3X3N0b3AoaGRldik7Cj4gwqAKPiAtwqDC oMKgwqDCoMKgwqBpZiAoaGlkcHAtPnF1aXJrcyAmIEhJRFBQX1FVSVJLX05PX0hJRElOUFVUKQo+ IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBjb25uZWN0X21hc2sgJj0gfkhJRF9DT05O RUNUX0hJRElOUFVUOwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoaGlkcHAt PnF1aXJrcyAmIEhJRFBQX1FVSVJLX05PX0hJRElOUFVUKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY29ubmVjdF9tYXNrICY9IH5ISURfQ09OTkVDVF9I SURJTlBVVDsKPiDCoAo+IC3CoMKgwqDCoMKgwqDCoC8qIE5vdyBleHBvcnQgdGhlIGFjdHVhbCBp bnB1dHMgYW5kIGhpZHJhdyBub2RlcyB0byB0aGUgd29ybGQKPiAqLwo+IC3CoMKgwqDCoMKgwqDC oHJldCA9IGhpZF9od19zdGFydChoZGV2LCBjb25uZWN0X21hc2spOwo+IC3CoMKgwqDCoMKgwqDC oGlmIChyZXQpIHsKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaGlkX2VycihoZGV2 LCAiJXM6aGlkX2h3X3N0YXJ0IHJldHVybmVkIGVycm9yXG4iLAo+IF9fZnVuY19fKTsKPiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ290byBoaWRfaHdfc3RhcnRfZmFpbDsKPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgLyogTm93IGV4cG9ydCB0aGUgYWN0dWFsIGlucHV0 cyBhbmQgaGlkcmF3IG5vZGVzIHRvCj4gdGhlIHdvcmxkICovCj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoHJldCA9IGhpZF9od19zdGFydChoZGV2LCBjb25uZWN0X21hc2spOwo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAocmV0KSB7Cj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBoaWRfZXJyKGhkZXYsICIlczpoaWRfaHdf c3RhcnQgcmV0dXJuZWQKPiBlcnJvclxuIiwgX19mdW5jX18pOwo+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ290byBoaWRfaHdfc3RhcnRfZmFpbDsKPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfQo+IMKgwqDCoMKgwqDCoMKgwqB9Cj4gwqAK PiDCoMKgwqDCoMKgwqDCoMKgaWYgKGhpZHBwLT5xdWlya3MgJiBISURQUF9RVUlSS19DTEFTU19H OTIwKSB7Cgo=