Message-ID: <471c5631-f5b7-84aa-14a9-d587108c7cdd@intel.com>
Date:   Tue, 24 Jan 2023 10:30:39 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH] x86/resctrl: Fix a silly -Wunused-but-set-variable
 warning
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, Babu Moger <babu.moger@amd.com>
CC:     kernel test robot <lkp@intel.com>, <llvm@lists.linux.dev>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <x86@kernel.org>
References: <202301242015.kbzkVteJ-lkp@intel.com> <Y8/XoT23HVXHSY73@zn.tnic>
 <Y9AftBkWXcFflHbm@zn.tnic>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Y9AftBkWXcFflHbm@zn.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlY3MDgyZkRpc3lCNnJOcTBNa1A5L0lrak9oUHBhRzlzRVQxZHVOOXJraGho?=
 =?utf-8?B?MVFORUhZMTQvSnQ2bGNRMWRlejdZT1lNb21uMkQrYTVrSU5NY3RsS01vUUgr?=
 =?utf-8?B?NEl3ZDdwcS9BY0RIbFppN2lValBHTldFbjhDdDdHRE1kRVE4SU9yYXRBcjdm?=
 =?utf-8?B?NXNUaXhIMUMrRnpBZnhFaUp4QXdBeEF3VGhpY1R2TFowNURDNFpXTVNHQTJI?=
 =?utf-8?B?RlE3bnp0b1BTK1NxR2Nta2ZGZkpEdFp1ajIvM3U4UVBSd0tHcm5NMGY5YUhp?=
 =?utf-8?B?TFlpa0Jma1orMlNlNXBlTGxtTHJxSFYxU1NRUElrY2VPYmdONkdDSGlCSm5O?=
 =?utf-8?B?eFlYcGlzaTAwanRKbXlvVmFVUlFpaEhIblhsTG9VOTNWVmJSK0hBR1YyaWdW?=
 =?utf-8?B?NUxMNTVvQmhpSHJPV3RXNUd5cTBuVFhmZXpQM1ZQd2VzaHBrekFMbWM0WWpm?=
 =?utf-8?B?WWtrQWhhZkcrYVorZ3JSOUlsQVlud3V4ckJwckc5eFlla3JFZks3amZlYTJ1?=
 =?utf-8?B?QWdydkJJSHI4UU9LNXhHazRYWEE5R2xwR0doSHplbHIyTzBoWXRLMkZSL2sr?=
 =?utf-8?B?SHdGYTh3UmZRN3grWlE4Q1BJU2phNUN0Rk85RWtsb0dzMkw0TnAxRVRoRWZK?=
 =?utf-8?B?TUlER0MzaVVqbnlhTHVzTVpVUlZnVXRmYmZzTldzTE92QnZUM0I0b1F6VlE2?=
 =?utf-8?B?TWNxd0MrVW1uM1RKMzBWaFd6SHgzZlJUcXExWjhVdXlPakYzL05XK2ZIZk0y?=
 =?utf-8?B?SzEyUk00MlJmQXBaa2E0d0kwL2M5MXNwTk5vMUl2Q3d5TXJ3VjN4VitydUJZ?=
 =?utf-8?B?NXRrWlFqWHV1aXNoWjFZN2w3SkkxTitndlEwTjFSOFpWazRqaWx2TTdJOGpW?=
 =?utf-8?B?TFR4MmliYVVTSUhXZDR0MDkvbVlQQ0hDdnlkRlFEL3ZFQm9jMEIzaWZOaEM3?=
 =?utf-8?B?OUZrZlltb1lpaWxTNkFpL2VPeFdWOWlHUjc4Wjc4RVN1dVJGN0VrQ0kwMVpZ?=
 =?utf-8?B?eVRPOGRoUzhBWGJtVGdUeVNxTjNRdnFyY0JJRzI0RG9RRzF6R25kVTE0aDZz?=
 =?utf-8?B?VVgvNXBjQjJXV09JaWEyUURDRktWMzV6RktEaUtoZmFPSGZxL1dxZUVXY0gx?=
 =?utf-8?B?b1Q5Ull3aXFXMStrQ2RsSnhCeDJralkvOXVXcHUxTzhGS054MzliRXRGMHJT?=
 =?utf-8?B?NDRVUnkvcnJLaDh0Tk0yY3dsNlppa2dIbmdPeE1uckxyL2ZnczVKSXN3TS9h?=
 =?utf-8?B?cW9qOVJwMTFIRjUxN2lLQUJwUmxZeEIwUU9HSDdhTFp2Tk9rUVluZmF0UTFq?=
 =?utf-8?B?d0ZxbW9ocERFeXVuQUd1TWZaYlBKNHRZRHVPYWRZeUdkL3RiZlFRN0FxTHdp?=
 =?utf-8?B?enM5NEsrKzhsYVd5d1k4NENZYStMc3owYjllUWhSeC95NDJ4bGlxWGZvQ0E5?=
 =?utf-8?B?c3krekNER1k3N2NWZklSdzRaOUtuekFqdXNrcmdEdkVpWWtoY0R5YWdidk1z?=
 =?utf-8?B?bkpZMDRrakhXUjM4OW5lblJDNnRrRTUycklsMG9sMEM4Zm9laEV0NUZNVTRY?=
 =?utf-8?B?THNmYm1jZmI1enc3YU41WTM0WnIyUWJaV05GTkFpclNveE9GZ0V5bGJtdDQ2?=
 =?utf-8?B?NFJjcW0wOFNkdStFK1o4UUxPTUlobWszLzNVcGpjOWp1a0ZQcUxMM2J6WWJM?=
 =?utf-8?B?UllsWXI1S2VkT2Zrb3dyWlpsMmh5TmtlSEw1aXphV05uY2R6Q2JVU2s2SkhB?=
 =?utf-8?B?bDQ1Vms3Q1l0WWI0ZVI0WlVzd3ZQTUFoWEd1UVBMUkM3bldPbnY1WUhlVkFz?=
 =?utf-8?B?Q0JNMUVOR2NnRUFYN3V2SEgrdkNiRW9tU2g0YXNJQmxrZ3huOXUxMDFDUlFW?=
 =?utf-8?B?bWVGWkthazJwYXMvQjY4Q1kvVVBHMi9JS0JlbThsY0hwN28rWHlmVUxJald6?=
 =?utf-8?B?c2x4VWRlYUlKOG9ZdVBMcU02NmlMV0FIQ1NYOFEvdmF2WGdWcGRwUmFFT3pR?=
 =?utf-8?B?b2tuckp4RWNLTzNzaC96ZHJpbTRHQUh6d1M3YU9vM2wxMUszUGpzL0RCVlJJ?=
 =?utf-8?B?VHZwc21OZHFUdGhGV1hXT1dHS00rWC9RMHd0NXlGUG1pZXdlMEl6UVZRUDlG?=
 =?utf-8?B?MGFGaTdnVUhiVW85eHQzN2dNV21WL3JCOEZPUVhlZU01QkxkSUpETzZDakJX?=
 =?utf-8?B?bWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 529d2e3a-33a8-4246-13e1-08dafe39190e
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 18:30:41.5321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XHVs3Ovhctwb8xZ/WOVcFXNLpRMDkJlPyse32dyaikZNtl8hAHrPofMpbfI5GJnRWa/8aL1CF9H0gxVJNRL2A1nlAMfQY8D46Tej/nMcxpI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6900
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 1/24/2023 10:13 AM, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> clang correctly complains
> 
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c:1456:6: warning: variable \
>      'h' set but not used [-Wunused-but-set-variable]
>           u32 h;
>               ^
> 
> but it can't know whether this use is innocuous or really a problem.
> There's a reason why those warning switches are behind a W=1 and not
> enabled by default - yes, one needs to do:
> 
>   make W=1 CC=clang HOSTCC=clang arch/x86/kernel/cpu/resctrl/
> 
> with clang 14 in order to trigger it.
> 
> I would normally not take a silly fix like that but this one is simple
> and doesn't make the code uglier so...
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Link: https://lore.kernel.org/r/202301242015.kbzkVteJ-lkp@intel.com
> ---

Thank you very much.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette