Date:   Tue, 24 Jan 2023 15:35:51 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        John Garry <john.g.garry@oracle.com>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, coresight@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] perf: cs-etm: Improve missing sink warning message
Message-ID: <Y9AlB8TJkV2mPO5l@kernel.org>
References: <20230124110220.460551-1-james.clark@arm.com>
 <1dbd558a-92b7-77ed-1bbe-0f421547bf54@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1dbd558a-92b7-77ed-1bbe-0f421547bf54@arm.com>
Precedence: bulk

Em Tue, Jan 24, 2023 at 11:08:32AM +0000, Suzuki K Poulose escreveu:
> On 24/01/2023 11:02, James Clark wrote:
> > Make the sink error message more similar to the event error message that
> > reminds about missing kernel support. The available sinks are also
> > determined by the hardware so mention that too.
> > 
> > Also, usually it's not necessary to specify the sink, so add that as a
> > hint.
> > 
> > Now the error for a made up sink looks like this:
> > 
> >    $ perf record -e cs_etm/@abc/
> >    Couldn't find sink "abc" on event cs_etm/@abc/.
> >    Missing kernel or device support?
> > 
> >    Hint: An appropriate sink will be picked automatically if one isn't is specified.
> > 
> > For any error other than ENOENT, the same message as before is
> > displayed.
> > 
> > Signed-off-by: James Clark <james.clark@arm.com>
> 
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Thanks, applied.

- Arnaldo