Message-ID: <8537e27a-b565-2618-43d0-b70a1a4390e4@amd.com>
Date:   Tue, 24 Jan 2023 12:44:07 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] x86/resctrl: Fix a silly -Wunused-but-set-variable
 warning
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     kernel test robot <lkp@intel.com>, llvm@lists.linux.dev,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        x86@kernel.org, Reinette Chatre <reinette.chatre@intel.com>
References: <202301242015.kbzkVteJ-lkp@intel.com> <Y8/XoT23HVXHSY73@zn.tnic>
 <Y9AftBkWXcFflHbm@zn.tnic>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <Y9AftBkWXcFflHbm@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2JrSGN3Y0ViWEk3aHRvdVpjdW1ISFh2azE1aUozRW5hR2ljaC9WQlljeXJP?=
 =?utf-8?B?eDZNT3Qwc0NuTVpBc0p0dmFqa1YrcHE5dU5hQ2FjelIxRGRrNlFxaElHS2tV?=
 =?utf-8?B?WVNwYTMyWS94UVMwOTZDeUxHRllMbko2SlIwaEJBWXRDUkdpblJrckwrU2hS?=
 =?utf-8?B?VlE5M3RPbmJKenBYb2NyZCtyMHF5OVBWWk5xTXo4Y1JmV05GeTNQMXJ1a2FS?=
 =?utf-8?B?ZExrRFYrSlQ0eEhzc2lSRnE0TmhtZjNtNkJ5Vm1Va0YraVRBY2tGZk5JNTl2?=
 =?utf-8?B?d1VnZWVJZWUrNVgyL0p5N29KNnRFbCs3Q1ZDR01LanQzS09YWkVnK0UwNzB2?=
 =?utf-8?B?Rm9WNGhBaGQ0emxLUUdrNUVvOUFaQkRjVmtMd1JSWk1MQS81ai9BM3Rhc3FO?=
 =?utf-8?B?VDBCcEdYVTBkWDU3QmF4M2RXUlBaOWFralk4N2U3dGFjVy9HazVwVWxab0pM?=
 =?utf-8?B?OTY1K2gvcnlmMVZOZVFvUlVnZXRkSHU5U3hvZjNiUzFueWxFTWRFWGZ4R25s?=
 =?utf-8?B?a0Rwd045SnNlV1VtWmE4bkRvb3hOTEVlUzduenJ4cFlWK2Y2UkVBYndyWDZK?=
 =?utf-8?B?MWJlUHRUL29xZk15ZTdQeTRKZlovZHYwTzZueXRvaGRBcXZRd0pzVmxLTFdk?=
 =?utf-8?B?bXJ2QUh2MGM5V1U4dHljT3JpUWVHdTIrYXVHTUJHSHNtSjhOZUx0OTJVWkgr?=
 =?utf-8?B?M3RHc1dZT005Si8xbGsxUjlpNURjMEZIdVYyc0kvbW45V0tmZFJxOXI2NUZL?=
 =?utf-8?B?Q2IvU1FSd3lNdnc3eEZRTlpDd3YwanhYUS90REh4V0s2dFhjVFVyaldDZ0Jy?=
 =?utf-8?B?QlNGUUhpb0p6c2NIdWJ5N2FjRzRVWHd2M0VObmxVdittMG1JRVFYbGZrT2xv?=
 =?utf-8?B?Tk9rQzFqL3VNbzlRL0czNHdKSzBENUtVOWplbkYrTWk3QVZ3bXBWN3k1NGcx?=
 =?utf-8?B?dXYrMGNBTDZNMDF0a0NOUGpCZzRQRjhFUk5CWVZQYmJlSWwyUm9ub25xdFhM?=
 =?utf-8?B?cUs4RVNMM2s4UE9ibkxZNktHMExJTmZZa3NlTUV1R3FXdGhZUVlvL3pVMXNl?=
 =?utf-8?B?Mm56ZjB4UUNaMDVndlkwVHhRTGI3WFJpNnRGZGU2UDJuZ2EzcCszbHMvcGRx?=
 =?utf-8?B?K3R0aTkvTkR5QzRZVUc5RUZPbTlXVE5xdVk1eWNMWmxPNnVrb2E1ZTFGbElD?=
 =?utf-8?B?Tzk1Q2RmZGxqSFczL2dBU1JpQndGVXBoWHdTcUlWOVFyb0RZa3NVTFhCNk9t?=
 =?utf-8?B?bVhYWmVzRFNvRWMyaW9hMWJjLzUyNVJ1bSs0SndOYWtVTnVoUFB2OWpEZ0dC?=
 =?utf-8?B?M0ZUYmdhemNZMlhnL1VEdjF3MHRpSWxqbDVXOWdOL0wzaHBYc2JVNmtraGRl?=
 =?utf-8?B?Vk44T29KYWZNWWRJQUVXaGY1ZWxxemk2QkpGandVTnM1V3lGKzVHdjlESnln?=
 =?utf-8?B?WGg5bDNyZVpqRFhCdXNlOVJEVFNvWkpzaWZvUmYzbjQ2dDJWTkQwbzMwWkxR?=
 =?utf-8?B?ZXdFK1JrRHhHbVRPNVR3N09QazFkc2lBclhJRHdPamdhdmJCWWFPOHBoMCtZ?=
 =?utf-8?B?ZGFuTjBVYkdlcDV1eUdRcmJMRjkrMjBiQy9HaXVzQmExb2NEMFlIemowT3lm?=
 =?utf-8?B?bENpb3pGZzlSMlJnYzNNK0h2VkRaTkRCSk83WnJFM2VGWXVGVi9CYzdJVUND?=
 =?utf-8?B?VTIyRVUzc0JCQVloUzltZXlkUldYLzlpVG5uRVVSQVMrRWw4SHpycTcxTFJT?=
 =?utf-8?B?VWJKZ0V4Nll2MmttYjk0R1VheVY0Sy9FUWZYRVF3eEdGeDhxbVBCeXd6b0lU?=
 =?utf-8?B?S1duMUNDQ09FMGpRSm1zb21lcjdXZ3JaeG9oQ0FkSHRMdGVvTHJaZFpFOENI?=
 =?utf-8?B?SUZ2VHN4VjF1bzJiR1I4ODZEMFYydGRvcW92SW95MnpDTGVzcjNyZEx4dEhU?=
 =?utf-8?B?YUZhdUtLdjRpYURWb1FiVHhRR3g2c256LzRJRjFObHF0ZXEzaFBuampJU0R0?=
 =?utf-8?B?dEtZZmNlMXd3YUVjWXBVR1EwaDZVL09SNFgrcHFFM0FKU1pmTGdycmIxMk00?=
 =?utf-8?B?bDE3YXRhemw1ekswcS9nang1WHpHVCtuV3BiVFd2REFySEsyalRFOEl4RXlH?=
 =?utf-8?Q?Gt25PO4V9R1+6vT6Vu8WuJxx4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abb0b48c-d7c2-467a-bcef-08dafe3afb4a
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 18:44:10.5914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rnkhg16GIKPXC1yoJtzGALPScdMjsNH9Yb/VuY1oxrLsh8GFqjdvDvYRx4be0PPh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6161
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Boris, Thanks for the fix.

Tested-by: Babu Moger <babu.moger@amd.com>


On 1/24/23 12:13, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> clang correctly complains
>
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c:1456:6: warning: variable \
>      'h' set but not used [-Wunused-but-set-variable]
>           u32 h;
>               ^
>
> but it can't know whether this use is innocuous or really a problem.
> There's a reason why those warning switches are behind a W=1 and not
> enabled by default - yes, one needs to do:
>
>   make W=1 CC=clang HOSTCC=clang arch/x86/kernel/cpu/resctrl/
>
> with clang 14 in order to trigger it.
>
> I would normally not take a silly fix like that but this one is simple
> and doesn't make the code uglier so...
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Link: https://lore.kernel.org/r/202301242015.kbzkVteJ-lkp@intel.com
> ---
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 5990589f8a21..e2c1599d1b37 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -1453,17 +1453,17 @@ static void mon_event_config_read(void *info)
>  {
>  	struct mon_config_info *mon_info = info;
>  	unsigned int index;
> -	u32 h;
> +	u64 msrval;
>  
>  	index = mon_event_config_index_get(mon_info->evtid);
>  	if (index == INVALID_CONFIG_INDEX) {
>  		pr_warn_once("Invalid event id %d\n", mon_info->evtid);
>  		return;
>  	}
> -	rdmsr(MSR_IA32_EVT_CFG_BASE + index, mon_info->mon_config, h);
> +	rdmsrl(MSR_IA32_EVT_CFG_BASE + index, msrval);
>  
>  	/* Report only the valid event configuration bits */
> -	mon_info->mon_config &= MAX_EVT_CONFIG_BITS;
> +	mon_info->mon_config = msrval & MAX_EVT_CONFIG_BITS;
>  }
>  
>  static void mondata_config_read(struct rdt_domain *d, struct mon_config_info *mon_info)

-- 
Thanks
Babu Moger