Message-ID: <2cf1380e-ed98-d943-e492-ebbe9238b51c@amd.com>
Date:   Tue, 24 Jan 2023 13:03:32 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event
 Configuration feature flag
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Borislav Petkov <bp@alien8.de>
Cc:     "Luck, Tony" <tony.luck@intel.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Bae, Chang Seok" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "Eranian, Stephane" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <20230109164405.569714-5-babu.moger@amd.com>
 <Y7xjxUj+KnOEJssZ@zn.tnic> <5afd0a7c-3fbe-dfea-f1b4-2fc35fbb4f13@amd.com>
 <Y7yCCNANVBnOOmxM@zn.tnic>
 <SJ1PR11MB608321F26D729A082BFC6FAEFCFE9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <ecf0abf0-59fe-3898-762c-d9d883925550@amd.com> <Y7yMbQ8hI9MGl1w3@zn.tnic>
 <MW3PR12MB455384130AF0BDE3AF88BCF095FE9@MW3PR12MB4553.namprd12.prod.outlook.com>
 <Y8/CSrU8Bo298VzO@zn.tnic> <72cdefc5-1601-5c43-9ea4-4b637f5fafa5@amd.com>
 <Y8/07cV+t0PrqWX9@zn.tnic> <4ac38b77-77aa-f2c0-36e4-5e482013091d@amd.com>
 <1e662209-93d7-2247-4212-8c78748c69bd@intel.com>
 <12f98b80-38ce-5912-fa10-33d6b8a2fa81@amd.com>
 <f6e24e38-31d4-e2f4-4dc1-13208a427a77@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <f6e24e38-31d4-e2f4-4dc1-13208a427a77@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTVxblhpNk5MYTd1dm00aVhZY3RDZUxLU2dzQldqWmlraENCeGk0cUVmaWFz?=
 =?utf-8?B?VzZKTnBuOVZxcjhvb2dDZEk5VWxjcWdCVWFuZTZydFJmQitCN1B2ejFUZlU1?=
 =?utf-8?B?OGhoSEdOdzJDTHh0TUJ1WVpXU1ZsWFpTbjYvWnl3T3pycm1lWm00UVY1eHJx?=
 =?utf-8?B?ck1iQldtczIrOHNoL2d2amszY09aUWJIcTMwRDVmcU50Z3NtZERMUTVjWXp0?=
 =?utf-8?B?V0wra0VxenRaTG1kT0hyNThIZGRvZDhDSW44OFJleUduNHRXdDRXanJSbmxU?=
 =?utf-8?B?ZlRsRXRGbHo2b3ZuLzQ1NHJja3ZvVEMwRktPeTJrTHJTbVVsU21jN3EyN3h4?=
 =?utf-8?B?djdOakxUVFJlNEcxbFd5NnlQZVZRa09KVlRhb2Mvb3o3Z3ZtU1JpN0RQaitO?=
 =?utf-8?B?VE9HY2Z2UU4yL29BTGJ0VERDdUlGTnVYMmpSU213YkVvNkpBTVJORGFmUjh0?=
 =?utf-8?B?V3lsTE9VdklUQzBXQzRlQ2Z1RVNiaElVdDE2ZjU2VW94VFhjeU1LaEFpd1ZT?=
 =?utf-8?B?REppTENLV3hyVWlhM2c2RUJUd1k2TUp1UTZtaUl3YkR4citBZzlGYWI2OVNW?=
 =?utf-8?B?SXNqcFV6d0tMQmpvYmhSMlU0RjE3eW8zeFkxLzNPaXFvRGdwWjNiY0NlanNP?=
 =?utf-8?B?Mm8wWnZUK3ZYZWU0Z2p6ZXVMdVpEZmIwa25kWUpFbWlMRXhVN0l1ODJkbTAr?=
 =?utf-8?B?eXpRY2dtVWFRUXhRZ0FkTmZWT1VTanFRdnlCWUJqMnp5dlJRTENyTGYva3Qx?=
 =?utf-8?B?ZHAxUVBncjlFdzczaXZxcUg1b1pXRU9NNDY3N1FydGk4eEhEUXdiRVRWNXo3?=
 =?utf-8?B?Qmh5akFMUXIwMFhXM3oyRUg4Q0FQQXRqU0hnYmRxa2UzR0VxMklmOGtkSnF5?=
 =?utf-8?B?NUJlRGpwbWdzVk44YjdOdjhmUVZiL2tEcURtem9LTmQxTE1PdzgrZFJTSU5P?=
 =?utf-8?B?VGFPQSswdHE1SFdmT2Zxa1dnQjdHRVlUK2ttU0kxS0x3OHNSRTFid1pBYVFT?=
 =?utf-8?B?U0V0ejhMdVJjVXFXTy8vNUdXY0NPNWJsUDlGVDFrK1JTam9teFdEaXkwdHlK?=
 =?utf-8?B?VWtlVmpMTFNRU1BHLzZxVzkyQmVVZnFjcTBjeE1sTTJDZGJydWhzc1RCbk44?=
 =?utf-8?B?Z3NqWmJETzErOW5lMzJsdHl4QVlSUWF1VzVGRHBabEQ2OGcxWnNGektxcGox?=
 =?utf-8?B?RllxR3Q0NW0vcjJRUE1KcGJOcDVsNGpFYXJNTy9HTFZtczdRN25lRWR6NHQy?=
 =?utf-8?B?QnYzTDgvZXZDZFlKakZ5ME0zc1NGQjRlcTlmQ3o3TzdmbFZFV2ZmQjYwazdM?=
 =?utf-8?B?WEEwTUlyZUg5VXFFeVF0WnZoQWhEZFhyK2VlTi90aFZkU3pwQ1YrN3RQcVls?=
 =?utf-8?B?NTY1Ry9CTTRDbXRjeVBmTTRpQjEyRmsrSmxFZytobGFIZk45eE5pVmJ1VkxM?=
 =?utf-8?B?NWFyank1S1ZBME8yM2grRm53aXVOTklqeFRiR2ltMEdqd25VcEhVZ3JSSlJJ?=
 =?utf-8?B?bGVxaGVIVWVXdTg2NXYrT0NyMnFhdFNPOThrNjhRQytTR2RocXFRN1l0bjFt?=
 =?utf-8?B?SUZsYlFBQ21Ba3lsa0FRRGx2SERmb0Q3Z3lwWWQxMjhPajRObTZRRmg5ZWYy?=
 =?utf-8?B?SVZrcExqc29MeXFSVTJRZWV6RlVlNVROUTkraWRtcjhQUHB6WkYxVnZ0UUZ5?=
 =?utf-8?B?UFcxd252Y2hTMlQzdzVJMHBvQ3B0eFBTaHJnd1ptWGU0WWRFbVNkWFRoaXRm?=
 =?utf-8?B?eTFuKzRQVjFSU000UEFJM2JmOTZ3ZVhQa3BiSHo3Rno2OFZGTVJNRFJJVUtB?=
 =?utf-8?B?YTVma0Y5aDNPb3VJOEFycEVjaVZ6alRJUlc3Z0ZpeUdTWEgwbW5CVWYrYmxX?=
 =?utf-8?B?aE5LeGVhZjhXcUIvbjdYVHFYZGNGZGtyalpMZ2VVeVdDQ0YyelVjWjNIWExH?=
 =?utf-8?B?THE2RWRINWpxSHlTVlRiZVkzQzVFdnhKMWtWWjlhUHMranprUnppR3pXWFR0?=
 =?utf-8?B?K0RXYTVzcjd5OVBsamdaMDZwNDBESHZMWVdob3J5ZjNWTVpOeWhjTHhud0FL?=
 =?utf-8?B?RFpnSW15Sko1OG5TY1c2T0duODdRTFpXTmVzOUdMaWpHK3Z4T3RFeDBSQ2NN?=
 =?utf-8?Q?WXWvzq3jNyuN/p37FBsf9l7p+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be222f88-d226-4bb9-5317-08dafe3db3d1
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 19:03:39.1995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aamyEhHAAc21QywxuMp2QGlk8Jn55Mtzl9haLK3ikARBna5zFC+BW9FhM9IFgvJA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5374
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/24/23 11:47, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/24/2023 9:30 AM, Moger, Babu wrote:
>> On 1/24/23 10:59, Reinette Chatre wrote:
>>> On 1/24/2023 8:06 AM, Moger, Babu wrote:
>>>> On 1/24/23 09:10, Borislav Petkov wrote:
>>>>> On Tue, Jan 24, 2023 at 08:11:21AM -0600, Moger, Babu wrote:
>>>>>> Understood. I am planning to add resctrl feature list inside
>>>>>> /sys/fs/resctrl/info/ in my next series.
>>>>> Maybe I wasn't as clear as I hoped for:
>>>>>
>>>>> so you have a couple of flags in /proc/cpuinfo which are actively being used by
>>>>> tools.
>>>> Those flags will be there. Not planning to remove them.
>>>>> Why would you want to move the flags somewhere else and do the extra work for no
>>>>> apparent reason?
>>>> With this series(v12) we have added two new cpuid features(SMBA and BMEC).
>>>>
>>>> But these features are not visible in /proc/cpuinfo. Planning to add them
>>>> in /sys/fs/resctrl/info.
>>>>
>>>> So, users can see them here. 
>>> Could you please elaborate what you are planning to do? 
>> Yes. It is sort of available. But, I wanted to add them explicit using the
>> already available function rdt_cpu_has().
>>
>> Something like.
>>
>> #cat /sys/fs/resctrl/info/features
>>
>>  cmt, mbmtotal, mbmlocal, l3cat, mba, smba, bmec
>>
>>
>> Some of these features can be disabled using boot parameter options. So,
>> this will show only the features which enabled. 
>>
> From what I understand the only feature that needs additional help is CDP
> and it appears in /proc/cpuinfo. For all other features
> /sys/fs/resctrl/info already provides information when they are enabled, no?

Yes. It is available.  But, the feature BMEC is not explicitly available.
I was thinking making all of them explicit. But we can live with that for
now. We can think about this in the future. Thanks for the comments.

Thanks

Babu

> Reinette
>
-- 
Thanks
Babu Moger