Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <Y9ArYfXEix7t3gVI@infradead.org>
References: <Y9ArYfXEix7t3gVI@infradead.org> <20230124170108.1070389-1-dhowells@redhat.com> <20230124170108.1070389-7-dhowells@redhat.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v9 6/8] block: Switch to pinning pages.
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1297803.1674593951.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: quoted-printable
Date:   Tue, 24 Jan 2023 20:59:11 +0000
Message-ID: <1297804.1674593951@warthog.procyon.org.uk>
Precedence: bulk

Christoph Hellwig <hch@infradead.org> wrote:

> > Add BIO_PAGE_PINNED to indicate that the pages in a bio are pinned
> > (FOLL_PIN) and that the pin will need removing.
> =

> The subject is odd when this doesn't actually switch anything,
> but just adds the infrastructure to unpin pages.

How about:

	block: Add BIO_PAGE_PINNED and associated infrastructure

> > +static inline void bio_set_cleanup_mode(struct bio *bio, struct iov_i=
ter *iter)
> ...
> At this point I'd be tempted to just open code these two lines
> instead of adding a helper, but I can live with the helper if you
> prefer it.

I can do that.  It makes sense to put the call to that next to the call to
iov_iter_extract_pages().

David