Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A71C61D97 for ; Tue, 24 Jan 2023 21:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234899AbjAXVUB (ORCPT ); Tue, 24 Jan 2023 16:20:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235056AbjAXVTo (ORCPT ); Tue, 24 Jan 2023 16:19:44 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AA9351C4C for ; Tue, 24 Jan 2023 13:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674595084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cp0bQAXkNYOtockNiUGfxh3g6gE8MLITE+yOOD5XVmY=; b=Ol3HFvmfzDyCAa9x4aDFkAxBtRNKNEPEsYkqxnwQCMIjD+23z11IGfEih3lxhoX3bjb2bY clYjhrCMFvSc9qrwZ1cDHMBnzHGgagTGhUzoWd+2ITQ5YP9G4eyDSe5Ka8EIupKS7DfAGc cgHSirxzs/TnWU6FgD9UhxdE+GaukKE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-nDIqO7AtO72E8yH6xux5Lw-1; Tue, 24 Jan 2023 16:18:01 -0500 X-MC-Unique: nDIqO7AtO72E8yH6xux5Lw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 510B485C06B; Tue, 24 Jan 2023 21:18:00 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70FD9140EBF5; Tue, 24 Jan 2023 21:17:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230124170108.1070389-1-dhowells@redhat.com> <20230124170108.1070389-6-dhowells@redhat.com> To: John Hubbard , Christoph Hellwig Cc: dhowells@redhat.com, Al Viro , Matthew Wilcox , Jens Axboe , "Jan Kara" , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "Christoph Hellwig" Subject: Re: [PATCH v9 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1353770.1674595077.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 24 Jan 2023 21:17:57 +0000 Message-ID: <1353771.1674595077@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org John Hubbard wrote: > > + /* for now require references for all pages */ > = > Maybe just delete this comment? Christoph added that. Presumably because this really should move to pinni= ng or be replaced with iomap, but it's not straightforward either way. Chris= toph? David