From:   "Li, Xin3" <xin3.li@intel.com>
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>,
        "H. Peter Anvin" <hpa@zytor.com>, x86 Mailing List <x86@kernel.org>
CC:     "Hansen, Dave" <dave.hansen@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        Brian Gerst <brgerst@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Shuah Khan <shuah@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Linux Kselftest Mailing List 
        <linux-kselftest@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v3 0/2] selftests/x86: sysret_rip update for FRED
 system
Thread-Topic: [RFC PATCH v3 0/2] selftests/x86: sysret_rip update for FRED
 system
Thread-Index: AQHZL9wHXOCNBEx4pEaxwC77ioU9Ra6uFIBQ
Date:   Tue, 24 Jan 2023 21:32:14 +0000
Message-ID: <SA1PR11MB6734CA3184183E490D18CA72A8C99@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <b6e36a5c-6f5e-eda6-54ad-a0c20eb00402@intel.com>
 <25b96960-a07e-a952-5c23-786b55054126@zytor.com>
 <fb1cab9f-a373-38e6-92e6-456332010653@gnuweeb.org>
 <6cd0db14-c9e2-3598-fd10-4b473d78c373@citrix.com>
 <5ecc383c-621b-57d9-7f6d-d63496fca3b3@zytor.com>
 <20230124022729.596997-1-ammarfaizi2@gnuweeb.org>
 <20230124022729.596997-3-ammarfaizi2@gnuweeb.org>
 <ce25e53f-91d4-d793-42a5-036d6bce0b4c@zytor.com>
 <Y899kHYbz32H1S6a@biznet-home.integral.gnuweeb.org>
 <BC632CA8-D2CB-4781-82E5-9810347293B0@zytor.com>
 <Y8+hGxVpgFVcm15g@biznet-home.integral.gnuweeb.org>
 <20230124100926.637335-1-ammarfaizi2@gnuweeb.org>
In-Reply-To: <20230124100926.637335-1-ammarfaizi2@gnuweeb.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kbHSDxbB0b/KtQtk/J4LNN/NjHTmeeL+wW3UG90y6cxlLLQsq340+IvdqelW?=
 =?us-ascii?Q?WK2yALeHs4G6qdcfcjzj3v0jAxSZOU/S4pqQCiQAPfjFLsikWM1PJbkOkgyB?=
 =?us-ascii?Q?xxg9y6Vv89mk8FQ+dsJaVofFupKwtNfh4B8ADVUEmQxSRldgT2bXRaWQJGIt?=
 =?us-ascii?Q?ZX/hhEvB352OlWM16WwZh0U5tuVi0s0R0NB0DYJ0wxyfgRYDyWbmVsolQBGo?=
 =?us-ascii?Q?sJZNK4LGO+ZUXZQVYQg5lwH0vpXMrSaM11EeEUdw/UYA3iPf9r3sVOBLcCWC?=
 =?us-ascii?Q?yOqEJxyOroQh0L+REuE5+3DXDty70SzaOsjVylZVgKaFkEjhyHEOp/rt3qKd?=
 =?us-ascii?Q?/InHi1w4BSj61EwpZjXGZkWrSUKWMECoiH8imeziAI8cBaH19+GQDv8WhWf+?=
 =?us-ascii?Q?hmpIVQhq4WoAv5AfSG2paIli8NKiO6CHgLyCyh23i7+69343YU2/lYNL5GMI?=
 =?us-ascii?Q?xjyrdCKXf0o5xhhSxQcSsi48dLHUw+RNsCZzr8AK48ZqmoDciyuAPmNjWkB8?=
 =?us-ascii?Q?Wbz0SN6bd3nmQZ+6ns4V3WknyuRT4aDbJLlAeap/FrfZURmZZFFDILrTf75z?=
 =?us-ascii?Q?TpDbGc6jqIf3L5caSDAS1aUtymuSJvXKXm/cHkksiOgtLHZnlYXmI+1TFD8B?=
 =?us-ascii?Q?PcQQkSYpTknC5XsErz8b4VvzvhV06LZ5t8cuSfaKtv2HSqjyNW3AadGvi3aD?=
 =?us-ascii?Q?dSd3B1Bdjq3Dy0u3N4ZweIag+K0QGUbtiZFhVFFXnjbduwQaxTR1hLj7omG7?=
 =?us-ascii?Q?c3GpHEg196PLY+zISAx5BF0Je6j5bARCWBqMuQ3f62p5UWOoV+Kz2GGqJMi6?=
 =?us-ascii?Q?UyHgDeXw7dM644mStAEiYA04bVJCQrCgJPoNIwe4vFeokrcOrqAA1ZG7Otdu?=
 =?us-ascii?Q?/+SnAkUWrMjWMHV033LzOWZnSLgztJaXcpp0Xz/XiTtIOiamJwO8pIDhYYKq?=
 =?us-ascii?Q?Bwye8ZYFUAJ4NQud8rdXUcauHYCePQShTlm7SuwcoT7utXTYWlUWrOX+cj/8?=
 =?us-ascii?Q?42+/XZ/VVp91pmFH8QVmbb+dPQHPAF8Uwq88U1G+BVFAbXBW8GH/RZGph1gR?=
 =?us-ascii?Q?dNSx5kdidN13b2pSyi+nry45o3G0btQSUhAirIiRA0g0O5jrmK/ArKRjaT5C?=
 =?us-ascii?Q?X+NA9VxdieLtK5HYiz9r2NOz/PmxSuusTl2nHhSU39VuKFUgm5AcEq9cXHHX?=
 =?us-ascii?Q?oCzdOfeXxxhklZSFeEIwMBsJ9HZvGa5i8HJZ4semr+DvUfMUL6tff6zDoyOY?=
 =?us-ascii?Q?Do1dax5ZxtYtai9uSPdb7+h+GxuJUJCDPOyRJTJebe81RWe4AiBx+E3n/p+U?=
 =?us-ascii?Q?8IoOGDodYUtLjxgf59dWc8TS/epOoXdy2NXps/g03wn+xIskuQ6QgK44yCrk?=
 =?us-ascii?Q?2iSdsrqISjatWKXs7IIyeOY59Lv5f2X2eWG0IIuHW3jJx++LM7XayvB4b1hd?=
 =?us-ascii?Q?ggxhDGSbwnP2U2nbMsJDg1Kt3rqXRqzAhfKa+qNIm08cLnn82UauFitimEi1?=
 =?us-ascii?Q?o92SEIuFK5p/2aD0j9swqbjlTlSvQy1UUQQJ9hxKnwowiURJGXWghDe9PYVr?=
 =?us-ascii?Q?S44/P9m1Lv/kCIu/OHDGKaBA32r1nW20UOHcJATZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62336c3b-ef5b-4a08-8669-08dafe5275ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2023 21:32:14.5595
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wvTSy3ECgLTV08JHLpfHTYVBhvSO5qCBb+vMqOJDhJ54w0QrglOEArlAwjvS0XnIa+pnNyh9FH6b/N/ce2mftg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4960
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>=20
> This is an RFC patchset v3:
> sysret_rip test update for Intel FRED architecture.
>=20
> Xin Li reported sysret_rip test fails at:
>=20
>         assert(ctx->uc_mcontext.gregs[REG_EFL] =3D=3D
>                ctx->uc_mcontext.gregs[REG_R11]);

On FRED systems, flags is 0x200a93 and r11 is 0xfeedfacedeadbeef here.

We need to remove or change this assertion, maybe:
  assert(ctx->uc_mcontext.gregs[REG_EFL] =3D=3D ctx->uc_mcontext.gregs[REG_=
R11] ||
         r11_sentinel =3D=3D ctx->uc_mcontext.gregs[REG_R11]);

>=20
> in a FRED system. Let's handle the FRED system scenario too. The 'syscall=
'
> instruction in a FRED system doesn't set %r11=3D%rflags.
>=20
> There are two patches in this series.
>=20
> How to test this:
>=20
>   $ make -C tools/testing/selftests/x86
>   $ tools/testing/selftests/x86/sysret_rip_64
>=20
> Link: https://lore.kernel.org/lkml/5d4ad3e3-034f-c7da-d141-
> 9c001c2343af@intel.com
> Fixes: 660602140103 ("selftests/x86: Add a selftest for SYSRET to noncano=
nical
> addresses")
> Link: https://lore.kernel.org/lkml/25b96960-a07e-a952-5c23-
> 786b55054126@zytor.com
> Reported-by: Xin Li <xin3.li@intel.com>
> Co-developed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> Acked-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---
>=20
> ## Changelog v3:
>=20
>    - Test that we don't get a mix of REGS_SAVED and REGS_SYSRET,
>      which is a major part of the point (hpa).
>=20
> ## Changelog v2:
>=20
>    - Use "+r"(rsp) as the right way to avoid redzone problems
>      per Andrew's comment (hpa).
>      (Ref: https://lore.kernel.org/lkml/8f5c24df-514d-5d89-f58f-
> ec8c3eb1e049@zytor.com )
>=20
> ---
>=20
> Ammar Faizi (2):
>   selftests/x86: sysret_rip: Handle syscall in a FRED system
>   selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx=
` and `%r11`
>=20
>  tools/testing/selftests/x86/sysret_rip.c | 120 ++++++++++++++++++++++-
>  1 file changed, 119 insertions(+), 1 deletion(-)
>=20
>=20
> base-commit: e12ad468c22065a2826b2fc4c11d2113a7975301
> --
> Ammar Faizi