Message-ID: <90f005c1-effa-2117-8b57-fb8f2cf9d71b@collabora.com>
Date:   Wed, 25 Jan 2023 01:09:03 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v3 02/21] dt-bindings: display: tegra: vi: add 'vip'
 property and example
Content-Language: en-US
To:     Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dmitry Osipenko <digetx@gmail.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Richard Leitner <richard.leitner@skidata.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
References: <20221229133205.981397-1-luca.ceresoli@bootlin.com>
 <20221229133205.981397-3-luca.ceresoli@bootlin.com>
 <cdc91bc4-aa76-f824-36c9-d2995c17fb18@collabora.com>
 <20230124221421.2d45a532@booty>
From:   Dmitry Osipenko <dmitry.osipenko@collabora.com>
In-Reply-To: <20230124221421.2d45a532@booty>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/25/23 00:14, Luca Ceresoli wrote:
> Hi Dmitry,
> 
> On Tue, 24 Jan 2023 20:02:39 +0300
> Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote:
> 
>> On 12/29/22 16:31, Luca Ceresoli wrote:
>>> +        vip {
>>> +            compatible = "nvidia,tegra20-vip";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <0>;
>>> +            channel@0 {
>>> +                reg = <0>;
>>> +                ports {
>>> +                    #address-cells = <1>;
>>> +                    #size-cells = <0>;
>>> +                    port@0 {
>>> +                        reg = <0>;
>>> +                        vi_vip_in: endpoint {
>>> +                            remote-endpoint = <&mt9v111_out>;
>>> +                        };
>>> +                    };
>>> +                    port@1 {
>>> +                        reg = <1>;
>>> +                        vi_vip_out: endpoint {
>>> +                            remote-endpoint = <&vi_in>;
>>> +                        };
>>> +                    };
>>> +                };
>>> +            };  
>>
>> In the changelog you said that the channel@0 node is removed
> 
> Thanks, you are right, this is a leftover. I must have forgotten about
> updating the example. :-\
> 
> It will be fixed in v4 obviously, I was waiting before sending it in
> case of any feedback on the other patches.

The rest of the patches look okay. The patchset should get testing on
T210 and then will be good to apply it, IMO. If nobody will volunteer to
test T210 then should be good to apply it too, we can always fix the
code later on.

-- 
Best regards,
Dmitry