Message-ID: <7781e371-781c-c301-6504-99fdeb7f2b36@linaro.org>
Date:   Wed, 25 Jan 2023 02:57:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH v3 2/9] interconnect: qcom: rpm: Always set QoS params on
 QNoC
Content-Language: en-US
To:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc:     marijn.suijten@somainline.org, Georgi Djakov <djakov@kernel.org>,
        AngeloGioacchino Del Regno <kholk11@gmail.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Loic Poulain <loic.poulain@linaro.org>,
        Shawn Guo <shawn.guo@linaro.org>
References: <20230116132152.405535-1-konrad.dybcio@linaro.org>
 <20230116132152.405535-3-konrad.dybcio@linaro.org>
 <8673ef49-a37e-2d76-b800-bf9b10875006@linaro.org>
 <eac4a16e-c6b2-64ae-f5a2-84dab64476df@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <eac4a16e-c6b2-64ae-f5a2-84dab64476df@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 19.01.2023 01:27, Bryan O'Donoghue wrote:
> On 18/01/2023 20:36, Konrad Dybcio wrote:
>> Would be very nice if somebody could test this one in particular
>> on QCM2290 to make sure it does not regress that SoC..
>>
>> Shawn, Loic?
>>
>> Konrad
> 
> I have a 2290.
> 
> Since I'm already helping with review, I'm happy to help with test too.
Thanks!

I'm afraid it won't be necessary though..

This patch gives more trouble than it solves. Here's the thing:

It was working perfectly on my SM6375 for quite some time and then
I rebased my branch on a newer -next and suddenly it makes things go
boom boom.. I think I'll drop it in the next revision, even if that's
what downstream does.. At least until I pretend to be an archaeologist
surgeon again and debug this..

Konrad

> 
> ---
> bod