Date:   Tue, 24 Jan 2023 19:24:37 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>
Cc:     davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
        pabeni@redhat.com, edumazet@google.com, a@unstable.cc,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ip/ip6_gre: Fix changing addr gen mode not
 generating IPv6 link local address
Message-ID: <20230124192437.6d33cc06@kernel.org>
In-Reply-To: <20230124032105.79487-4-Thomas.Winter@alliedtelesis.co.nz>
References: <20230124032105.79487-1-Thomas.Winter@alliedtelesis.co.nz>
        <20230124032105.79487-4-Thomas.Winter@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 24 Jan 2023 16:21:04 +1300 Thomas Winter wrote:
> Commit e5dd729460ca changed the code path so that GRE tunnels
> generate an IPv6 address based on the tunnel source address.
> It also changed the code path so GRE tunnels don't call addrconf_addr_gen
> in addrconf_dev_config which is called by addrconf_sysctl_addr_gen_mode
> when the IN6_ADDR_GEN_MODE is changed.
> 
> This patch aims to fix this issue by moving the code in addrconf_notify
> which calls the addr gen for GRE and SIT into a separate function
> and calling it in the places that expect the IPv6 address to be
> generated.
> 
> The previous addrconf_dev_config is renamed to addrconf_eth_config
> since it only expected eth type interfaces and follows the
> addrconf_gre/sit_config format.

The commit message reads like a description of the code changes, 
not the problem statement + extra context it should be.

Please start with a solid description of what the problem you're seeing
is, without referring to the implementation / code at all.

You should also mention why changing the code flow for LOOPBACK is safe
as it's not visible in the patch itself. And I think the subject should
be more broad than just GRE, since you also fix SIT.

Similar comments to a smaller extent for the second patch.

When you repost please make a fresh thread.