Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C5DC54E94 for ; Wed, 25 Jan 2023 03:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234486AbjAYD2u (ORCPT ); Tue, 24 Jan 2023 22:28:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjAYD2r (ORCPT ); Tue, 24 Jan 2023 22:28:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16A3CCDE1; Tue, 24 Jan 2023 19:28:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1215B81891; Wed, 25 Jan 2023 03:28:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B8AFC433EF; Wed, 25 Jan 2023 03:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674617289; bh=pLxuGuWkccGl+3mFDrpQRG+awrUGbY9Q74QPWO25ak4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p0Zc7D1uDkB+qqUqa023lG7O4aRym5yv4DUb1UU6ppMbs2Qa9hzNyDT3WtC/YL6j+ BbCZQsF13tk+D8UA+/QvKcooFSIQPrw67fSBy72kLurfRAcypSsxVvKRnruAOl0ZzS sAnzF1n5mJ7PNE/bgXcsI0kCBOYDUjyQVvzqCKT0UzjVeSlmPjBzz9oimZF4MeDxHa rMZVfOsqihjgn/PXUudywNOSX0Yc0z3H2nPTascMLPejWAGXqVXfSzB1t1tc7sDJ7Q /IuylX6XasHzVSrJPn34uJRpZzJcX2JLJGFXmqdEiW7klfwtC2Xw9H5SquEiO6dyJ0 fDmlZOPt5Rx+w== Date: Tue, 24 Jan 2023 19:28:08 -0800 From: Jakub Kicinski To: Thomas Winter Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, pabeni@redhat.com, edumazet@google.com, a@unstable.cc, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses Message-ID: <20230124192808.056cf9e8@kernel.org> In-Reply-To: <20230124032105.79487-1-Thomas.Winter@alliedtelesis.co.nz> References: <20230124032105.79487-1-Thomas.Winter@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jan 2023 16:21:01 +1300 Thomas Winter wrote: > For our point-to-point GRE tunnels, they have IN6_ADDR_GEN_MODE_NONE > when they are created then we set IN6_ADDR_GEN_MODE_EUI64 when they > come up to generate the IPv6 link local address for the interface. > Recently we found that they were no longer generating IPv6 addresses. > > Also, non-point-to-point tunnels were not generating any IPv6 link > local address and instead generating an IPv6 compat address, > breaking IPv6 communication on the tunnel. > > These failures were caused by commit e5dd729460ca and this patch set > aims to resolve these issues. Ah, you have the problem statement here. It needs to go into the patches, I'm afraid. The cover letters are not as visible in-tree and certainly don't make it to stable trees.