Mime-Version: 1.0
Subject: RE: [PATCH] PM / devfreq: Fix build issues with devfreq disabled
Reply-To: myungjoo.ham@samsung.com
Sender: MyungJoo Ham <myungjoo.ham@samsung.com>
From:   MyungJoo Ham <myungjoo.ham@samsung.com>
To:     Rob Clark <robdclark@gmail.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "freedreno@lists.freedesktop.org" <freedreno@lists.freedesktop.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Clark <robdclark@chromium.org>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Chia-I Wu <olvaffe@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
In-Reply-To: <20230123153745.3185032-1-robdclark@gmail.com>
Message-ID: <20230125040403epcms1p1646e9668b87df3e9c344ad58d39b6eb6@epcms1p1>
Date:   Wed, 25 Jan 2023 13:04:03 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20230123153745.3185032-1-robdclark@gmail.com>
        <CGME20230123153745epcas1p17e57cf83ed371e86258139473befc615@epcms1p1>
Precedence: bulk

>Sender : Rob Clark=C2=A0<robdclark=40gmail.com>=0D=0A>Date=20:=202023-01-2=
4=2000:37=20(GMT+9)=0D=0A>Title=20:=20=5BPATCH=5D=20PM=20/=20devfreq:=20Fix=
=20build=20issues=20with=20devfreq=20disabled=0D=0A>=C2=A0=0D=0A>From:=20Ro=
b=20Clark=20<robdclark=40chromium.org>=0D=0A>=0D=0A>The=20existing=20no-op=
=20shims=20for=20when=20PM_DEVFREQ=20(or=20an=20individual=20governor)=0D=
=0A>only=20do=20half=20the=20job.=20=C2=A0The=20governor=20specific=20confi=
g/tuning=20structs=20need=0D=0A>to=20be=20available=20to=20avoid=20compile=
=20errors=20in=20drivers=20using=20devfreq.=0D=0A>=0D=0A>Fixes:=206563f60f1=
4cb=20(=22drm/msm/gpu:=20Add=20devfreq=20tuning=20debugfs=22)=0D=0A>Signed-=
off-by:=20Rob=20Clark=20<robdclark=40chromium.org>=0D=0A=0D=0ADoesn't=20thi=
s=20imply=20that=20DRM_MSM=20should=20depend=20on=20PM_DEVFREQ=20?=0D=0A=0D=
=0AIt=20appears=20that=20gpu/drm/msm/DRM_MSM=20uses=20PM_DEVFREQ=20without=
=20actually=0D=0Adeclaring=20the=20dependency=20on=20PM_DEVFREQ.=0D=0AYou=
=20cannot=20use=20SIMPLE_ONDEMAND=20without=20DEVFREQ.=0D=0A=0D=0ACheers,=
=0D=0AMyungJoo=0D=0A=0D=0A>---=0D=0A>Assuming=20this=20doesn't=20conflict=
=20with=20anything=20else=20landing=20via=20another=0D=0A>tree,=20an=20a-b=
=20to=20land=20this=20via=20drm/msm-next=20would=20let=20us=20un-break=20bu=
ilds.=0D=0A>(And=20also=20start=20removing=20=22select=20DEVFREQ_GOV_SIMPLE=
_ONDEMAND=22s=20added=20in=0D=0A>various=20places=20to=20try=20to=20work=20=
around=20this=20issue.)=0D=0A>=0D=0A>=20include/linux/devfreq.h=20=7C=207=
=20++-----=0D=0A>=201=20file=20changed,=202=20insertions(+),=205=20deletion=
s(-)=0D=0A>=0D=0A>diff=20--git=20a/include/linux/devfreq.h=20b/include/linu=
x/devfreq.h=0D=0A>index=204dc7cda4fd46..7fd704bb8f3d=20100644=0D=0A>---=20a=
/include/linux/devfreq.h=0D=0A>+++=20b/include/linux/devfreq.h=0D=0A>=40=40=
=20-273,8=20+273,8=20=40=40=20void=20devm_devfreq_unregister_notifier(struc=
t=20device=20*dev,=0D=0A>=20struct=20devfreq=20*devfreq_get_devfreq_by_node=
(struct=20device_node=20*node);=0D=0A>=20struct=20devfreq=20*devfreq_get_de=
vfreq_by_phandle(struct=20device=20*dev,=0D=0A>=20=C2=A0=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0const=20char=20*phandle_nam=
e,=20int=20index);=0D=0A>+=23endif=20/*=20CONFIG_PM_DEVFREQ=20*/=0D=0A>=C2=
=A0=0D=0A>-=23if=20IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)=0D=0A>=20=
/**=0D=0A>=20=C2=A0*=20struct=20devfreq_simple_ondemand_data=20-=20=60=60vo=
id=20*data=60=60=20fed=20to=20struct=20devfreq=0D=0A>=20=C2=A0*=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0and=20devfreq_add_device=0D=0A>=40=40=20-292,9=20+2=
92,7=20=40=40=20struct=20devfreq_simple_ondemand_data=20=7B=0D=0A>=20=C2=A0=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0unsigned=20int=20upthreshold;=0D=0A>=20=C2=
=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0unsigned=20int=20downdifferential;=0D=
=0A>=20=7D;=0D=0A>-=23endif=0D=0A>=C2=A0=0D=0A>-=23if=20IS_ENABLED(CONFIG_D=
EVFREQ_GOV_PASSIVE)=0D=0A>=20enum=20devfreq_parent_dev_type=20=7B=0D=0A>=20=
=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0DEVFREQ_PARENT_DEV,=0D=0A>=20=C2=A0=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0CPUFREQ_PARENT_DEV,=0D=0A>=40=40=20-337,9=
=20+335,8=20=40=40=20struct=20devfreq_passive_data=20=7B=0D=0A>=20=C2=A0=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20notifier_block=20nb;=0D=0A>=20=C2=A0=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20list_head=20cpu_data_list;=0D=0A>=
=20=7D;=0D=0A>-=23endif=0D=0A>=C2=A0=0D=0A>-=23else=20/*=20=21CONFIG_PM_DEV=
FREQ=20*/=0D=0A>+=23if=20=21defined(CONFIG_PM_DEVFREQ)=0D=0A>=20static=20in=
line=20struct=20devfreq=20*devfreq_add_device(struct=20device=20*dev,=0D=0A=
>=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20devfreq_dev_profile=20*prof=
ile,=0D=0A>=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0const=20char=20*governor_na=
me,=0D=0A>--=20=0D=0A>2.38.1=0D=0A>=0D=0A