Mime-Version: 1.0
Subject: RE: Re: [PATCH] PM / devfreq: Fix build issues with devfreq
 disabled
Reply-To: myungjoo.ham@samsung.com
Sender: MyungJoo Ham <myungjoo.ham@samsung.com>
From:   MyungJoo Ham <myungjoo.ham@samsung.com>
To:     Rob Clark <robdclark@gmail.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
CC:     "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "freedreno@lists.freedesktop.org" <freedreno@lists.freedesktop.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Clark <robdclark@chromium.org>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chia-I Wu <olvaffe@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
In-Reply-To: <CAF6AEGud-ESF=VgcaSFzKsWas0H5eSXZDdZGcnd8Ju=pr-W2EQ@mail.gmail.com>
Message-ID: <20230125054626epcms1p38d34dc65cbc9cb29dd707a4b2cac8fb4@epcms1p3>
Date:   Wed, 25 Jan 2023 14:46:26 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CAF6AEGud-ESF=VgcaSFzKsWas0H5eSXZDdZGcnd8Ju=pr-W2EQ@mail.gmail.com>
        <20230123153745.3185032-1-robdclark@gmail.com>
        <20230125040403epcms1p1646e9668b87df3e9c344ad58d39b6eb6@epcms1p1>
        <CGME20230123153745epcas1p17e57cf83ed371e86258139473befc615@epcms1p3>
Precedence: bulk

>On Tue, Jan 24, 2023 at 8:04 PM MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
>>
>> >Sender : Rob Clark <robdclark@gmail.com>
>> >Date : 2023-01-24 00:37 (GMT+9)
>> >Title : [PATCH] PM / devfreq: Fix build issues with devfreq disabled
>> >
>> >From: Rob Clark <robdclark@chromium.org>
>> >
>> >The existing no-op shims for when PM_DEVFREQ (or an individual governor)
>> >only do half the job.  The governor specific config/tuning structs need
>> >to be available to avoid compile errors in drivers using devfreq.
>> >
>> >Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs")
>> >Signed-off-by: Rob Clark <robdclark@chromium.org>
>>
>> Doesn't this imply that DRM_MSM should depend on PM_DEVFREQ ?
>>
>> It appears that gpu/drm/msm/DRM_MSM uses PM_DEVFREQ without actually
>> declaring the dependency on PM_DEVFREQ.
>> You cannot use SIMPLE_ONDEMAND without DEVFREQ.
>
>Possibly that would resolve some issues, and that might have been my
>mistake in assuming that depending on SIMPLE_ONDEMAND implied a
>dependency on DEFREQ (which seems like a reasonable assumption, IMHO)
>
>But AFAICT some kernel configs that could otherwise use DRM_MSM don't
>support PM_DEVFREQ.. either way, lets solve this properly and remove
>needless dependencies on devfreq.
>
>BR,
>-R

Ok. You are enabling struct and enum only and that looks harmless.

PTAL, Chanwoo.

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Cheers,
MyungJoo.