Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ACB5C27C76 for ; Wed, 25 Jan 2023 06:29:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234565AbjAYG26 (ORCPT ); Wed, 25 Jan 2023 01:28:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231563AbjAYG24 (ORCPT ); Wed, 25 Jan 2023 01:28:56 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D62E2F798; Tue, 24 Jan 2023 22:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b1wjOqEZrpOkxHT+1PUvP0AOFeUjYZhKlkU4+S4GB0k=; b=uWEY9WMexKz+9xXeSpSQQ77B2o 99rw7YhSRvN4STq0JUdr1YPOz1RTSI6lFRUkjHzXPhv9DNY0z7KCO5yJmpxrSjczZqWbxgUkf0Pw9 GMIdHLsKmuuIafYwCktI02lb7llqnzyaZU851zyBR8gHrR9zteVmmiBsMq+q55KoTZwB8OsmrIaIQ 60QEZpmO3lI+1Jbk4ELfJVMYSO5Zgltk0/wwh93FqQ2ey2wb37YuqNtK2d9wfw5sUcGdyawPH7xQn jZ9wN+v4XxzvT0XYFzZKG9JU1UqJtxv5NOYsuUx9jVXo34t7QXr01IXmWHt08kO+d1PEtxagOao9I cyklzP9A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKZGv-0067kk-0n; Wed, 25 Jan 2023 06:28:37 +0000 Date: Tue, 24 Jan 2023 22:28:37 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Message-ID: References: <20230124170108.1070389-1-dhowells@redhat.com> <20230124170108.1070389-4-dhowells@redhat.com> <1296569.1674592913@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1296569.1674592913@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 08:41:53PM +0000, David Howells wrote: > Christoph Hellwig wrote: > > > On Tue, Jan 24, 2023 at 05:01:03PM +0000, David Howells wrote: > > > ZERO_PAGE can't go away, no need to hold an extra reference. > > > > > > Signed-off-by: David Howells > > > Reviewed-by: David Hildenbrand > > > > If you send this on this needs your signoff as well, btw. > > Um. You quoted my signoff. Do you mean your signoff? Umm, I'm confused because you had my signoff on the last version :) The patch is ok as-is.