Message-ID: <5b4bf72e-37e5-0840-cacb-df3873c3a5c9@linaro.org>
Date:   Wed, 25 Jan 2023 08:36:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH v2 03/14] ARM: dts: broadcom: bcmbca: Add spi controller
 node
Content-Language: en-US
To:     William Zhang <william.zhang@broadcom.com>,
        Linux SPI List <linux-spi@vger.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc:     tomer.yacoby@broadcom.com, kursad.oney@broadcom.com,
        dregan@mail.com, f.fainelli@gmail.com, anand.gore@broadcom.com,
        jonas.gorski@gmail.com, dan.beygelman@broadcom.com,
        joel.peshkin@broadcom.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230124221218.341511-1-william.zhang@broadcom.com>
 <20230124221218.341511-4-william.zhang@broadcom.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230124221218.341511-4-william.zhang@broadcom.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/01/2023 23:12, William Zhang wrote:
> Add support for HSSPI controller in ARMv7 chip dts files.
> 
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> 
> ---
> 
> Changes in v2:
> - Update compatible string with SoC model number, controller version
>   info and bcmbca fall back name
> - Add interrupt property
> 
>  arch/arm/boot/dts/bcm47622.dtsi    | 19 +++++++++++++++++++
>  arch/arm/boot/dts/bcm63138.dtsi    | 19 +++++++++++++++++++
>  arch/arm/boot/dts/bcm63148.dtsi    | 19 +++++++++++++++++++
>  arch/arm/boot/dts/bcm63178.dtsi    | 20 ++++++++++++++++++++
>  arch/arm/boot/dts/bcm6756.dtsi     | 20 ++++++++++++++++++++
>  arch/arm/boot/dts/bcm6846.dtsi     | 19 +++++++++++++++++++
>  arch/arm/boot/dts/bcm6855.dtsi     | 20 ++++++++++++++++++++
>  arch/arm/boot/dts/bcm6878.dtsi     | 20 ++++++++++++++++++++
>  arch/arm/boot/dts/bcm947622.dts    |  4 ++++
>  arch/arm/boot/dts/bcm963138.dts    |  4 ++++
>  arch/arm/boot/dts/bcm963138dvt.dts |  4 ++++
>  arch/arm/boot/dts/bcm963148.dts    |  4 ++++
>  arch/arm/boot/dts/bcm963178.dts    |  4 ++++
>  arch/arm/boot/dts/bcm96756.dts     |  4 ++++
>  arch/arm/boot/dts/bcm96846.dts     |  4 ++++
>  arch/arm/boot/dts/bcm96855.dts     |  4 ++++
>  arch/arm/boot/dts/bcm96878.dts     |  4 ++++
>  17 files changed, 192 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm47622.dtsi b/arch/arm/boot/dts/bcm47622.dtsi
> index f4b2db9bc4ab..6de4a2287c90 100644
> --- a/arch/arm/boot/dts/bcm47622.dtsi
> +++ b/arch/arm/boot/dts/bcm47622.dtsi
> @@ -88,6 +88,12 @@ uart_clk: uart-clk {
>  			clock-div = <4>;
>  			clock-mult = <1>;
>  		};
> +
> +		hsspi_pll: hsspi-pll {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +			clock-frequency = <200000000>;
> +		};
>  	};
>  
>  	psci {
> @@ -119,6 +125,19 @@ bus@ff800000 {
>  		#size-cells = <1>;
>  		ranges = <0 0xff800000 0x800000>;
>  
> +		hsspi: spi@1000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "brcm,bcm47622-hsspi", "brcm,bcmbca-hsspi-v1.0",
> +						 "brcm,bcmbca-hsspi";

Several of your lines are not properly indented/aligned.

Best regards,
Krzysztof