From:   "Li, Xin3" <xin3.li@intel.com>
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>,
        "H. Peter Anvin" <hpa@zytor.com>
CC:     "Hansen, Dave" <dave.hansen@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        Brian Gerst <brgerst@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Shuah Khan <shuah@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        "Lutomirski, Andy" <luto@kernel.org>,
        x86 Mailing List <x86@kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Linux Kselftest Mailing List 
        <linux-kselftest@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v5 0/2] sysret_rip update for the Intel FRED
 architecture
Thread-Topic: [RFC PATCH v5 0/2] sysret_rip update for the Intel FRED
 architecture
Thread-Index: AQHZMHAoqvs/lwdyjkiVXoNdsc7iCK6uxqlQ
Date:   Wed, 25 Jan 2023 08:22:48 +0000
Message-ID: <SA1PR11MB67345C4DFEE720C08D30D93DA8CE9@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <b6e36a5c-6f5e-eda6-54ad-a0c20eb00402@intel.com>
 <25b96960-a07e-a952-5c23-786b55054126@zytor.com>
 <fb1cab9f-a373-38e6-92e6-456332010653@gnuweeb.org>
 <6cd0db14-c9e2-3598-fd10-4b473d78c373@citrix.com>
 <5ecc383c-621b-57d9-7f6d-d63496fca3b3@zytor.com>
 <20230124022729.596997-1-ammarfaizi2@gnuweeb.org>
 <20230124022729.596997-3-ammarfaizi2@gnuweeb.org>
 <ce25e53f-91d4-d793-42a5-036d6bce0b4c@zytor.com>
 <Y899kHYbz32H1S6a@biznet-home.integral.gnuweeb.org>
 <BC632CA8-D2CB-4781-82E5-9810347293B0@zytor.com>
 <Y8+hGxVpgFVcm15g@biznet-home.integral.gnuweeb.org>
 <20230125034958.734527-1-ammarfaizi2@gnuweeb.org>
In-Reply-To: <20230125034958.734527-1-ammarfaizi2@gnuweeb.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I7Nc550ZepVSmW0MjTXdtvTofsPHV2MNdckw8Dcl0VDPe7Fj+X+UcjpT4bUs?=
 =?us-ascii?Q?O47NBUlPSF7jZ5K7kaTcAeSz9ZWoF0tLe01HfSYTCYSALzt9QQWGa/Q13pNs?=
 =?us-ascii?Q?gKF8Bl4lHeWYaCGy/p+Fdz5bi0wIrgyOtcR7eV6/i6VxN959zHH5dbsXxH/j?=
 =?us-ascii?Q?R8SbGO0KwXVePEKswGLLGSs2Fo6jeSZ4jBGOBeT5hGd5HMXoE91fRXRmiKuM?=
 =?us-ascii?Q?mOmCMh572I12gQUF1SsWQX+hx70t7o864DlYCvMYqvlkyR9S4D0qzaKB17pK?=
 =?us-ascii?Q?luTzPp7SsF1Xn2/W/hyfpZ6i8yF2qToHZ5N7B4sjFiiAnXQHUntSeoJ2b+YQ?=
 =?us-ascii?Q?PSl1CfdlLLFGuMogP6gKTU04yx6QViqFgDfydpFlnehyzJMmSIEESAoQtabE?=
 =?us-ascii?Q?oS9DQxqiyVRTfk6BMtRuSaeWc4W7i5tZPt4LS6UR34+A4tX0OKDU8lMFBrUf?=
 =?us-ascii?Q?JZ35ZUqdyr1BGdG4II0IAX00ZGI4f2rC/7xwR71INXLQOFIaiJMyi9D3kUjG?=
 =?us-ascii?Q?3qbmlBeuCIViXnoU6LN6SipuEE+xoMXI2aXSvfH2GFSCaxFpb8/iXKzwz1QN?=
 =?us-ascii?Q?eQ+IhDLKS24MID+sM7drd6xAPluRsPhmYbzEL8gQ/M3ZLTTYvSLh7OCn/24T?=
 =?us-ascii?Q?qK7kTAd9QIA0y9cIGtuOeV3r63ak0HtyM8qos4619P9P20yxZOZE0rXlRCOk?=
 =?us-ascii?Q?tjfSnVnd7e70DKc80QxzSfsdRcUhk7+tJAr2zCZ71FS6SClcwaCaOaS6h8XJ?=
 =?us-ascii?Q?IJc4qY3NxLLj2wwR0owmETSWxlMty3aTICQ9RLkhl5vxz8BT3aRrVvMYO7NW?=
 =?us-ascii?Q?Kv4y7eYso22ctrtgBelt+3p5r7U2J4ySfplZHb/op44HTdGSBR1zYD/XFdkC?=
 =?us-ascii?Q?59Sv3qCOWG8RPIwvQxsT0VOcm02opRYnbJ04ePBKCDINr3MzsCOlmxGi4nDS?=
 =?us-ascii?Q?gWv2hg2sAS5Xlc//XGZjHWUYqckmyP6RM1aL210Aibh6XXmmN0LjJS1zN6pB?=
 =?us-ascii?Q?ljODnits3i8VWXS4P6gPb1QiqymlaQgA7tLeTPEQTNgKhAJV8DEJwfV2qaCx?=
 =?us-ascii?Q?fxFV7KgPBaeqp0E7FffGuVo+YXrb3UNpntzBJ2Eo7nF0z3USVJspSxfwPXrL?=
 =?us-ascii?Q?YYg9LPyazkYI75zzuU73P22kAm5AsubivVk6oTEOLhupQyjtAeyKSx4Qhbv3?=
 =?us-ascii?Q?SE5+7YAS0SEA8sbGWBZ2IgaHm+zhjym9nkQfqxMc80Q/PhMtg5TFAFqclCgI?=
 =?us-ascii?Q?HoVPayC4dBuaNIzyKGBCRn5OLRZWDY0wsuKY/o2gw3ftmazcxvyfq/JjBUXZ?=
 =?us-ascii?Q?FePm3b/SONF7Piz06ysZPkFbGjpesAKLMnvmbDcDTWhqktwFnmzEJK1gbFlR?=
 =?us-ascii?Q?WSHDLiKwqdxXvBLMd4JAaN9nb13xzuHdPKKuCUVerzg5udye0bFkPSy+PRJd?=
 =?us-ascii?Q?S8/WReb3TwGlHXRbFK8P0U1VHmSnK893tjVGt5wuEJs/jOl4hvgN6ta5XXQT?=
 =?us-ascii?Q?eb1mrFCAZvt824GCtVd4AhBj/ExMORvkc5aNh8HnHsPdV3bZOUKa/w+GZUnG?=
 =?us-ascii?Q?a408IbZBmwCFzJJMULfZz4E5TlNFqtYAbSWaNeOS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d0f53e-6430-40cb-56c3-08dafead5842
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2023 08:22:48.9261
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Frqt8MIaglxEPjy9CQ3Kzt0O+8SlP9UhD+B/1OcmOcrH2buHvuP5ER3VDZn0oBbiVf0wWTjYcQEVev2yP9AEMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6200
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This version passes on FRED, thanks a lot for quickly fixing it.

  Xin

> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>=20
> This is an RFC patchset v5. There are two patches in this series.
>=20
> Xin Li reported that the sysret_rip test fails at:
>=20
>         assert(ctx->uc_mcontext.gregs[REG_EFL] =3D=3D
>                ctx->uc_mcontext.gregs[REG_R11]);
>=20
> on the Intel FRED architecture. Let's handle the FRED system scenario too=
. The
> 'syscall' instruction in a FRED system doesn't set %rcx=3D%rip and %r11=
=3D%rflags.
>=20
> Syscall and sysenter in a FRED system are treated equivalently to softwar=
e
> interrupts, e.g. INT 0x80. They do not modify any registers.
>=20
> Link: https://lore.kernel.org/lkml/5d4ad3e3-034f-c7da-d141-
> 9c001c2343af@intel.com
>=20
> #### Changelog v5:
>=20
>    - Fix do_syscall() return value (Ammar).
>=20
> #### Changelog v4:
>=20
>    - Fix the assertion condition inside the SIGUSR1 handler (Xin Li).
>=20
>    - Explain the purpose of patch #2 in the commit message (HPA).
>=20
>    - Update commit message (Ammar).
>=20
>    - Repeat test_syscall_rcx_r11_consistent() 32 times to be more sure
>      that the result is really consistent (Ammar).
>=20
> #### Changelog v3:
>=20
>    - Test that we don't get a mix of REGS_SAVED and REGS_SYSRET,
>      which is a major part of the point (HPA).
>=20
> #### Changelog v2:
>=20
>    - Use "+r"(rsp) as the right way to avoid redzone problems
>      per Andrew's comment (HPA).
>=20
>=20
> Co-developed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---
>=20
> Ammar Faizi (2):
>   selftests/x86: sysret_rip: Handle syscall in a FRED system
>   selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx=
` and `%r11`
>=20
>  tools/testing/selftests/x86/sysret_rip.c | 146 +++++++++++++++++++++--
>  1 file changed, 137 insertions(+), 9 deletions(-)
>=20
>=20
> base-commit: e12ad468c22065a2826b2fc4c11d2113a7975301
> --
> Ammar Faizi