Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEB1C54EED for ; Wed, 25 Jan 2023 08:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235031AbjAYI3h (ORCPT ); Wed, 25 Jan 2023 03:29:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235030AbjAYI3e (ORCPT ); Wed, 25 Jan 2023 03:29:34 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E57871632B for ; Wed, 25 Jan 2023 00:29:32 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKb9p-0006lm-82; Wed, 25 Jan 2023 09:29:25 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pKb9m-00034W-Gv; Wed, 25 Jan 2023 09:29:22 +0100 Date: Wed, 25 Jan 2023 09:29:22 +0100 From: Sascha Hauer To: Michael Riesch Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Sandy Huang , David Airlie , Daniel Vetter Subject: Re: [PATCH v3 0/6] drm/rockchip: vop2: add support for the rgb output block Message-ID: <20230125082922.GZ24755@pengutronix.de> References: <20230124054706.3921383-1-michael.riesch@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230124054706.3921383-1-michael.riesch@wolfvision.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 06:47:00AM +0100, Michael Riesch wrote: > Hi all, > > This series adds support for the RGB output block that can be found in the > Rockchip Video Output Processor (VOP) 2. Version 2 of this series > incorporates the feedback by Dan Carpenter and Sascha Hauer. Version 3 > fixes a dumb mistake pointed out by Sascha :-) Thanks for your comments! > > Patches 1-4 clean up the code and make it more general. > > Patch 5 activates the support for the RGB output block in the VOP2 driver. > > Patch 6 adds pinctrls for the 16-bit and 18-bit RGB data lines. > > Tested on a custom board featuring the RK3568 SoC with a 18-bit RGB > display. > > Looking forward to your comments! For the series: Reviewed-by: Sascha Hauer Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |