Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12671C54E94 for ; Wed, 25 Jan 2023 08:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235215AbjAYIfJ (ORCPT ); Wed, 25 Jan 2023 03:35:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234980AbjAYIfF (ORCPT ); Wed, 25 Jan 2023 03:35:05 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F9D5EC41 for ; Wed, 25 Jan 2023 00:34:59 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5A4A21F3F; Wed, 25 Jan 2023 08:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674635697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4pD6a1vgMmjem91hgO9Kz33HyqN716ma2eR4HQMVYA0=; b=OxrVfJWC87cy+y6BoUA/nMDRFcdVUAHuPxKe+V4fT7rqYCzcT7TX0tg32/CrpG7LNKtu6G WQkGXES8vt/8dy5RObel4J3N60PfGw+6+1LtfOOM53OhKLzQ1ZYR7IZhx2SacMPD7AJQai JKwwwd+oxzMy2Tnl48r5wyx6G1DQtWM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674635697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4pD6a1vgMmjem91hgO9Kz33HyqN716ma2eR4HQMVYA0=; b=i+41ZHk6O15m/Kk0tgmWrLw3GWqlb8dqX8pvSW8RBZxRluy6pLrnr/kkZUlHcc/VWAJ2q5 2cpWirR+IF6uJOAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9F3921339E; Wed, 25 Jan 2023 08:34:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Uvf9JbHp0GN0ewAAMHmgww (envelope-from ); Wed, 25 Jan 2023 08:34:57 +0000 Date: Wed, 25 Jan 2023 09:34:56 +0100 Message-ID: <871qnjdnbj.wl-tiwai@suse.de> From: Takashi Iwai To: Dawei Li Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: ac97: make remove callback of ac97 driver void returned In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Jan 2023 16:13:49 +0100, Dawei Li wrote: > > Since commit fc7a6209d571 ("bus: Make remove callback return void") > forces bus_type::remove be void-returned, it doesn't make much sense > for any bus based driver implementing remove callbalk to return > non-void to its caller. > > As such, change the remove function for ac97 based drivers to return > void. > > Signed-off-by: Dawei Li Applied now, thanks. Takashi