Date:   Wed, 25 Jan 2023 11:33:11 +0300
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     "Arnd Bergmann" <arnd@arndb.de>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Hartley Sweeten" <hsweeten@visionengravers.com>,
        "Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
        "Russell King" <linux@armlinux.org.uk>,
        "Lukasz Majewski" <lukma@denx.de>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT
Message-ID: <20230125113311.2aff259d@redslave.neermore.group>
In-Reply-To: <a699e52a-db19-4374-a4bc-a3948ecc43ef@app.fastmail.com>
References: <20230117100845.16708-1-nikita.shubin@maquefel.me>
        <a699e52a-db19-4374-a4bc-a3948ecc43ef@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Arnd!

On Tue, 17 Jan 2023 11:15:20 +0100
"Arnd Bergmann" <arnd@arndb.de> wrote:

> On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote:
> 
> > 
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id ep93xx_gpio_match[] = {
> > +	{ .compatible = "cirrus,ep93xx-gpio" },
> > +	{ /* end of table */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
> > +#endif
> > +
> >  static struct platform_driver ep93xx_gpio_driver = {
> >  	.driver		= {
> >  		.name	= "gpio-ep93xx",
> > +		.of_match_table = ep93xx_gpio_match,
> >  	},
> >  	.probe		= ep93xx_gpio_probe,  
> 
> The #ifdef here is wrong and will cause a build failure because
> of the unconditional reference to the variable.
> 
> Just remove the #ifdef/#endif.

Sorry about that - i remember that i should drop it everywhere, which
did for all but ep93xx-gpio, i am dropping match currently, as it will
produce a warning without dt-bindings documentation, it will be
introduced together with the rest of series.

> 
>     Arnd