Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A5FC54EED for ; Wed, 25 Jan 2023 09:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234163AbjAYJF2 (ORCPT ); Wed, 25 Jan 2023 04:05:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjAYJFZ (ORCPT ); Wed, 25 Jan 2023 04:05:25 -0500 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20632359F for ; Wed, 25 Jan 2023 01:05:24 -0800 (PST) Received: by mail-qt1-f169.google.com with SMTP id v19so2834505qtq.13 for ; Wed, 25 Jan 2023 01:05:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WIjm+2b9784FIlk5/vMb5ebIJycD5NpJAeSWiCQNE0M=; b=Z7EIY/VD92vUhBH4xAu7MrM5r2gO85/XKm5Tk2oDBBsuu1OjPbQqgjtEue2R59vUXM 4tdT+W7dFR4MkUoycVfYtDus2e4NHHeT/DJjhav62zGt8Xofvt22ImaDP1B6i/Ay8Er+ UwXQnB99WrieWJYs/ei3D15pDkj/R7o18VEiiTyfRf4N11v1H+XFeK+W42xOgJtP1s2o 0AfH+yZ9Bp2h7SVNkMpsab1A82Kgg6i9kwRk7t8u6esXkH06rkHFOhWLifgFEiPmqui2 ac8zZ7EjC562ebWvDhbskLqowdtmnSJQdMP7M6bDSMfIV9XfKV3cB+xbzoXeGmrrXWR4 RTfw== X-Gm-Message-State: AFqh2kqWJKr58BQ9ZUHVPurBzJQvv6+GTQFeWwo0tvOsKYvpWt5igoNI +DI3OtCQzb/wzsGBPTBH2GW7gRHMfOQQ6g== X-Google-Smtp-Source: AMrXdXvcfsCGlIrSME2grFHg6lQQvA7wYGM+MIqTyd4i+gnFZEyXrVvXwhWhKnxCcDv1HCR6lGKrLA== X-Received: by 2002:a05:622a:190:b0:3b7:ec70:30af with SMTP id s16-20020a05622a019000b003b7ec7030afmr12871798qtw.46.1674637522855; Wed, 25 Jan 2023 01:05:22 -0800 (PST) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id 72-20020a370a4b000000b006fcc3858044sm3138046qkk.86.2023.01.25.01.05.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 01:05:22 -0800 (PST) Received: by mail-yb1-f179.google.com with SMTP id d132so633082ybb.5 for ; Wed, 25 Jan 2023 01:05:22 -0800 (PST) X-Received: by 2002:a25:9ac1:0:b0:7b4:6a33:d89f with SMTP id t1-20020a259ac1000000b007b46a33d89fmr2454247ybo.543.1674637521998; Wed, 25 Jan 2023 01:05:21 -0800 (PST) MIME-Version: 1.0 References: <20230125083248.1305270-1-victor.liu@nxp.com> In-Reply-To: <20230125083248.1305270-1-victor.liu@nxp.com> From: Geert Uytterhoeven Date: Wed, 25 Jan 2023 10:05:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] driver: bus: simple-pm-bus: Add Freescale i.MX8qm/qxp CSR compatible strings To: Liu Ying Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-imx@nxp.com, Rob Herring , Lee Jones Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liu, On Wed, Jan 25, 2023 at 9:31 AM Liu Ying wrote: > Freescale i.MX8qm/qxp CSR module matches with what the simple power > managed bus driver does, considering it needs an IPG clock to be > enabled before accessing it's child devices, the child devices need > to be populated by the CSR module and the child devices' power > management operations need to be propagated to their parent devices. > Add the CSR module's compatible strings to simple_pm_bus_of_match[] > table to support the CSR module. > > Suggested-by: Rob Herring > Suggested-by: Lee Jones > Signed-off-by: Liu Ying Thanks for your patch! > --- > The CSR module's dt-binding documentation can be found at > Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml. > > Suggested by Rob and Lee in this thread: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221017075702.4182846-1-victor.liu@nxp.com/ > > drivers/bus/simple-pm-bus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bus/simple-pm-bus.c b/drivers/bus/simple-pm-bus.c > index 7afe1947e1c0..4a7575afe6c6 100644 > --- a/drivers/bus/simple-pm-bus.c > +++ b/drivers/bus/simple-pm-bus.c > @@ -120,6 +120,8 @@ static const struct of_device_id simple_pm_bus_of_match[] = { > { .compatible = "simple-mfd", .data = ONLY_BUS }, > { .compatible = "isa", .data = ONLY_BUS }, > { .compatible = "arm,amba-bus", .data = ONLY_BUS }, > + { .compatible = "fsl,imx8qm-lvds-csr", }, > + { .compatible = "fsl,imx8qxp-mipi-lvds-csr", }, I did read the thread linked above, and I still think you should just add "simple-pm-bus" to the compatible value in DTS, so no driver change is needed, cfr. Documentation/devicetree/bindings/bus/renesas,bsc.yaml. If that doesn't work due to DT binding constraints, the latter should be fixed. > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, simple_pm_bus_of_match); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds