From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Topic: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Index: AQHZK5c8rGsK9/3tnUGTuU9JLmjdZK6u4f1Q
Date:   Wed, 25 Jan 2023 09:09:11 +0000
Message-ID: <BYAPR11MB33670FA9442A0D4659824849FCCE9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-8-helgaas@kernel.org>
In-Reply-To: <20230118234612.272916-8-helgaas@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0wJqRlY2CHKWu+4JEFMcPIwi4jfr2D9h/Rh+5s4exSwIkTTWpnSdv5a2DmJc?=
 =?us-ascii?Q?exDw/IWT6kpBk4Ueofbq4+KkN/HnpeCpRh6/ih51IAx/Fwg1fVjMIcZNl9QM?=
 =?us-ascii?Q?+jvCI0SS7oh0Q0Ghy5QWU9Kd+7nKIExssd5lFlAo0JSKMFAUBd9ie5AhAXqm?=
 =?us-ascii?Q?GNktEm8r6ZEoCYJoSLRW4sFY6i1RGl786/vbL6RLa+C6AanITg7+7GiQ3t/L?=
 =?us-ascii?Q?MuJL503IxxLrAoVU7kWbXIa8HeS3myRW5D8uYZpJHkRsgl9xRKRQ4XOLm+92?=
 =?us-ascii?Q?HTYDS5sDh5xEWtArt0OnatkPggv1l0fPv3vLKbZhaC6nEJlVNTGozFGIcqVw?=
 =?us-ascii?Q?/rZ9zoPlmoB7lBkbYFdhuwiXGGGSHzv12Ze17ZQzXgjVubaKzhP7S3ALXsAo?=
 =?us-ascii?Q?UaS9/AlflxRiRkeldaTzqnWvXeNfGLbwwOAmRkDqjSgSpR9RkVe10Jc3scB2?=
 =?us-ascii?Q?GvTh7FU7Mn9AAl7bM+EZVBXf4w7UkBcSkPsEuAX/dlEFNw9wweOzaMoc1yB6?=
 =?us-ascii?Q?LQHdR6SlxfnES0FM64T0cLGaM5eEsmRFP1RzITCPUGS92RYzUVgHcxknQNvL?=
 =?us-ascii?Q?hQStHi5UgZTcqvJoA41eW9Yf21uWyqRrGm+wkcnieIGGHrklBEvbjLZr70uL?=
 =?us-ascii?Q?/a+kcdJiTnDGrgRKhONsb90XSwf/ZeLMTWmsUZ7qHpKmNH/sIo3cHGew7lFI?=
 =?us-ascii?Q?LikM5hQWtFTke3r6kXfkfy/iPSxBftsjwxlQISHVE7b5eR/brW6AezBW4MCh?=
 =?us-ascii?Q?jTYlYEw25L+1nG/kUKVjGpfV1fQsKXt47aX3UloIxUIUiOjD0/hWJzEkomTL?=
 =?us-ascii?Q?fZanYmNLlmEo1W5M9UOipTBCrNU+6fr9vz0ArhQy/3otvX1ml0D0mFHBZQBV?=
 =?us-ascii?Q?JInPhzRgYvN2eJZysGLMwaDKq9lT+UEpiavhhIbbcYs51yhRE2Esn5tvH8ZX?=
 =?us-ascii?Q?HaYSfmgPET7Dp03eO/Jg73+JIvtEGPY7cT6TLKaqIwV7pstzquhQYk5nbJfJ?=
 =?us-ascii?Q?JrTiOqoRx4XZmUpnwuWl/KEgX6r1x2t/vmgktAH+AyGHSyRPQOe5c9o4FSD/?=
 =?us-ascii?Q?oeYJEAQqLT7io1FYb3TRjKln4IKSAkhnOfeyIELz1wwg1rkfhFzYQzQOuFhK?=
 =?us-ascii?Q?5m3I/j0z2AdTl/ICEo+XU0eUN3s7LdHgd+x4/8N2HeHvDZaIMHMDda4tvK2u?=
 =?us-ascii?Q?j4QcMak9/4PY5uIDF/UPG/nDU1kLwcFbZo4QrsdsADr7ZRWN5NCWYf+YeEjY?=
 =?us-ascii?Q?Z830b0taxbcDYw1gndnaJ0C6Uo68P2LduhDpplnxUrnTppvwh7NALoyu+T7L?=
 =?us-ascii?Q?3xDxOWq4yuEsqKNcXi4RuI+p0L6/TCiSGFMXWWhNG/g5llwtVJJamRxd50fD?=
 =?us-ascii?Q?d99IjuS1+ut49FI39+CMwTnBY6Umrb87Tv3GxwwCXDBknq9d3tl1h3e4FDl6?=
 =?us-ascii?Q?bLvEGWkaFg9kiiRKZFwDbAXESZ+ywAElnZUFui90huQgexRkeEWHc/TFw8JL?=
 =?us-ascii?Q?n9JN0Te44E11rkiKI4a6Ed2Xm8x2Lz4Ne+HvipebIY6v25+Pk384jxeMtFLh?=
 =?us-ascii?Q?sJBiAUkffGiEzRIfgUZ0huFjRFzOLstAKMy6NUTz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44cf39d6-2ddb-4f61-0499-08dafeb3d298
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2023 09:09:11.1813
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ipPfmwu15LbvYO2URqWlx7UNPhqrhBMdak/FARUQJJH0izcMoHJIWVUnxWuTpID/EPHlZTuNjfrBol6XB2nBAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8154
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@vger.kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjo=
rn
> Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Subject: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant
> pci_enable_pcie_error_reporting()
>=20
> From: Bjorn Helgaas <bhelgaas@google.com>
>=20
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER =
is
> native"), the PCI core does this for all devices during enumeration.
>=20
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>=20
> Note that this doesn't control interrupt generation by the Root Port; tha=
t is
> controlled by the AER Root Error Command register, which is managed by th=
e
> AER service driver.
>=20
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)