From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH 6/9] ice: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Topic: [Intel-wired-lan] [PATCH 6/9] ice: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Index: AQHZK5dUsm1exHQ0Sk6PoM7isKTE366u4bkA
Date:   Wed, 25 Jan 2023 09:08:32 +0000
Message-ID: <BYAPR11MB3367CF0A00A1CE1B11A47D0CFCCE9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-7-helgaas@kernel.org>
In-Reply-To: <20230118234612.272916-7-helgaas@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nrnkKx+dotwZZXRuVxYdfzPzbjicAsZXWH0bqpi7fO5FfKW5vcd3kjzelD8o?=
 =?us-ascii?Q?WmrZLvFJcec1IC0Slbd+/H7aHvj64iFX8obeL6BimuGixTQOdSuv1o3RnvYZ?=
 =?us-ascii?Q?5YsPHw0mG5KNFCVmQ5PWe5IVePJjGwhqFxqpQq3hytfVOly81LrVpTfuuZSP?=
 =?us-ascii?Q?6CTNmjxPPvGJIl8UnYOqVU+1PHhTZPZp8ir4dK/+BdN199jfvPmIz1e+9x+6?=
 =?us-ascii?Q?8dcGdcmUoLqyWw32CjnB459jVhCFt5vUvqlCFZKnXtcew6xPKAG83T2JcL3Y?=
 =?us-ascii?Q?Y/rioPo+A2uwVM4JEif77UdE6EuwyzR/ogz0YtDAgT0lshPrzY/liS8q+lrJ?=
 =?us-ascii?Q?en+Gy7lgujQDgccx0M8+oWsf5wPrctP/t4sPbqH5QdE9Vdnvx1yI/H/Pk7hV?=
 =?us-ascii?Q?WhDe85fq+W1r7nStv7t3eIBIiqGdgeWEvTjpkOCKbM5tZVG5pagc3lVvdiB0?=
 =?us-ascii?Q?yoziv+uPjX5YQQuC0ndVwd0uSPvr9cx3sIf5eMTCLCf+HWhLMguq7Cix83LK?=
 =?us-ascii?Q?dYOOZri4Rame0/Hy3GyruccpN0ih/D+BPRHJeHtC8pPtSTHNAIfbP0eE+KXS?=
 =?us-ascii?Q?6ZtRSi2hhRjHsySxm7KZisuWpxlw6QeMsGBKdpThmE+2CY/9VEUaX+BVG17W?=
 =?us-ascii?Q?ny/4l2E6Jt4IBXXlH1EHdw1bTTzaIUyGbiYcP0q8zganW+G2A5zuwb+PSEVq?=
 =?us-ascii?Q?27JYcgHNpSPXi2tqfGGYa7negzFlNwn+yo5xfOHZsN8Lr0/ev7sAlBItAWF2?=
 =?us-ascii?Q?GXWlAj9zmGGvLpaSjgAR5LKN1Lpgz1rppJtCe8gJXU1sh+VoXbj+3JR+JAW5?=
 =?us-ascii?Q?VF/dpXs7jBf2R2ExCLCGl6FBJsALwWUzmxdAoJTYlQ/MaXIDKxGsJAA2yr00?=
 =?us-ascii?Q?PizrOdLuHkXDdbf3eDBfDEK4E57pUmcSznZVu5+rxdufwo+xjvoeLQEa7ujG?=
 =?us-ascii?Q?Md4TyR2Y1NBgwPSOt5/IdAhJxSqxUqzUrd/7pTlrkGx72MKZim4xeoa55i0f?=
 =?us-ascii?Q?KL5xDh6g55GfEm35BZY08yMYsicnh6krLmzJGOZwYywnSe0vqCG3UN5L0180?=
 =?us-ascii?Q?NGOHW6YVqe+khVyXP7kQChCAIrN7fl382O96FS54ZyFC2tdJj2dFN49bIh4m?=
 =?us-ascii?Q?/jqUhEWBPx9PRVtezE37DCBYgJxXcZ3KgX3Jy/eaZNhYo7WZkwNm1XBKXmZU?=
 =?us-ascii?Q?cyM0DMzGbUkd3ra1ZvM3HjoTxS0rW8uJ2wZzHjXXZvITI2T0zv03syisvKvP?=
 =?us-ascii?Q?msvtWbbH4ZuIjXWjxfjtXdwa8DqTSZAr1jIxTQ00IzmdCAxIm7FQrr3OQNj7?=
 =?us-ascii?Q?zREDYgSXUQrCUIeIE2OWhYzxpNyDmWPQhI3XCImtWVFWtNQq70eQahsn71yI?=
 =?us-ascii?Q?3agcNny7aNt1CEahYdkpGRgYW8S2QNxZiFbHxZcN0P8Ad/yEne1mWDkhzD+K?=
 =?us-ascii?Q?QW7kwq/mcoSktN38uc3m2tMNeltiTiuHXQyqJFSdm9siktt9lQx1OxeDRNkC?=
 =?us-ascii?Q?/cQVNA7KASuJKbktP7Uv3n5h9EEC3zEr5BVlECUM0YkiBtT9zQDJwkV4pFLQ?=
 =?us-ascii?Q?mHvJJr/ZeAxRx5lewv2vMMU4jjy0ImsAs5bqqxp1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d540928-43b7-4411-f621-08dafeb3bb8d
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2023 09:08:32.5121
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TKalavS5Gi4hugXDM9eanb5hbadoQp8VihTXNTZ8rCQ7nBbTfYxC7Mk9kTnvn09Y2+f/ShJ6DI7vdK2gg8uv1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8154
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@vger.kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjo=
rn
> Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Subject: [Intel-wired-lan] [PATCH 6/9] ice: Remove redundant
> pci_enable_pcie_error_reporting()
>=20
> From: Bjorn Helgaas <bhelgaas@google.com>
>=20
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER =
is
> native"), the PCI core does this for all devices during enumeration.
>=20
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>=20
> Note that this doesn't control interrupt generation by the Root Port; tha=
t is
> controlled by the AER Root Error Command register, which is managed by th=
e
> AER service driver.
>=20
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)