From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH 9/9] ixgbe: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Topic: [Intel-wired-lan] [PATCH 9/9] ixgbe: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Index: AQHZK5dL+2cRUCQxxkW3v/EjtMm2Ra6u4kkg
Date:   Wed, 25 Jan 2023 09:09:57 +0000
Message-ID: <BYAPR11MB3367AC0791822F3AAD3EECA3FCCE9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-10-helgaas@kernel.org>
In-Reply-To: <20230118234612.272916-10-helgaas@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ePW0Zu2d+v/etuM/g2d1rWTec0rB0R/BnyDO0/FPV/OAHHeDF/CP9jK6ZlbL?=
 =?us-ascii?Q?mD+01tHPMW6/iATKL6JwTj18KCNHybZBZ/I2CD6UEFaYpN6sUPsljgwLw5/o?=
 =?us-ascii?Q?A5Me6fYio65XErjX9/zntuLJwtCYoVsXX8i+DvAPj4P/rdwz/6RXmZloKdAL?=
 =?us-ascii?Q?h3AL8ar1P/N57mRB/yeYiizpuHIw7/SsopYfsiDbuL04mHhzZ+IzvCUpe53w?=
 =?us-ascii?Q?gsm256eSHZ+MyxjZmf7plkF50DqBMX+E5+BJNODVeSL0pzI0Jm0Lh8BeTJcV?=
 =?us-ascii?Q?V+r6qRAhotFr3Il5V5rUFn4UGfTTD7cza46FJ9853KZAdv0rPoEDOC8URFUs?=
 =?us-ascii?Q?OVmWRxtw12dhGKyZOpvtUkp3rdKwjwwXCDnbOG5R9X2zs4gBdLj3nGcas8MM?=
 =?us-ascii?Q?6q0DHfwGTVFpA4LUNkjleH3/Nj+zil/XrPLL3fmwnJYYgzlmq6jFj7IHhDPM?=
 =?us-ascii?Q?g43kWSK33Fn4WSg8r2TA/lOqxUQpQEBYOkCmBptxq+IOCWjcig9+Gmd6N4PM?=
 =?us-ascii?Q?rb2PThM29xtzpIM0CCMyp+M/hf7gxl0BeJrsW1lKKgLhLb1GSU+a+iJ/j14k?=
 =?us-ascii?Q?L8IdSuoEtaWLZtp7IUqwduht/39Rgi3qIiuJE1xW8DPZRdvxxTtBM9rCy6kS?=
 =?us-ascii?Q?/BZctBRno9m5Gbp7yiWlXCiC2ezEyHj94i2NTT95due5FKc2gG4TDPaaRFqc?=
 =?us-ascii?Q?We+8J4o2D+8iNKkcBG1PwQ65QTY1HYxP//hy9Rvlw05T4L3tnznvqDzTbZRs?=
 =?us-ascii?Q?3LUkBeObnKTyt9YktcaOTbkjy+HVbLX1/8d4keZNxIoos3iP41/wTuBB8zSh?=
 =?us-ascii?Q?18dsEMD7bnikvK9m9RibfbAHPeNSa8+MVYzeeM/wHitxqgu/GRk4CD7rxADv?=
 =?us-ascii?Q?BJusp0aFssfewrnAxgeOUkiIaTF7x911Xt0K2p/LEX0ZpDDIwlvRM4hg4fgC?=
 =?us-ascii?Q?qjVUJp66wwwCphs1Q+qJQfuvqH5447bJDxAHT9n9KJ9vs0NUNy8NHeYKX1sp?=
 =?us-ascii?Q?/1MtJWEJYQyhtlTcY0BkJYhh0u4DhNiv/N2mmCd0Q3QYDvra8bF2xHRaJSHr?=
 =?us-ascii?Q?uhk1ELmqVAkY167PVtUj83FZpX2baSZKHLTbq2uSxXRuX2HwkY8B9IJRhlSs?=
 =?us-ascii?Q?a3haH1CB0k1VXmFcmmcsgLqf/T5hqi86H+bmXMXBdA8PA3mYY7G4H/g2GlCJ?=
 =?us-ascii?Q?QdBfcGVq2arK26e8hTtYKWUcLoIQhyMqo5dMwMlhx6kO53ncnGpPXPKI1bnb?=
 =?us-ascii?Q?iu1rp3+vtHmg5EpmPQiUXhJdOHDh2DQCSlq6gP2cOt3Hi4pd0UlezKZl6OQ7?=
 =?us-ascii?Q?DwZRv2Fcvordx3bnfuvTT8TRQ7oddrSRHRG4v73/lML3us4U0Qc/v9ZKzNhk?=
 =?us-ascii?Q?pgwNE3kjX7vVrzQ+RVDUkrsqE0q0oLKGCBnL1lX6+cRwxdbQX2LvbY6CUqAn?=
 =?us-ascii?Q?LSgZp8oFmBYuV8h3Rv4b0cMqFbJvTWiOyt9jL6hRMwEQWriKrLsMS+1CEwEX?=
 =?us-ascii?Q?+V+LgrMUZ+OtGQxESYXHeEDgOog2/VH13K0iAErW1uFlGYiJhnksRSKx/u0N?=
 =?us-ascii?Q?fXMNdTMBtms6/umfux8Piin69PzuuqElaImmT+n1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d822cba9-d941-40f6-ff59-08dafeb3ee74
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2023 09:09:57.9280
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MMLP0ToEaSom4SfUJNbzH2MU0cSTjhrpGWsNzjX9GNhfNehjahCJ6pcCmT5c7TfiUvIJvrCI3ALESUVKwikyqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8154
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@vger.kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjo=
rn
> Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Subject: [Intel-wired-lan] [PATCH 9/9] ixgbe: Remove redundant
> pci_enable_pcie_error_reporting()
>=20
> From: Bjorn Helgaas <bhelgaas@google.com>
>=20
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER =
is
> native"), the PCI core does this for all devices during enumeration.
>=20
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>=20
> Note that this doesn't control interrupt generation by the Root Port; tha=
t is
> controlled by the AER Root Error Command register, which is managed by th=
e
> AER service driver.
>=20
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)