Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <d6a92e81-0f67-68ce-744d-149bbcdc06d9@arm.com>
Date:   Wed, 25 Jan 2023 09:18:30 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v5 0/2] arm64: Fix pending single-step debugging issues
To:     Daniel Thompson <daniel.thompson@linaro.org>,
        Sumit Garg <sumit.garg@linaro.org>
Cc:     will@kernel.org, catalin.marinas@arm.com, liwei391@huawei.com,
        mhiramat@kernel.org, maz@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        mark.rutland@arm.com, dianders@chromium.org
References: <20221219102452.2860088-1-sumit.garg@linaro.org>
 <CAFA6WYOucB3JdVATbydxYuAb0Q5P7ff_JMb=-BgiF+uip8pdpg@mail.gmail.com>
 <Y9AdunpawWzWKIXN@aspen.lan>
Content-Language: en-US
From:   Luis Machado <luis.machado@arm.com>
In-Reply-To: <Y9AdunpawWzWKIXN@aspen.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: BgqlCSeeLBrOQXlkA+4HuPIvuE2hdGX8pFx8tYeRCZS7Ox8dVs5paGMT00Bbfre45hFEc8klDiEjQDVoRX0jTbRRhjzCmMFDnKl/R/oeWpd/eZlWRUiQz+lM82zTJAveXGsm2af6LXcMr63b9DvdwG2Hx2FGAAZKzbVOxXu5UNCjyWLoQqP1M2gFhExJSDcEbVmtXvpLiSNwEVkaAXwa3UHugcFG94aeu9dTy5Tgpg0R3igRREp1cl6Biodavea8NZmRS54d0LfuJQFOv04KKf6nF9NayOSA8/jvFtxWBVUc/25yhhmTb9Cn4Mz5tcMvQ/VwKDlPh3ROUuJqd80wWa1C1wiR8Koj+U5AOisHTBHF24d36ZGvtZM5clx7mCppr9w0nvPNVOuq55HUw4RbUIvp6q0kicHXAMNe6aM+SNyk47L0pc3yrUGCu9+tjvTLCjvzy/se4Q1DJMkIqAFklWw2ph8PhFnY3RKy5+kSj25HIYFY6o80RyplJLQLF9Sm62X+MSvPYdsrE0AMB7SwSIGBH77ToHAggEScTKTlZJzEqowhYRQku7iFLBXNb1qBnFgoYLjO6BjPhLKFpSTyQVsi6Qg0o3TEcpHY4yf/3euEEigJ54sAs3fBtglhDwCcw6gR3DHsbKq/sSvKzzAl1ax/OQAeOCTIaAL5RlTSgzD2qUr/AymfEQPpSSTIU+LTElpJDNy/gVE1f6EXlqBbJk7v7wpvuwTS3HFqjHoxU0zavpM6ZTwxj8Sb4C9Q7ylf+AuXQ4H8BRObCZ8HiwHI4oLqqWWi1NoMGrTdv5jcFnTnzjV45B57dXHAiTJT5el+
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199018)(38100700002)(44832011)(8936002)(5660300002)(86362001)(36756003)(2906002)(2616005)(6506007)(110136005)(6512007)(53546011)(26005)(478600001)(8676002)(186003)(66946007)(66556008)(66476007)(316002)(41300700001)(4326008)(6486002)(31686004)(966005)(83380400001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5615
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 6c94c23d-66bd-418b-3d33-08dafeb52172
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mPuVCZm0/uUvBO5qlh+8XTnf7GAws7wej69au6KH0WhjqVMVUxVPbDn3M7UJn4rlyh+kTspGRqjbYRL5c/D9m+OUXRtxmJJiH9rpi6AFgwf5Am4gNKyoc2yG7d3YtycwNX5tqAGymB4mai6BPRxEH4gwykx7YfRRYShiSJpUzsS07ihkJkJSCtTGaQVATGGMZ8q9Gz+RI3p8YM7dO0YEGB+7ad7pzyfHnukoQaeoHDgVuQokpFVEmVY623CuJ6i2wOIhhLf9FEeqsShCzETMv+wgWNffOw+fkozoj4qAdKLZM16hSmmRtX3BHUf/Jobc7d6/+qxqutKusz559dQW4QH6lN4zmH4gWZXLQEuIwn1QL3d0UDWm4aksk2mTqKBt2IOhpNJkgvcAuwKgQUp8YCwAJN5q3BAzdM+8sq1ffLcz5qsBLqSW/etB5yVF0hLtZwIoXhRkyPE3XoffqOgsvWRLE/IvG7sidVUjlpdQpOpBnDSIS6OtkdAxwLmm9/M1lL6VOGcHdvANkyg2nQGOiluW1njr5r1pUzV+ZnoiJcxmfx5LLbHmbri2TBNuc+YVPerr+TEMbFL+8kmN3IgWM2DIKwN2J6BYx7JM8CKVXgdVCa+KVhywCc4YCGfesw3H/pQZ2zYTdi7RUh6EK3i+b7Hl+fyux+0tC8PUsRSA0QMq+X4XnFSykXPffJC2mmZ2oft1gquwEnhfGLb9p5dN7w7O46MCCV14jqrW4zflmjCaPCNFpOEC0hC1hX1adZw4P4mLOrT8YTs1uDOSXSHc5BBvYY6Qh3ppPMpG/rkN7zWtYgFKtREqHKc658gN2UBm
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199018)(40470700004)(36840700001)(46966006)(31686004)(40480700001)(40460700003)(966005)(2906002)(6486002)(110136005)(478600001)(316002)(86362001)(31696002)(82740400003)(356005)(82310400005)(81166007)(36756003)(36860700001)(336012)(2616005)(6506007)(70206006)(53546011)(8676002)(41300700001)(4326008)(8936002)(47076005)(5660300002)(44832011)(70586007)(6512007)(26005)(107886003)(186003)(83380400001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 09:18:47.0205
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 26c85c56-692b-4d4d-e01c-08dafeb529d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7521
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Is this expected to change single-stepping operation in usespace for debuggers (gdb/lldb)? If so, it would be nice to at least
test it a little to make sure it works.

On 1/24/23 18:04, Daniel Thompson wrote:
> On Thu, Jan 12, 2023 at 02:52:49PM +0530, Sumit Garg wrote:
>> Hi Will, Catalin,
>>
>> On Mon, 19 Dec 2022 at 15:55, Sumit Garg <sumit.garg@linaro.org> wrote:
>>>
>>> This patch-set reworks pending fixes from Wei's series [1] to make
>>> single-step debugging via kgdb/kdb on arm64 work as expected. There was
>>> a prior discussion on ML [2] regarding if we should keep the interrupts
>>> enabled during single-stepping. So patch #1 follows suggestion from Will
>>> [3] to not disable interrupts during single stepping but rather skip
>>> single stepping within interrupt handler.
>>>
>>> [1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/
>>> [2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/
>>> [3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/
>>>
>>> Changes in v5:
>>> - Incorporated misc. comments from Mark.
>>>
>>
>> Since patch #1 has already been reviewed/acked by Mark and the
>> complete patchset has been tested by Doug, would it be fine for you to
>> pick up this patchset? It fixes a real single stepping problem for
>> kgdb on arm64.
> 
> Sorry to be quiet for so long.
> 
> Testing this patch set has proven to be a little difficult.
> 
> It certainly fixes the single step tests in the kgdbtest suite.
> That's a good start.
> 
> Unfortunately when testing using qemu/KVM (hosted on NXP
> 2k/Solidrun Honeycomb) the patch set is resulting in instability
> running the built-in self tests (specifically this one:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/misc/kgdbts.c#n74 ). Running this test using the kgdbtest harness
> results in the test failing roughly a third of the time.
> 
> The error reported is that the trap handler tried to unlock a spinlock
> that isn't currently locked. To be honest I suspect this is a generic
> problem that the new feature happens to tickle (this test has
> historically been unreliable on x86 too... and x86 is noteworthy for
> being the only other platform I test using KVM rather than pure qemu).
> Of course the only way to prove that would be to find and fix the
> problem in the trap handler (which probably involves rewriting it) and I
> haven't managed to do that yet.
> 
> In short, I think the debugger is more useful with this patchset than
> without so, although it is caveated by the above, I'd call this:
> 
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> Tested-by: Daniel Thompson <daniel.thompson@linaro.org>
> 
> 
> Daniel.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel