Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58624C27C76 for ; Wed, 25 Jan 2023 10:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235474AbjAYKCf (ORCPT ); Wed, 25 Jan 2023 05:02:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234689AbjAYKCd (ORCPT ); Wed, 25 Jan 2023 05:02:33 -0500 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749B253B20; Wed, 25 Jan 2023 02:02:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674640935; cv=none; d=zohomail.com; s=zohoarc; b=bO0Jgi+NMLPOKv1n67AGYFqKmCmzSrXf+YbOLqb3lcnnMWBHWDOtPFf10qsY5r8Oyq6MU0l5ytB505qxUgElHtFhDNVPlqG1NmidiClxPMAV5qqPOGI5s3RXAM9pzB7cK7p0j6wxEbj6JrUrJen33B51iCkPGR9UEK+GPFyvdcQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674640935; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=8T0jm15KjYlDRi1z8VGf6mV8Jc1j+El4vs+3OWm4xCQ=; b=K4rpu+Lm1I4RyX/haKCf4eFEA3j1w8Hnb/vYLU924EwdpvgcSpntciqqgsPVWpWUGlgkYdYLwts8cJGKGvXPtC8sw7W3wU4hsZRF2i7zlDTiBBQlfv+/NrxGHg1bsGqcpGkPoPD94Qcf/TeAh6K/SIg2ZzmrWo//NqU8zQetpzU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1674640935; s=zmail; d=linux.beauty; i=me@linux.beauty; h=Date:Date:Message-ID:From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:MIME-Version:Content-Type:Message-Id:Reply-To; bh=8T0jm15KjYlDRi1z8VGf6mV8Jc1j+El4vs+3OWm4xCQ=; b=TZmf638uRJ8i5kzEqJGwyC9lylJZDkugjFhadj2uJgHqErwhmlyxoI6IERd3bbhu NEaH+mS+5DcVlZavIYXvUUHJd4q1LaocsJxMrst0I0jYW33iTQ+rMUweGjxkW5aY/VS Sgosb8uQJRZQUrEJv18D1luK5zPaWxLeeYkcjXco= Received: from lchen-xiaoxin.linux.beauty (221.225.241.248 [221.225.241.248]) by mx.zohomail.com with SMTPS id 1674640933874576.2974511908947; Wed, 25 Jan 2023 02:02:13 -0800 (PST) Date: Wed, 25 Jan 2023 18:01:25 +0800 Message-ID: <87v8kvgcga.wl-me@linux.beauty> From: Li Chen To: Greg Kroah-Hartman Cc: Li Chen , Jiri Slaby , Sumit Semwal , Christian =?ISO-8859-1?Q?K=F6nig?= , open list , "open list:SERIAL DRIVERS" , "moderated list:ARM/Ambarella SoC support" , "open list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port In-Reply-To: References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-11-lchen@ambarella.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Jan 2023 17:51:25 +0800, Hi Greg, Sorry for my late reply. Greg Kroah-Hartman wrote: > > On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > > This driver add support for Ambarella's uart, which > > can be used for console and etc. > > > > Signed-off-by: Li Chen > > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > > --- > > MAINTAINERS | 1 + > > drivers/tty/serial/Kconfig | 16 + > > drivers/tty/serial/Makefile | 1 + > > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++ > > drivers/tty/serial/ambarella_uart.h | 120 ++ > > Why do you need a .h file for a single .c file? They should all be in > one file please. Ok, I will combine them into single source file. > Also, no change-id, you know this... > > thanks, > > greg k-h Regards, Li