MIME-Version: 1.0
References: <20230123151523.369225-1-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230123151523.369225-1-krzysztof.kozlowski@linaro.org>
From:   Daniel Palmer <daniel@thingy.jp>
Date:   Wed, 25 Jan 2023 19:20:04 +0900
Message-ID: <CAFr9PXn+XMzz8uZzNwDNdCpYeN4Nf6rc6nXWvuf_TCRe2B_PXw@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Romain Perier <romain.perier@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, 24 Jan 2023 at 00:15, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bindings expect UART/serial node names to be "serial".

snip

> -                       pm_uart: uart@221000 {
> +                       pm_uart: serial@221000 {
>                                 compatible = "ns16550a";
>                                 reg = <0x221000 0x100>;
>                                 reg-shift = <3>;
> --
> 2.34.1
>

I have this change in my changes to use the proper uart driver that I
need to fix up and resend but it doesn't hurt to fix it now.

Reviewed-by: Daniel Palmer <daniel@thingy.jp>

But we don't have anything queued up in our tree to send a PR for so
maybe this should be merged via soc.